Mysql Update

firest0rm

                        $sql="UPDATE user SET icq='$icq',msn='$msn',aim='$aim',day='$day',month='$month',year='$year',location='$location',website='$website',occupation='$occupation',interests='$interests',timezone='$timezone',maillist='$maillist',$signiture='$signiture' WHERE user_name='$user_name'";
                        $result=mysql_query($sql);
                        return true;
                        $feedback .=  ' ERROR Mysql - '.mysql_error();

Doesnt update the database, and there is no error message from mysql 😕

barand

Looks like you are returning from the function before the call to mysql_error().

blindeddie

try displaying the query to determine what is actually beng update. i.e.

echo $sql;

don't actually execute the query. examine the query and determine where the problem might be. The syntax looks correct, so one problem is that it might not be finding a record to update.

keep me posted.

blindeddie

I just noticed on the last line $signiture='$signiture'. Is this column name actually '$signiture'? or should it be signiture = $signiture? also I think barand is right, you are forcing php to not report an error by using 'Return True'. try taking it out and see if the error reports.

firest0rm

Thanks ppl. Im always makin mistakes like that. I need to find a good php ide program...

cynosure

I have a problem along the same lines. Maybe someone here can find a simular error in my code. I can't figure out this one for the life of me.

<HTML>
<?php
if($update)
{
$db = mysql_connect("localhost", "root","");
mysql_select_db("databasename",$db);
$sql = "UPDATE employees WHERE EmployeeID=$id SET FirstName='$FirstName',LastName='$LastName',Address='$Address',City='$City',State='$State'";
$result = mysql_query($sql);
echo "Thank you! Information updated.\n";

}
else
{
$db = mysql_connect("localhost", "root", "");
mysql_select_db("databasename",$db);
$result = mysql_query("SELECT * FROM employees WHERE EmployeeID=$id",$db);
$myrow = mysql_fetch_array($result);
?>
<form method="post" action="<?php echo $PHP_SELF?>">
<input type="hidden" name="id" value="<?php echo $myrow["id"]?>">
First name:<input type="Text" name="FirstName" value="<?php echo $myrow["FirstName"]?>"><br>
Last name:<input type="Text" name="LastName" value="<?php echo $myrow["LastName"]?>"><br>
Address Name:<input type="Text" name="Address" value="<?php echo $myrow["Address"]?>"><br>
City:<input type="Text" name="City" value="<?php echo $myrow["City"]?>"><br>
State:<input type="Text" name="State" value="<?php echo $myrow["State"]?>"><br>
<input type="Submit" name="update" value="Update information"></form>
<?
}
?>
</html>

blindeddie

try the query below... the WHERE statement needs to come after the set statement...

sql = "UPDATE employees SET  FirstName='$FirstName',LastName='$LastName',Address='$Address',City='$City',State='$State' WHERE EmployeeID=$id ";

cynosure

still no such luck 🙁

If I replace the update sql statement with this...
$sql = "DELETE FROM employees WHERE EmployeeID=$id";
it still doesn't work; however, this script does when it has it's own page...

<HTML>
 <?php
$db = mysql_connect("localhost", "root", ""); 
mysql_select_db("whatever",$db); 
mysql_query("DELETE FROM employees WHERE EmployeeID=$id",$db); 
echo "Information Deleted"; 
?>
</HTML>

When I try to just throw all that in the top portion of the script, it doesn't execute. So the only thing I can come up with is that it's having trouble connecting to the db but I have no idea what to do. It's clearly having no problem connecting in the lower portion of the script because it can <?php echo $myrow["Stuff"]?>. Any ideas?

xblue

did you follow blindeddie's suggestion?

Originally posted by blindeddie
try displaying the query to determine what is actually beng update. i.e.

echo $sql;

what does it say?

cynosure

UPDATE employees WHERE EmployeeID= SET FirstName='John',LastName='Doe',Address='36 Ave',City='Chicago',State='IL'

Moonglobe

your $id isn't set. where is it coming from? a cookie?