delete row problem

danville

I am tring to delete a row form a news database. When I submit I get no errors but row doesn't delete. I tried to echo the "id" in the else statement but nothing displays so I am assuming that it is not making it there. Can anyone help? Thanks in advance!

Here is my code:

<form method="get" action="dbdelete.php">
<?
mysql_pconnect("192.168.1.27","root","pass"); 
mysql_select_db("test");
if(!$submit)
{
    $result = mysql_query("select * from news order by id"); 
    while($row=mysql_fetch_array($result))
    { 
        $title=$row["title"];
        $id=$row["id"];
?>
<INPUT TYPE="RADIO" NAME="id" VALUE="<?php echo $id;?>">
<?php echo $id;?>
<?php echo $title;?><br>
<?
}
?> 
<input type="submit" value="submit" name="Submit"></form>
<?
}else{
    echo $id;
    $sql = "DELETE FROM news WHERE id=$id";
    $result = mysql_query($sql);
    echo "Record deleted!";
}
?>

blindeddie

More than likely, you have the register_global_variables flag set to off n the PHP.ini file (This is a good thing). to resolve your problem, your delete query should look like this...

$sql = "DELETE FROM news WHERE id=$_REQUEST[id]";

see if that works...

danville

izomorfix

Try changing this:
$sql = "DELETE FROM news WHERE id=$REQUEST[id]";
to this:
$sql = "DELETE FROM news WHERE id='".$REQUEST[id]."'";

If you can't see the quotes well just copy&paste!!!.

danville

No luck there either izomorfix.

izomorfix

Oh man, I wonder why it didn't work.I can give u several tips:
1.Upgrade to the latest PHP.
2.Try changing mysql_pconnect to mysql_connect because from the script i realised u didn't close the connection 🆒 or
put mysql_close or something like that(i don't remember the proper syntax.)
I wanted to ask you:does $id print out?

kevinsequeira

have u tried to change the form method to POST instead of GET ??

reg
kevin

kevinsequeira

DAMN !!!

u need to change

if(!$submit) to if(!$Submit) , uppercase S

reg
kevin