help with copy()

DigitalDesign

This code (just a test to attempt uploading files) which I've written for uploading an image into a file and the name of the image into a db isn't working properly. The name of the file is being inserted into the db, and subsequently printed to the browser, but when it comes to copying the file into the directory, I'm seeing my error message. I've tried using copy(), move_uploaded_file(), $_POST, $HTTP_POST_FILES, and about everything I could think of, but the image simply won't copy its self into the dirrectory. Any ideas why would be more than appriciated!!

Code:

</form>

</body>
</html>

<?php
require ("connect.php");
$pic1 = $_POST['pic1'];

$result = ("INSERT INTO img VALUES(NULL,'$pic1_name')");
mysql_query($result) or die();

$pathfiles1 = "podaci/anna/";

@$upload = copy($pic1,$pathfiles1.$pic1_name);
print "$pic1_name";
if (!$upload) die ("Didn't work.");

echo "<img src=http://localhost/podaci/anna/$pic1_name>";

ir4z0r

if u use "file" as input type, then u have to use the $_FILES array,
here's an excerpt from php.net:

$_FILES['userfile']['name']
The original name of the file on the client machine.

$_FILES['userfile']['type']
The mime type of the file, if the browser provided this information. An example would be "image/gif".

$_FILES['userfile']['size']
The size, in bytes, of the uploaded file.

$_FILES['userfile']['tmp_name']
The temporary filename of the file in which the uploaded file was stored on the server.

$_FILES['userfile']['error']
The error code associated with this file upload. ['error'] was added in PHP 4.2.0

where userfile is pic1

btw, i think the @ must be in front of the function call, not the return var

DigitalDesign

I've tried this, and the same thing still happens. But I think, that now the problem is, it's not leting me write to the dirctory. WHich is silly because this is a "localhost" which I've personally installed on my computer. How should I change this, if this is indeed the problem??

ir4z0r

well at first remove the @ for testing, then you'll see the error

navigate to the directory and do a "chmod 777 *" there, which will
give ALL users who have access to your computer the permission
to read, write and execute these files, hence the apache user, too

DigitalDesign

I've made changes to the script, such that it now looks like this:

</form>

</body>
</html>

<?php
require ("connect.php");
$pic1 = $_FILES['pic1'];

$path="cms/anna/";
$pathfiles="../files/articles";

$result = ("INSERT INTO ban VALUES(NULL,'$pic1_name')");
mysql_query($result) or die();
chmod($pathfiles, 777);

$upload = copy($_FILES['pic1']['name'], $pathfiles."/".$pic1_name);

echo "$pic1_name";
?>

but when I try to upload a file, I'm getting this error message:

Warning: chmod failed: No such file or directory in c:\apache\htdocs\cms\anna\img2.php on line 11

Warning: Unable to open 'mgr3_05.jpg' for reading: No such file or directory in c:\apache\htdocs\cms\anna\img2.php on line 13
mgr3_05.jpg

matt_4013

change your copy function to

move_uploaded_file($_FILES['pic1']['tmp_name'], $pathfiles."/".$pic1_name);

PHP uploads the file to a temporary location first. When you were using $_FILES['pic1']['name'], that actually refers to the original filename.

You'll also need to change the permissions on your directory that you're copying to (the entire directory, and only once) so that the user the apache process is running as has full write access.

ir4z0r

chmod() doesn't work on Windows systems afaik, but anyway it doesn't need
to be executed each time: if you have uploaded it to a Linux/UNIX Server
chmod the dir with your ftp prog, but not with the script