PHP being a bitch

pablodelapena

Ok, i REALLY dont see whats wrong here, but the script just refuses to execute the If statement. ok, what it does is checks to see if any vital bits of information have not been submitted from the register form and if it finds that it hasnt got a certain bit it redirects back to promt the user. Only it doesnt, it decides to carry on with the script.

heres the code

//If the user does not enter one of the details redirect them to fill them in.
if ((!isset($chosenusername)) OR (!isset($password)) OR (!isset($password2)) OR (!isset($email)) OR (!isset($name)) OR (!isset($location))) {
	header ("location: register.php?error=empty&chosenusername=$chosenusername&email=$email&name=$name&location=$location");
	exit();
};

ir4z0r

try it without isset(), cause I think the vars are set, but empty

if (!($var1 && $var2 && $var3)) { ...

suntra

Also, you must have a complete URL with header("Location: ...") and Location must have a capital L... surely it works if you don't do that, but some browsers are very strict and only respect standards...

Also, don't put a semi-colon ( ; ) after a " } "...

if(condition) {
code
}

NOT

if(condition) {
code
}

Like said ir4z0r, even though a field is empty, it is set.. so if you check if it is set hoping it will return false since it is empty, you'll hope for a very long time... ! You must check if the field is empty, not if it is set. I recommend you to use the trim() function to remove unuseful spaces...

if(trim($my_variable) == "") {
// the field is empty.
}

Suppose $my_variable = "", the condition will be true...
Suppose $my_variable = " ", the condition will also be true...

Did it help ?

(Also, please check your language...)

matt_4013

The above suggestions are true, but also, if this is being submitted from a form, you might want to have a look at register_globals in your php.ini, and see what it's set to. If it's turned off, which is default, you'll need to refer to your variables passed from the form using the Super-Global variables, such use $POST, $GET, or $_REQUEST.