mysql insert problem

TravisB

I am trying to insert data from a form into a mysql database. I have tested and I can connect and I can read from the table. For some reason I can not insert into the table. The code is below:

<?php

//get db vars
include 'db.php';

if (!($connection = @ mysql_connect($hostname, $username, $password)))
die("Could not connect to the database: " . mysql_error());

if (!mysql_select_db($dbname, $connection))
die ("Could not find database" . mysql_error());

//store form vars
foreach($HTTP_POST_VARS as $varName => $value){
	$formVars[$varName] = $value;
	}

$num_occ = $formVars["num_occ"];
$url = $formVars["url"];

$counter = 1;

//loop to get each set of vars
while($counter <= $num_occ)
{
	$long = $formVars["set" . $counter . "_long"];
	$lat = $formVars["set" . $counter . "_lat"];
	$desc = $formVars["set" . $counter . "_desc"];
	$query = "INSERT INTO test	
	url = \"$url\",
	long = \"$long\",
	lat = \"$lat\",
	desc = \"$desc\"";

mysql_query($query, $connection);

$counter++;
}

?>

matt_4013

That's because your insert syntax is wrong 😉 The way you have it works for updates, but not insert. Try this:

$sql = "INSERT INTO test (url, long, lat, desc) VALUES ('$url', '$long', '$lat', '$desc')";
$rs = mysql_query($sql, $connection) or die(mysql_error());

Just a tip for debugging there. At the end of all your queries, you might want to chuck in the or die(mysql_error()), because that will tell you straight off if there's a problem with the query, and what it is. Try not to use it on a production server though, because it will allow a malicious user to get information about your database structure.

Hope that helps!
Matt

TravisB

Yep, that was the problem. Thanks for your help.