hi guys not sure what i am doin wrong but i know its a simple one

beebeedeux

ok trying to fix a simple page i had working before on my site

basically its just to add a user's info to my mailing list db

somewhere along the lines this page broke? not sure how but i cant seem to fix it

every sample script i steal code from inputs a blank record into my db if it works at all 🙁 not too happy right now as ive spent a good part of a day trying to work thru this

ok here's my code:

submitform.html

<table align="center" width="80%" cellspacing="2" cellpadding="2" border="0">
<tr>
<td class="subhead">First Name</td>
<td><input type="text" name="fname" size="30"></td>
</tr>
<tr>
<td class="subhead">Last Name</td>
<td><input type="text" name="lname" size="30"></td>
</tr>
<tr>
<td class="subhead">City</td>
<td><input type="text" name="city" size="30"></td>
</tr>
<tr>
<td class="subhead">State</td>
<td><input type="text" name="state" size="30"></td>
</tr>
<tr>
<td class="subhead">Age</td>
<td><input type="text" name="age" size="30"></td>
</tr>
<tr>
<td class="subhead">ISP</td>
<td><input type="text" name="isp" size="30"></td>
</tr>
<tr>
<td class="subhead">Email</td>
<td><input type="text" name="email" size="30"></td>
</tr>
<tr>
<td class="subhead">AIM</td>
<td><input type="text" name="aim" size="30"></td>
</tr>
<tr>
<td class="subhead">Yahoo IM</td>
<td><input type="text" name="yahoo_im" size="30"></td>
</tr>
<tr>
<td colspan="2" align="center">
<input type="submit" name="submit" value="Submit">
</td>
</tr>
</table>

</form>

</body>

</html>

then the submitform.php code:

<html>
<body>
<?php

mysql_connect ("localhost", "mysqluser", "********");

mysql_select_db ("bennies");

mysql_query ("INSERT INTO users (id, fname, lname, city, state, age, isp, email, aim, yahoo_im)

VALUES ('$id', '$fname', '$lname', '$city', '$state', '$age', '$isp', '$email', '$aim', '$yahoo_im')

");

print ($fname);

print (" ");

print ($lname);

print ("<p>");

print ("Thanks for submitting your name.");

?>
</body>
</html>

after submission i see the: Thanks for submitting your name text and a new blank record in my db?

why isnt php taking my values from the form correctly? i basically took the code line for line from a tutorial i found

thanx for all the help

bb~deux!

beebeedeux

here's the current location of the form

http://test.gohomebennies.com/phpworkshop/submitform.html

🙂

ir4z0r

use $_GET['var'] instead of $var for every variable passed by the form

if form method = post, then use $_POST[]

this is because newer versions of php have globals_registered: off
(security reason)

beebeedeux

do i keep my dollar signs with those variables? ill find out either way thanx man

beebeedeux

i fixed by doin this:

//assign form values to variables
$id = $GET['id'];
$fname = $GET['fname'];
$lname = $GET['lname'];
$city = $GET['city'];
$state = $GET['state'];
$age = $GET['age'];
$isp = $GET['isp'];
$email = $GET['email'];
$aim = $GET['aim'];
$yahoo_im = $GET['yahoo_im'];

mysql_connect ("localhost", "mysqluser", "*******");

mysql_select_db ("bennies");

mysql_query ("INSERT INTO users (id, fname, lname, city, state, age, isp, email, aim, yahoo_im)
VALUES ('$id','$fname', '$lname', '$city', '$state', '$age', '$isp', '$email', '$aim', '$yahoo_im')
");

im sure there's a way i couldve done that easier though

ir4z0r

although there's a function "import_request_variables()" that's
the usual way, but if you use the vars just once, you would use
it directly, not assigning the value to a local var

Natty_Dreadlock

im sure there's a way i couldve done that easier though

There's no easy way... you might reenable register_globals in your php.ini, which has been disabled with some php-release. But I do not recommend to do so. The php guys had reasonable motives for setting it to off, so the solution u use now is rather ok.

beebeedeux

i cant assign all those values in an array? then use the array to populate my sql insert statement? i wouldve thunk i could do that but i am unsure what the syntax would be

Natty_Dreadlock

Maybe use something like this - But be aware, this is untested and written from the top of my head:

$query = "INSERT INTO users (id, fname, lname, city, state, age, isp, email, aim, yahoo_im) 
VALUES (";
foreach($dataArray as $piece)
{
$query .= "'$piece'";
}
$query .= ");";
mysql_query($query);

This code assumes that u put all the values into the array $dataArray.
Hope that helps - and if it does not work, notify me
Hasta siempre

beebeedeux

thanx natty dreads

hey do you really have dreads? my gf does

sostack

<?
$query = "(INSERT INTO users(";
foreach($_GET as $name => $value)
{
$query .= $name . ",";
$values .= "'" . $value . "',";
}
$query = substr($query, 0, -1) . ") VALUES (";
$values = substr($values, 0, -1) . ")";
$query .= $values;
mysql_query($query);
?>

moongurl

<html>
<head>
<title>newsletter</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body bgcolor="#000000" text="#CCCCCC" link="#FF0000">
<CENTER><b><font face="Verdana, Arial, Helvetica, sans-serif" size="4" color="#CCCCCC"><form name="form1" method="post" action="news.php">
<input type="text" name="name" size="35" maxlength="35" value="Name to address it to.">
<br>
<input type="text" name="email" size="35" maxlength="35" value="E-Mail Address.">
<br>
<textarea name="sug" cols="35" wrap="VIRTUAL" rows="8">Suggestions and comments.</textarea>
<br>
<input type="submit" name="Submit" value="Join">
<input type="reset" name="Submit2" value="Clear all">
</form>
<?php
print ("Thank you Submited the Following info");//Lets user know success has occured
print ("<BR>");
Print ("Your name is:");
print ("<BR>");
print $REQUEST['name'];//States name
print ("<BR>");
Print ("Your E-Mail is:");
print ("<BR>");
print $REQUEST['email'];//States email
print ("<BR>");
Print ("Your comments or suggestions:");
print ("<BR>");
print $REQUEST['sug'];//States suggestion box
the print function repeats the info to the user so they can be sure they got it right ..... i ended up haveing to use
$REQUEST['var']
to get mine to work it wouldn't accept the get meathod :S
hope it helps hunny

beebeedeux

what does the .= syntax mean???

stolzyboy

there is an easy way to get your $POST or $GET variables into regular $variables, use extract()

extract($_POST);

// or use

extract($_GET);