deletefile&filename OR unlink??

[KrisCons]

Hi,

Im having a slight problem in that the script im using doesn't delete the file from a server when it should do.

When you click delete via the browser, the script that is run is :

if (!file_exists("userfiles/$filename"))
{
echo " 
<a href=\"index.php?action=deletefile&filename=$filename&directory=userfiles&\">

However, this little function is further up my page :

function DeleteFile($filename)
{
if (file_exists("$filename"))
unlink("$filename");

if (file_exists("$filename.desc"))
{unlink("$filename.desc");}

Is the first bit of script not working because of this function? Im not too sure as to what I should have as my "delete script" behind my delete button on the page?

Can anyone help or advise?

🙁

[webcase]

Forget the specific problem for a while, and consider yourself lucky that there's something that doens't work.

This line is going to be VERY DANGEROUS:

echo "<a href=\"index.php?action=deletefile&filename=$filename&directory=userfiles&\"> "

Don't let smart people write in their browser:

http://yoursite/index.php?action=deletefile&filename=passwd&directory=etc

Going back to your original problem try to check the values returned by ulink and the permissions on the file

ciao,
*M