problem with passing value into a script

dcharlier

Hello,

I am new to PHP. I am trying the following sample script, however, it does not work.

The problem seems to be the following : when entering :

http://localhost/three.php?id=2 , this value 2 is not passed into the script. (so, the "if" never works, "else" is always activated).

Any Ideas ?

Many Thanks

Dirk

<html>

<body>

<?php

$db = mysql_connect("localhost");

mysql_select_db("usages",$db);

// display individual record

print ($userid);

if ($userid) {

$result = mysql_query("SELECT * FROM users WHERE id=$id",$db);

$myrow = mysql_fetch_array($result);

printf("First name: %s\n<br>", $myrow["firstname"]);

printf("Last name: %s\n<br>", $myrow["lastname"]);

printf("Birthyear: %s\n<br>", $myrow["birthyear"]);

printf("Email: %s\n<br>", $myrow["email"]);

} else {

// show employee list

$result = mysql_query("SELECT * FROM users",$db);

if ($myrow = mysql_fetch_array($result)) {

  // display list if there are records to display

  do {

    printf("<a href=\"%s?id=%s\">%s %s</a><br>\n", $PHP_SELF, $myrow["id"], $myrow["firstname"], $myrow["lastname"]);

  } while ($myrow = mysql_fetch_array($result));

} else {

  // no records to display

  echo "Sorry, no records were found!";	

}

}

</body>
</html>

OhLordy

Well for one thing it's called id in the address bar and userid in the script.

Also do a search on global varibales because this has been written assuming that register globals is set to on (which is not good practice).

Good Luck
Rob

dcharlier

Hello Rob,

How can I set the global variables to on.

I tried the following :

putting a .htaccess file with the following contents :

php_flag register_globals on

However, after inserting this in the directory, I receive the following error in the error log:

[Wed Apr 30 11:49:43 2003] [alert] [client 127.0.0.1] c:/program files/apache group/apache/htdocs/ht.ac: Invalid command 'php_flag', perhaps mis-spelled or defined by a module not included in the server configuration
[Wed Apr 30 11:49:52 2003] [alert] [client 127.0.0.1] c:/program files/apache group/apache/htdocs/ht.ac: Invalid command 'php_flag', perhaps mis-spelled or defined by a module not included in the server configuration

OhLordy

It's a good idea to get into the habbit of coding with register globals off
use $GET['varname'] or $POST['varname'] etc...

Hope This Helps
Rob

dcharlier

I have made the following :

1) file form.php :

First Name: <input type="text" name="firstname" size="20"><br>
Last Name: <input type="text" name="lastname" size="30"><br>

</form>

2) file process.php :

// connect to db

$db = mysql_connect("localhost");

// select db

mysql_select_db("usages",$db);

// run insert query

$GET['firstname'];
$GET['lastname'] ;

$query = mysql_query("INSERT INTO users (firstname, lastname) VALUES ('$firstname', '$lastname')");

// display message to user

printf ($firstname);

RESULT :

Apparantly, entries are added to the database BUT they are all empty. It seems that the variables are not getting from the form.php to the process.pgp

Many Thanks in advance ...

Dirk

dcharlier

form.php :

First Name: <input type="text" name="firstname" size="30"><br>
Last Name: <input type="text" name="lastname" size="30"><br>
Birth Year: <input type="text" name="birthyear" size="60"><br>
Email: <input type="text" name="email" size="60"><br>
<input type="submit" value="Submit">

</form>

proccess.php:

$firstname = $POST['firstname'];
$lastname = $POST['lastname'];
$birthyear = $POST['birthyear'];
$email = $POST['email'];

// connect to db

$db = mysql_connect("localhost");

// select db

mysql_select_db("usages",$db);

// run insert query

$query = mysql_query("INSERT INTO users (firstname, lastname, birthyear, email) VALUES ('$firstname', '$lastname','$birthyear','$email')");

// display message to user