function not working

[KrisCons]

Hi - I can't figure this one out. Can someone help!?!

All i want to do is delete an uploaded file via the browser. Simple upload/download program, that I have obtained but the delete function isnt working and I dont know why.

The function is:

function DeleteFile($filename)
{
if (file_exists("userfiles/$filename")){
unlink("userfiles/$filename");
}

Ok, now further down my page I have this:

if (file_exists("userfiles/$filename"))
{
echo " 
<a href=\"index.php?action=deletefile&filename=$filename&directory=userfiles\">

<img src=\"images/delete.gif\" border=\"0\"></a>";
}

The last bit echos the delete button and when clicked, it should delete the file, but it doesnt delete it. Im admittedly a novice at php so if someone could write into the above what I should have, I would be eternally grateful.

Do I need to call the function in my A HREF bit?? If so, how?

Regards.
K.

[KrisCons]

I also have this bit further down my page:

case "deletefiles";
require("include/${language}.php");
/$adminloggedin = verify_admin($loginname, $password);/
include($headerpage);
/if ($adminloggedin)
{/
DeleteFilesByList($FileList);
place_header("loginname: files succesfully deleted.");
/}
else
{
place_header("$loginname: can't delete files - account invalid.");
}
show_contents();
break;
/

As you can see, I have stripped out anything to do with adminloggedin right the way through the code, but I thought I had better post this extra bit incase it helps.

If anyone has any ideas I would be very grateful.

Thanks

[jayant]

// notice its : not ; as u typed
case "deletefiles":
require("include/${language}.php");
/$adminloggedin = verify_admin($loginname, $password);/
include($headerpage);
/if ($adminloggedin)
{/

// are u sure $FileList has the list of filenames to be deleted
// check by using print_r($FileList);
// also are you calling function DeleteFile() from inside of
// DeleteFilesByList().

DeleteFilesByList($FileList);

place_header("loginname: files succesfully deleted.");

/}
else
{
place_header("$loginname: can't delete files - account invalid.");
}
show_contents();
break;
/

[KrisCons]

Well, the FilesByLIst bit doesnt actually effect the page if I commment it al l out. I think that bit was only used before I stripped out the admin side of it, because originally, the admin could only delete and users could only view.

I have changed it so users can view/delete which is what I need.

So I think I need to sort out the :

if (file_exists("userfiles/$filename"))
{
echo "

<a href=\"index.php?action=deletefile&filename=$filename&directory=userfiles\">

<img src=\"images/delete.gif\" border=\"0\"></a>";
}

bit first??

[jayant]

a href will just show the link. the deletion part will only work
if DeleteFile is called, which should be called by DeleteFilesByList if $FileList is an array

or we can directly call DeleteFile($filename)

where DeleteFilesByList is called

[iainca]

I'm not sure if I've misunderstood, but it seems you need:

function DeleteFile($dirname,$filename) {
  if (file_exists("${dirname}/${filename}")) {
    return unlink("${dirname}/${filename}");
  }
  return FALSE;
} 

switch($_GET[action]) {
  case "deletefile":
     $filename = $_GET[filename];
     $dirname = $_GET[dirname];
     $success=DeleteFile($dirname,$filename);
     break;
  default:
     break;
}

You can then check the outcome using the return value ($success), which will be true or false.

If you're using an older version of PHP, don't forget to change '$_GET' for '$HTTP_GET_VARS'

HTH,

Iain

[KrisCons]

Cheers Iain,

Ok, that worked (and my eyes lit up!), but for some reason, it only worked on the files which were already uploaded. So I deleted them - great, but then when I uploaded another file and tried to delete that, it didnt delete.

Im new to php so is this somethign you know of and how to fix, cos to me, it doesnt actually make any sense why one file uploaded yesterday deleted fine, but anything I upload today - will not??

This is my code so far:

function DeleteFile($UseFolder,$filename) {
if (file_exists("${UseFolder}/${filename}")) {
return unlink("${UseFolder}/${filename}");
}
return FALSE;
}

switch($GET[action]) {
case "deletefile":
$filename = $GET[filename];
$UseFolder = $_GET[UseFolder];
$success=DeleteFile($UseFolder,$filename);
break;
default:
break;
}

And then this is the main bit:

if (!file_exists("$UseFolder/$filename"))
{
echo "&nbsp;
<a href=\"index.php?action=deletefile&filename=$filename&directory=$UseFolder&\">
<img src=\"images/delete.gif\" border=\"0\"></a>";
}
else
{
if (file_exists("$UseFolder/$filename"))
{
echo "&nbsp;
<a href=\"index.php?action=deletedir&filename=$filename&directory=$UseFolder&\">
<img src=\"images/delete.gif\" border=\"0\"></a>";
}
}
if(empty($directory)) {
$UseFolder = "userfiles";
} else {
$UseFolder = "userfiles/$directory";
}
echo "<a target=\"blank\" href=\"$UseFolder/$filename\">
<img src=\"images/download.gif\" alt=\"$mess[23]\" width=\"20\" height=\"20\" border=\"0\"></a>";

Right, can you see anything wrong in there?

Again, thanks in advance😕

[KrisCons]

Sorry guys,

my mistake. It does still delete, but it wont delete anything that is first in the list (i.e. the first file in the browser window).

This is very strange bearing in mind that it goes in alphabetical order. If b.doc is top of the list, it wont delete using your code, but if I upload a.doc, b.doc moves down one and I can delete it then, but a.doc will not be deleted - does that make sense???