Simple uploadscript doens't works

[Bootsman123]

<?php
if (!isset($file)) {
?>
<form name="upload" method="post" action="upload.php" enctype="multipart/form-data">
<b>Foto uploaden:</b><br>
<input type="file" name="file"><br>
<input type="submit" name="Submit" value="Upload">
</form>
<?php
} else {
$uploaddir = "images/";
if (is_uploaded_file($file)) {
if (move_uploaded_file($file, $uploaddir . $file)) {
echo "Gelukt!";
} else {
echo "Failed!";
}
} else {
echo "Failed!";
}
}
?>

Does anybody knows what's wrong? My PHP version is 4.1.0. I keep getting 'failed'.

[zingbats]

I would find a simple upload script and use that. Alter and edit where needed. That is a good way to improve your skills and get a working scrips 😃

http://www.hotscripts.com

[Bootsman123]

But I like making things myself. 🙂

[laserlight]

well, perhaps you should use this version to help you debug:

<?php 
if (!isset(file)) { 
?> 
<form name="upload" method="post" action="upload.php" enctype="multipart/form-data"> 
<b>Foto uploaden:</b><br> 
<input type="file" name="file"><br> 
<input type="submit" name="Submit" value="Upload"> 
</form> 
<?php 
} else { 
	$uploaddir = "images/"; 
	if (is_uploaded_file($file)) { 
		if (move_uploaded_file($file, $uploaddir . $file)) { 
			echo "Gelukt!"; 
		} else { 
			echo "Failed!"; 
		} 
	} else { 
		echo "Failed: not uploaded by POST method"; 
	} 
} 
?>

[zingbats]

Don't try and run before you can walk. Just take a look at a script and see how they do it. Search google for tutorials as well.

[Bootsman123]

I already searched and looked at other scripts, but I'll look once more.