deleting rows from table

[Myrkul]

alright here is my script.. any thoughts on why isn't it working?

elseif ($submit == "Delete")
{
 $strSql = "DELETE * FROM news WHERE ID = $ID";
 mysql_query ($strSql,$db) or die ("Your DELETING is weak master, and it has failed.");
}
mysql_close($db);
?>

I get the die message o.0

[ir4z0r]

does the row you wish to delete exist? Notice that variable names
are case-sensitive

or try using single quotes ' around $ID

[laserlight]

DELETE FROM news WHERE ID = $ID
would be correct syntax, I believe

[BulldogGC]

That IS the correct syntax.
Are your global variables on or off?

If global variables aren't on then it will give off that error message.

[Myrkul]

laser i tried that, didnt work..also adding single quotes didnt work.

I've also discovered another problem:

<form action="admin.php" method="post" name="editform">
			Select News To Edit: <select name="edit">
<?php
$result = mysql_query ("SELECT * FROM news ORDER BY ID DESC", $db) OR die("shit");

while ($row = mysql_fetch_array($result))
{
 echo "<option value=\"".$row["ID"]."\">".$row["Title"]."</option>";
 echo "<br>";
}
 ?>
			</select>

I get the error
Warning: mysql_query(): 1 is not a valid MySQL-Link resource in /home/swhyperspace/edit.php on line 50
line 50 is the $result line.

[CaptianChaos]

Try this instead:

<form action="admin.php" method="post" name="editform">
Select News To Edit: <select name="edit">
<?php

$result = mysql_query ("SELECT * FROM news ORDER BY ID DESC", $db);

if (!$result) {
die("shit");
}

while ($row = mysql_fetch_array($result))
{
echo "<option value=\"".$row["ID"]."\">".$row["Title"]."</option>\n";
}
?>
</select>

[Myrkul]

no it still doesnt work.

[Myrkul]

ok i got past that error..but now all i get is a blank dropdown list...

i now have:

<form action="admin.php" method="post" name="editform"> 
Select News To Edit: <select name="edit"> 
<?php 

while ($row = mysql_fetch_array($result)) 
{ 
echo "<option value=\"".$row["ID"]."\">".$row["Title"]."</option>\n"; 
} 
?> 
</select>
			</select>
			<p><input type="submit" name="submit" value="Edit" border="0"></p>
		</form>

[Myrkul]

can i put php there?

[cgraz]

If you're getting a blank result, there was probably nothing returned. ARe you sure your table has values? I'd also suggest using mysql_error() while building your app to debug. Once the site is up and running, you can change it back.

$result = mysql_query ("SELECT * FROM news ORDER BY ID DESC") OR die(mysql_error());

Cgraz

[CaptianChaos]

SELECT * FROM news ORDER BY ID DESC

will produce a valid result and will not be in error, even if there are no results. It will only error if something is wrong with the SQL statement, like 'news' is not a table or 'ID' is not a column in the 'news' table.

You may want to use mysql_num_rows, like this:

<form action="admin.php" method="post" name="editform"> 
Select News To Edit: <select name="edit"> 
<?php 
$numrows = mysql_num_rows($result);
if ($numrows == 0)
  echo "<option value=\"\">error - no data</option>";
while ($row = mysql_fetch_array($result)) 
{ 
echo "<option value=\"".$row["ID"]."\">".$row["Title"]."</option>\n"; 
} 
?> 
</select>
<p><input type="submit" name="submit" value="Edit" border="0"></p>
</form>

[ir4z0r]

not mysql_query returns the error, mysql_fetch_xxx() does, when
the result is empty, your code wouldn't work

[CaptianChaos]

Good point, use this:

<form action="admin.php" method="post" name="editform"> 
Select News To Edit: <select name="edit"> 
<?php 
$numrows = mysql_num_rows($result);
if ($numrows == 0)
  echo "<option value=\"\">error - no data</option>";
else {
  while ($row = mysql_fetch_array($result)) 
  { 
    echo "<option value=\"".$row["ID"]."\">".$row["Title"]."</option>\n"; 
  } 
}
?> 
</select>
<p><input type="submit" name="submit" value="Edit" border="0"></p>
</form>

[Myrkul]

nope i dont get any result, not even no the no data.

There is data in the table.

http://www.swhyperspace.com/edit.php

[CaptianChaos]

Give your source code as it stands now, I'll find the problem. If you get no data now, the problem is that $numrows is not equal to zero, but you cannot loop through the results either... so, hmmm. Need to see your source.

[Myrkul]

well here is ALL of it inclduing the post (which works) the edit and delete (both whjich dont but edit is what i am worried about now)

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<?php 

$db = mysql_connect ("localhost", "user", "pass") or die ('I cannot connect to the database.');
mysql_select_db ("name") or die ("damn"); 
?>
<html>

<head>
	<title>Admin</title>
</head>

<body bgcolor="black" text="white">
	<div align="center">
		<p><a href="#new">new</a> <a href="#delete">delete</a> <a href="#edit">edit</a></p>
	</div>
	<a name="new"></a>
	<form action="admin.php" method="post" name="news">
		Title <input type="text" name="Title" size="24" border="0">
		<p>Body:<br>
			<textarea name="Body" rows="7" cols="33"></textarea></p>
		<p>Time: <input type="text" name="Time" value="<?php echo date("m.d.y, 

g:i a");  ?>" border="0"></p>
			<input type="submit" name="submit" value="Post" border="0">
			<p></p>
		</form>
		<p><a name="delete"></a></p>

<?php
$result = mysql_query ("SELECT * FROM news ORDER BY ID DESC", $db) OR die("shit");

while ($row = mysql_fetch_array($result))
{
 echo "<font size=\"1\">".$row["ID"]." - <b>".$row["Title"]."</b></font>";
 echo "<br>";
}
mysql_close($db);

?>
<form action="admin.php" method="post" name="editform"> 
Select News To Edit: <select name="edit"> 
<?php 
$numrows = mysql_num_rows($result);
if ($numrows == 0)
  echo "<option value=\"\">error - no data</option>";
else {
  while ($row = mysql_fetch_array($result)) 
  { 
    echo "<option value=\"".$row["ID"]."\">".$row["Title"]."</option>\n"; 
  } 
}
?> 
</select>
<p><input type="submit" name="submit" value="Edit" border="0"></p>
</form>

</body>

</html>

[ir4z0r]

the 1st while loop gets all entries from first till last and
stays behind the last
so when the 2nd while loop checks for further entries there are none

do reset the pointer execute this after the 1st loop:

mysql_data_seek($result,0);

[CaptianChaos]

You are oh so close. You are looping through the result set, then trying to loop through it again. You cannot loop through it twice, doesn't work like that. Also, you closed the database connection after the first loop through the results. Try this replacement:

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<?php 

$db = mysql_connect ("localhost", "user", "pass") or die ('I cannot connect to the database.');
mysql_select_db ("name") or die ("damn"); 
?>
<html>

<head>
    <title>Admin</title>
</head>

<body bgcolor="black" text="white">
    <div align="center">
        <p><a href="#new">new</a> <a href="#delete">delete</a> <a href="#edit">edit</a></p>
    </div>
    <a name="new"></a>
    <form action="admin.php" method="post" name="news">
        Title <input type="text" name="Title" size="24" border="0">
        <p>Body:<br>
            <textarea name="Body" rows="7" cols="33"></textarea></p>
        <p>Time: <input type="text" name="Time" value="<?php echo date("m.d.y, 

g:i a");  ?>" border="0"></p>
            <input type="submit" name="submit" value="Post" border="0">
            <p></p>
        </form>
        <p><a name="delete"></a></p>

<?php
$result = mysql_query ("SELECT * FROM news ORDER BY ID DESC", $db) OR die("shit");

$options = "";
while ($row = mysql_fetch_array($result))
{
 echo "<font size=\"1\">".$row["ID"]." - <b>".$row["Title"]."</b></font>";
 echo "<br>";
  $options .= "<option value=\"".$row["ID"]."\">".$row["Title"]."</option>";
}
mysql_close($db);

?>
<form action="admin.php" method="post" name="editform"> 
Select News To Edit: <select name="edit"> 
<?php 
echo $options;
?> 
</select>
<p><input type="submit" name="submit" value="Edit" border="0"></p>
</form>

</body>

</html>

[ir4z0r]

well, mysql_close() is no problem cause the resultset is afaik stored
in memory with a pointer on its beginning ($result)

hence, he has to put the pointer back to the beginning of the resultset (mysql_seek_data())
or store the data in an array like you suggested

[Myrkul]

alright thanks..w00t it shows data!

there is a parse error on the line below the 'elseif ($submit == "Edit")'

<?php 
$connection = mysql_connect ("localhost", "user", "pass") or die ('I cannot connect to the database.');
mysql_select_db ("name") or die ("damn"); 
if ($submit == "Post")
{
 $Body = str_replace(chr(13), "<br>", $Body);
 $strSql = "INSERT INTO news (Title,Body,Time) VALUES ('$Title','$Body','$Time')";
 $status = mysql_query ($strSql,$connection) or die ("Your Mojo is weak master, and it has failed.");
 if ($status != false)
 {
  echo "It... is done. Your Mojo has been added master";
 }
 else
 {
  echo "Your Mojo is weak master, and it has failed.";
 }
}
elseif ($submit == "Delete")
{
 $strSql = "DELETE FROM news WHERE ID = '$ID'";
 mysql_query ($strSql,$connection) or die ("Your DELETING is weak master, and it has failed.");
}
elseif ($submit == "Edit")
{
 $sql = "SELECT Title, Body, Time FROM news WHERE ID = $edit";
 $result = mysql_query($sql,$connection
 //$Body = str_replace(chr(13), '<br>', '$Body')
 //$strSql = "UPDATE news SET Body = '$Body',Title','$Title',Type = '$Type' WHERE ID = $ID";
 //mysql_query ($strSql,$connection) or die ("Your UPDATING Mojo is weak master, and it has failed.");
 echo "<form action=\"admin.php\" method=\"post\" name=\"editform\">";
 echo "Title <input type=\"text\" name=\"TitleUP\" size=\"24\" value=\"".row['Title']."\" border=\"0\">";
 echo "<p>Body:<br>";
 echo "<textarea name=\"BodyUP\" rows=\"7\" cols=\"33\">".row['Body']."</textarea></p>";
 echo "<p>Time: <input type=\"text\" name=\"TimeUP\" value=\"".row['Time']."\" border=\"0\"></p>";
 echo "<input type=\"submit\" name=\"submit\" value=\"Update\" border=\"0\">";
 echo "<p></p>";
 echo "</form>";
}
mysql_close($connection); ?>