PHP and HTML

MaidenEmpire

i got this code to display data from a file. It works fine, displays it on a page in normal black text on white background.

<center>To Post ure specs <a href="index.php?file=specs">click here</a></center><?php 



$filename = "specs.dat"; 
$dilm = ":"; 


if ( file_exists( $filename ) ) { 

   if ( $fp = fopen( $filename, 'r' ) ){ // open for reading 

     while ( ! feof( $fp ) ){ 

          $line = fgets( $fp, 1024 ); 

        if ( strlen( $line ) >= 3 ){ 

           $news = explode( $dilm, $line ); 

           echo date( " g.i:s a", $news[0] );             
           echo "<br />"; 
           echo "$news[1]<br />"; 
           echo "$news[2]<br />"; 
		echo "$news[3]<br />"; 
           echo "$news[4]<br />"; 
		                  echo "$news[5]<br />"; 
           echo "$news[6]<br />"; 
		                  echo "$news[7]<br />"; 
           echo "$news[8]<br />"; 
		                  echo "$news[9]<br />"; 
           echo "$news[10]<br />";                
		   echo "$news[11]<br /><br /><br />";


        } 

  } 

     fclose( $fp ); 

} 
} 
else 
{ 
    echo "Error File Does Not Exist! ($filename)"; 
} 
?>

I want it to be dispayed in a table, so i can edit colours etc to go with my site. i tried this but it dont work:

<html><?php 

$filename = "specs.dat"; 
$dilm = ":"; 


if ( file_exists( $filename ) ) { 

   if ( $fp = fopen( $filename, 'r' ) ){ // open for reading 

     while ( ! feof( $fp ) ){ 

          $line = fgets( $fp, 1024 ); 

        if ( strlen( $line ) >= 3 ){ 

           $news = explode( $dilm, $line ); ?>

<center>
  <p>To Post ure specs <a href="index.php?file=specs">click here</a></p>
  <table width="100%" border="1" cellspacing="0" cellpadding="0">
    <tr>
      <td width="8%">Date:</td>
      <td width="92%"><?php echo date( " g.i:s a", $news[0] ); ?></td>
    </tr>
    <tr>
      <td>Name:</td>
      <td><?php echo "$news[1]<br />"; ?></td>
    </tr>
    <tr>
      <td>CPU:</td>
      <td><?php echo "$news[2]<br />"; ?></td>
    </tr>
    <tr>
      <td>RAM:</td>
      <td><?php echo "$news[3]<br />"; ?></td>
    </tr>
    <tr>
      <td>Motherboard:</td>
      <td><?php echo "$news[4]<br />"; ?></td>
    </tr>
    <tr>
      <td>Graphics:</td>
      <td><?php echo "$news[5]<br />"; ?></td>
    </tr>
    <tr>
      <td>HDD:</td>
      <td><?php echo "$news[6]<br />"; ?></td>
    </tr>
    <tr>
      <td>Disk drive:</td>
      <td><?php echo "$news[7]<br />"; ?></td>
    </tr>
    <tr>
      <td>Cooling:</td>
      <td><?php echo "$news[8]<br />"; ?></td>
    </tr>
    <tr>
      <td>Case:</td>
      <td><?php echo "$news[9]<br />"; ?></td>
    </tr>
  </table></html>

Any ideas on wot i am doing wrong? might be simple, but i cant tell 🙁

CaptianChaos

if ( file_exists( $filename ) ) {     

  if ( $fp = fopen( $filename, 'r' ) ){ // open for reading 
    while ( ! feof( $fp ) ){ 
      $line = fgets( $fp, 1024 ); 
      if ( strlen( $line ) >= 3 ){ 
        $news = explode( $dilm, $line ); ?>

Where are all your closing tags for the 3 if statements and the one while statement? You will get all kinds of syntax errors.

MaidenEmpire

i might have missed them in the 2nd one. The 1st one works, the 2nd one dont 🙁

MaidenEmpire

i seem to get a parse error where ever theres an html tag.

CaptianChaos

Your concept looks fine. You just have to clean up the syntax errors. You have not closed many of your If and While statements in your second one. Post your entire 2nd one source and I'll touch it up for you, if you like.

MaidenEmpire

i am afraid that is the 2nd one. I dint close the tags, because i dont know where to put em. Can u touch it up?

MaidenEmpire

any ideas anyone? still cant do it

CaptianChaos

<html><?php 

$filename = "specs.dat"; 
$dilm = ":"; 

print '<center>
  <p>To Post ure specs <a href="index.php?file=specs">click here</a></p>';

if ( file_exists( $filename ) ) { 

   if ( $fp = fopen( $filename, 'r' ) ){ // open for reading 

     while ( ! feof( $fp ) ){ 

          $line = fgets( $fp, 1024 ); 

        if ( strlen( $line ) >= 3 ){ 

           $news = explode( $dilm, $line ); ?>

  <table width="100%" border="1" cellspacing="0" cellpadding="0">
    <tr>
      <td width="8%">Date:</td>
      <td width="92%"><?php echo date( " g.i:s a", $news[0] ); ?></td>
    </tr>
    <tr>
      <td>Name:</td>
      <td><?php echo "{$news[1]}"; ?></td>
    </tr>
    <tr>
      <td>CPU:</td>
      <td><?php echo "{$news[2]}"; ?></td>
    </tr>
    <tr>
      <td>RAM:</td>
      <td><?php echo "{$news[3]}"; ?></td>
    </tr>
    <tr>
      <td>Motherboard:</td>
      <td><?php echo "{$news[4]}"; ?></td>
    </tr>
    <tr>
      <td>Graphics:</td>
      <td><?php echo "{$news[5]}"; ?></td>
    </tr>
    <tr>
      <td>HDD:</td>
      <td><?php echo "{$news[6]}"; ?></td>
    </tr>
    <tr>
      <td>Disk drive:</td>
      <td><?php echo "{$news[7]}"; ?></td>
    </tr>
    <tr>
      <td>Cooling:</td>
      <td><?php echo "{$news[8]}"; ?></td>
    </tr>
    <tr>
      <td>Case:</td>
      <td><?php echo "{$news[9]}"; ?></td>
    </tr>
  </table>
<?php
      }
    }
  }
}
?>
</center>
</html>