[Resolved] header() and download problems

[RedDragon]

hi in my script users can download all kind of files from a server...
to prevent that textfiles are directly opened i wrote some code.... this works perfectly but

IMAGES ARE CORRUPTED!!!

any way to prevent this

	//now we need to set the headers
	if(substr($info['type'], 0, 11) != 'application') {
		$filecontent = fread(fopen($attachurl, 'r'), filesize($attachurl));


	if(checkbrowser() == 'IE' || checkbrowser() == 'OPERA') {
		$mime_type = 'application/octetstream';
   	} else {
		$mime_type = 'application/octet-stream';
	}

	if(substr($info['type'], 0, 5) == 'image') {
		header('Content-Type: image/unknown');
	}

	if(checkbrowser() == 'IE') {
		header('Content-Disposition: inline; filename="' . $info['filename'] . '.' . $info['ext'] . '"');
		header("Content-Transfer-Encoding: binary");
		header('Expires: 0');
		header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
		header('Pragma: public');
		echo $filecontent;
		exit();
	} else {
		header('Content-Disposition: attachment; filename="' . $info['filename'] . '.' . $info['ext'] . '"');
		header("Content-Transfer-Encoding: binary");
		header('Expires: 0');
		header('Pragma: no-cache');
		echo $filecontent;
		exit();
	}
} else {
	header('Location: ' . $attachurl);
}
}

[RedDragon]

anyone?

[edwardsbc]

Try "sending" the image with [man]readfile[/man] instead of echo'ing the contents and see that makes a difference:

readfile($attachurl);

replaces your:

echo $filecontent;

[CaptianChaos]

You may also try adding a Content-type header to the headers.

---

OOPS, sorry, you are already doing that, I'm a moron, never mind, I don't have any suggestions on this matter.

---

ah, but maybe I do:

header('Content-Type: image/unknown');

This looks bad. If it's a GIF, you want image/gif or jpg:
image/jpeg or PNG, image/png ... unknown may be causing you problems for rendering in the browser.

[RedDragon]

hi thx for your suggestions....
the readfile function is doing the job!!!

here is my solution...
all tested files were not opened on the server!
images and even text files directly appear to download!

	if(checkbrowser() == 'IE' || checkbrowser() == 'OPERA') {
		$mime_type = 'application/octetstream';
   	} else {
		$mime_type = 'application/octet-stream';
	}

header('Content-Type: '.$mime_type);

if(checkbrowser() == 'IE') {
	header('Content-Disposition: inline; filename="' . $info['filename'] . '.' . $info['ext'] . '"');
	header("Content-Transfer-Encoding: binary");
	header('Expires: 0');
	header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
	header('Pragma: public');

} else {
	header('Content-Disposition: attachment; filename="' . $info['filename'] . '.' . $info['ext'] . '"');
	header("Content-Transfer-Encoding: binary");
	header('Expires: 0');
	header('Pragma: no-cache');
}

echo @readfile($attachurl);
exit();