mysql write n read

MaidenEmpire

I am posting reviews from a form:

<center><B>Article/Review Submission</B><BR>
<form method="post">
    Name: 
    <input name="name" type="text" size="30"><BR>
    Email:&nbsp; 
    <input name="email" type="text" size="30"><BR><BR>Article Content:<BR>
	 <textarea name="review" cols="70" rows="5"></textarea><BR>
	 <input name="SUBMIT" type="submit">
	</form></center>

<?php


// Connect to the database server
$dbcnx = @mysql_connect("localhost");
if (!$dbcnx) {
echo( "<P>Unable to connect to the " .
"database server at this time.</P>" );
exit();
}



// Select the database
if (! @mysql_select_db("Articles") ) {
echo( "<P>Unable to locate the Articles " .
"database at this time.</P>" );
exit();
}
?>

<?PHP
if ("SUBMIT" == $submit) {
$query = mysql_query("INSERT INTO Articles(review, LinkDate, email, name) VALUES('$review', '$email','$name',  'CURDATE()')") or die(mysql_error());
};
?>

That seems fine, although i dont know if its writing data as i cannot tell.

I then goto the page to recall the data and nothing appears except title.

<?php


// Connect to the database server
$dbcnx = @mysql_connect("localhost");
if (!$dbcnx) {
echo( "<P>Unable to connect to the " .
"database server at this time.</P>" );
exit();
}



// Select the database
if (! @mysql_select_db("Articles") ) {
echo( "<P>Unable to locate the News " .
"database at this time.</P>" );
exit();
}
?>
<center><B>User Submitted Articles</B><BR><BR>

<?php
// Request the text of the latest News
$result = mysql_query(
"select * from articles order by id desc limit 100");
if (!$result) {
echo("<P>Error performing query: " .
mysql_error() . "</P>");
exit();
}
// Display the articles
while ( $row = mysql_fetch_array($result) ) {
echo "<BR>" . $row["name"] . "<BR>";
echo("<BR>" . $row["email"] . "<BR>");
echo("<BR>" . $row["review"] . "<BR>");
echo("<BR>" . $row["linkdate"] . "<BR>");
}
?>
</center>

any ideas? please tell me where i have gone wrong

goa103

Hi,

You should read the introduction to forms from the PHP Manual, I am sure it will help you.

<form method="post">

You forgot to specify an action script:
<form action="myscript.php" method="post">

if ("SUBMIT" == $submit)

if the form and script are in the same file (.html.php) then you should only connect to your DB if the submit button was pushed. Moreover compare $submit to "SUBMIT" and not "SUBMIT" to $submit, it doesn't make any sense.

Last but not least, since PHP4.1+ global variables don't exist, it means that $submit is not defined. Use $_POST ['submit']. Moreover you named it as "SUBMIT", not "submit", it means that $submit doesn't exist: <input name="SUBMIT" type="submit", standard is: <input type="text/submit" name="myphpvarname">...

Read the introduction to forms from the PHP manual, the Variables section of the manual is important too! It's about $_POST & cie.

MaidenEmpire

am afraid u've losted me now...its late.

Could you edit the changes u suggest into the script above please, if you got time. Then i can see where i went wrong. I didnt know about php4.1 etc, i only started making this site afew days ago.

MaidenEmpire

anyone?

goa103

Hi,

If you're too young to read and understand our post, we can't help you. I told you to first read the PHP manual introduction.

MaidenEmpire

hey no need to be like that p***k.

All i asked is what i have to do to change it. As my link submission to database is nerly identical to that and works. But it only submits 2 fields. I will go find help somewhere else, if you cant help me. I understand the bit above, but that does NOT sovle my problem.

goa103

Hi,

Sorry I didn't mean to be rude. I gave you an explanation and as you didn't seem to understand it, I thought you were young. It happens, some people here are very young. I wouldn't help you if I gave you the whole source code. The solution is to understand the explanations, then to update your own code. If you don't know how to do, read the good introduction and tutorials of the PHP manual. Getting a beginner book to PHP & MySQL is also a good idea.

MaidenEmpire

i have books and i've read php.net

I've made a link submission. works fine. but this one wont and all i have changed is DB, table and fields.

i'll just leave it till weekend and start over