making Fields Compulsory

tegwin15

Hello,
I have written a script for my company that requires users to enter their details for the asset register. My program is all working well, except that if they leave an entry blank and press SUBMIT then it adds blank entries to the database. What I would like is to have the fields maked as compulsory and will not let anyone continue until at least something is entered. I am new to PHP and so would like some help on where to put the code. I have put a copy of the script up here (it is very simple for now, but once it is working correctly I will change the design of the form.. I would like to make ALL the fields compulsory.

Here is the code.

<HTML>
<HEAD>
<TITLE>Asset Register</TITLE>
</HEAD>

<BODY>
<?php
if ( !isset( $POST['submit'] ) )
{
echo <<< EOF
<FORM ACTION="{$SERVER['PHP_SELF']}" METHOD="post">
<H1><CENTER>Asset Register</CENTER></H1>
 
Please fill in all your details as clearly as possible. This will enable us to keep a clear record of what laptop s or equipment you have. If you have more than one laptop or other machine please use a SEPERATE sheet for both.
 
Please do NOT add Printers, Monitors etc. Only LAPTOPS and PC's.
 
Full Name&nbsp          

<align="left"><INPUT TYPE="text" NAME="fullname" size="20">(i.e Joe Bloggs)
 Location             

<INPUT TYPE="text" NAME="location" size="20">

Machine Make 

<align="left"> <INPUT TYPE="text" NAME="machinemake" size="20"> (i.e TOSHIBA) Machine Type  

 <INPUT TYPE="text" NAME="machinetype" size="20"> (i.e 8100) Asset Number 

 <INPUT TYPE="text" NAME="assetnum" size="20"> (Enter 0 if none) Serial Number
 <INPUT TYPE="text" NAME="serialnum" size="20">
 
<input type="submit" name="submit" value="Submit!"> <INPUT TYPE="reset" value ="Reset">
</FORM>

EOF;
}
else
{

$fullname = trim( $POST['fullname'] );
$location = trim( $POST['location'] );
$machinetype = trim( $POST['machinetype'] );
$machinemake = trim( $POST['machinemake'] );
$assetnum = trim( $POST['assetnum'] );
$serialnum = trim( $POST['serialnum'] );

$cnx = mysql_connect("localhost", "root", "" ) or die("connection error" );
mysql_select_db("emeaasset", $cnx) or die("DB error" );

$query = "INSERT into asset VALUES ('$fullname', '$location', '$machinetype', '$machinemake', '$assetnum','$serialnum')";

mysql_query($query) or die("query error" );

echo "THANKYOU .. The information has been sucessfully entered into the database.";

}
?>

</BODY>
</HTML>

Weedpacket

A bit of moving around can help.

First, make an empty error message.

Then, check that $_POST['submit'] is not empty :

if(!empty($_POST['submit']))
{
In here, have all that $fullname=trim(...) etc.

Then, use empty() again to see if any of those variables are - well, empty.

If there are empty variables, you can put together an appropriate error message ("You need to fill in ....")

If the error message is still empty after all the checks have been made, you can go on to database, thank you message, and then exit().

}

If the script is still running at this point, it's because either they haven't submitted a form, or the form was incompletely filled in. Look at the error message to see if it's empty or not to see which is the case.

Hope that sketch helps.

tegwin15

Originally posted by Weedpacket
First, make an empty error message.

Then, check that $_POST['submit'] is not empty :

if(!empty($_POST['submit']))
{
In here, have all that $fullname=trim(...) etc.

Then, use empty() again to see if any of those variables are - well, empty.

If there are empty variables, you can put together an appropriate error message ("You need to fill in ....")

If the error message is still empty after all the checks have been made, you can go on to database, thank you message, and then exit().

}

Ok I am bit confused by this, what do you mean create an empty error message, and then you refer to use empty() again ? Also where do I put the error message to say that it is empty. I dont think I quite understand😕

Weedpacket

I meant
"create an empy error message"
Not the clearest, but I was in a rush.

$error_message="";

"Use empty() to see if oneof those variables is empty"
if(empty($fullname))
{ $error_message .= "'Full Name' is not filled in. ";
}

So after checking the variables, if any of them were empty, $error_message won't be empty anymore. Conversely, if it is empty, then all the fields were filled in. So you can look at $error_message to decide what to do next.

Plus, when you redisplay the form, you'd have something to say to the user to tell them why they're still looking at the form and not a thank you.

tegwin15

Ok I have tried this and I am getting an undefined variable of error_message. I have defined it.


EOF;
}
else
{

if(!empty($_POST['submit'])) 
{ 
$fullname = trim( $_POST['fullname'] );
$location = trim( $_POST['location'] );
$machinetype = trim( $_POST['machinetype'] );
$machinemake = trim( $_POST['machinemake'] );
$assetnum = trim( $_POST['assetnum'] );
$serialnum = trim( $_POST['serialnum'] );


$error_message=""; 
if(!empty ($_POST['fullname']);
{ $_POST ['error_message'] .= "'Full Name' is not filled in. "; 
} 

}


$cnx = mysql_connect("localhost", "root", "" ) or die("connection error" );
...

When I hit submit (with no data) I am getting the following error.

Notice: Undefined variable: error_message in d:\stuff\asset-new.php on line 52
THANKYOU .. The information has been sucessfully entered into the database. What Am I doing wrong

bernouli

open your php.ini
replace error_reporting = E_ALL with error_reporting = E_ALL & ~E_NOTICE

tegwin15

Thanks, but changing that in the PHp>INI file, just surpresses the errror message.but IT STILL does not detect for a blank field being entered, which is actually what I wanted.

tegwin15

Does anyone else know what I can try here

bernouli

try this

if(!empty($_POST['submit'])) 
{ 
$fullname = trim( $_POST['fullname'] );
$location = trim( $_POST['location'] );
$machinetype = trim( $_POST['machinetype'] );
$machinemake = trim( $_POST['machinemake'] );
$assetnum = trim( $_POST['assetnum'] );
$serialnum = trim( $_POST['serialnum'] );

if(!empty ($_POST['fullname']);
{ $error_message .= "Full Name' is not filled in. "; 
} 
.
.
//check all the variables
.
.
.
.
if(!empty($error_message))
mysql_query($query) or die("query error" ); 
else echo $error_message;
}

tegwin15

if(!empty($_POST['submit'])) 
{ 
$fullname = trim( $_POST['fullname'] );
$location = trim( $_POST['location'] );
$machinetype = trim( $_POST['machinetype'] );
$machinemake = trim( $_POST['machinemake'] );
$assetnum = trim( $_POST['assetnum'] );
$serialnum = trim( $_POST['serialnum'] );

if(!empty ($_POST['fullname']);
{ $error_message .= "Full Name' is not filled in. "; 
} 
.
.
//check all the variables
.
.
.
.
if(!empty($error_message))
mysql_query($query) or die("query error" ); 
else echo $error_message;
}

I when I apply the code, I am getting a parse error. I think it may be that there is a ; missing. I have tried to add it to the end of both lines

if(!empty($error_message));
and if(!empty($_POST['submit']))

but it still says: Parse error: parse error, unexpected ';' in D:\defaultWeb1\testasset1.php on line 87

What could be wrong

tegwin15

else
{

if(!empty($_POST['submit'])); 
{ 
$fullname = trim( $_POST['fullname'] );
$location = trim( $_POST['location'] );
$machinetype = trim( $_POST['machinetype'] );
$machinemake = trim( $_POST['machinemake'] );
$assetnum = trim( $_POST['assetnum'] );
$serialnum = trim( $_POST['serialnum'] );



if(!empty ($_POST['fullname']);
{ $error_message .= "Full Name' is not filled in. "; 
} 

if(!empty ($_POST['location']);
{ $error_message .= "Location ' is not filled in. "; 
} 


$cnx = mysql_connect("localhost", "root", "" ) or die("connection error" );
mysql_select_db("emeaasset", $cnx) or die("DB error" );

$query = "INSERT into asset VALUES ('$fullname', '$location', '$machinetype', '$machinemake', '$assetnum','$serialnum')";

if(!empty($error_message));
mysql_query($query) or die("query error" );
else echo $error_message;
}


echo "THANKYOU .. The information has been sucessfully entered into the database.";

}
?>

This is how my code reads now.

bernouli

else
{

if(!empty($_POST['submit']))
{ 
$fullname = trim( $_POST['fullname'] );
$location = trim( $_POST['location'] );
$machinetype = trim( $_POST['machinetype'] );
$machinemake = trim( $_POST['machinemake'] );
$assetnum = trim( $_POST['assetnum'] );
$serialnum = trim( $_POST['serialnum'] );



if(!empty ($_POST['fullname'])) //<----
{ $error_message .= "Full Name' is not filled in. "; 
} 

if(!empty ($_POST['location'])) // <----
{ $error_message .= "Location ' is not filled in. "; 
} 


$cnx = mysql_connect("localhost", "root", "" ) or die("connection error" );
mysql_select_db("emeaasset", $cnx) or die("DB error" );

$query = "INSERT into asset VALUES ('$fullname', '$location', '$machinetype', '$machinemake', '$assetnum','$serialnum')";

if(!empty($error_message));
mysql_query($query) or die("query error" );
else echo $error_message;
}


echo "THANKYOU .. The information has been sucessfully entered into the database.";

}
?>

tegwin15

Thanks again. and apologies for this, I am still new to PHP and get confused sometimes by where to put the ; etc.

I have tried your code as above and I am STILL getting the following PARSE error, I am not really sure what is wrong. I have copied the entire code, incase there is something I have lef out.

Parse error: parse error, unexpected T_ELSE in D:\defaultWeb1\diffasset.php on line 69


<HTML>
<HEAD>
<TITLE>Asset Register</TITLE>
</HEAD>

<BODY>
<?php
if ( !isset( $_POST['submit'] ) )
{
echo <<< EOF
<B><FORM ACTION="{$_SERVER['PHP_SELF']}" METHOD="post">
<H1><CENTER><B><FONT SIZE="10" COLOR="#3366FF">Asset Register</FONT></B></CENTER></H1>
<BR><BR>
<B>Please fill in all your details as clearly as possible. This will enable us to keep a clear record of what laptop s or equipment you have. If you have more than one laptop or other machine please use a SEPERATE sheet for both.</B>
<BR><BR>
Please do NOT add Printers, Monitors etc. Only LAPTOPS and PC's.
<BR><BR>
<p align="left"><span style="background-color: #FFFFFF"><font face="Arial">Full Name&nbsp&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
</font></span><font color="#FFFFFF" face="Arial">
<span style="background-color: #0000FF"><align="left"><INPUT TYPE="text" NAME="fullname" size="20"></span></font><span style="background-color: #FFFFFF"><font face="Arial">(i.e Joe Bloggs)
<BR>Location&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
</font></span><font color="#FFFFFF" face="Arial">
<span style="background-color: #0000FF"><INPUT TYPE="text" NAME="location" size="20"></span></font></p>
<P align="left">
<span style="background-color: #FFFFFF"><font face="Arial">Machine Make&nbsp;
</font></span><font color="#FFFFFF" face="Arial">
<span style="background-color: #0000FF"><align="left"> <INPUT TYPE="text" NAME="machinemake" size="20"></span></font><span style="background-color: #FFFFFF"><font face="Arial"> (i.e TOSHIBA)<BR>Machine Type&nbsp;&nbsp;
</font></span><font color="#FFFFFF" face="Arial">
<span style="background-color: #0000FF"> <INPUT TYPE="text" NAME="machinetype" size="20"></span></font><span style="background-color: #FFFFFF"><font face="Arial"> (i.e 8100)<BR>Asset Number&nbsp;
</font></span><font color="#FFFFFF" face="Arial">
<span style="background-color: #0000FF"> <INPUT TYPE="text" NAME="assetnum" size="20"></span></font><span style="background-color: #FFFFFF"><font face="Arial"> (Enter 0 if none)<BR>Serial Number</font><font face="Tahoma">
</font>&nbsp;</span><font color="#FFFFFF"><span style="background-color: #0000FF"><INPUT TYPE="text" NAME="serialnum" size="20"></span></font><span style="background-color: #FFFFFF">
</span><span style="background-color: #0000FF"> <BR></span><BR>
<input type="submit" name="submit" value="Submit!"> <INPUT TYPE="reset" value ="Reset">
</FORM></B>

EOF;
}
else
{

if(!empty($_POST['submit']))
{ 
$fullname = trim( $_POST['fullname'] );
$location = trim( $_POST['location'] );
$machinetype = trim( $_POST['machinetype'] );
$machinemake = trim( $_POST['machinemake'] );
$assetnum = trim( $_POST['assetnum'] );
$serialnum = trim( $_POST['serialnum'] );



if(!empty ($_POST['fullname'])) //<----
{ $error_message .= "Full Name' is not filled in. "; 
} 

if(!empty ($_POST['location'])) // <----
{ $error_message .= "Location ' is not filled in. "; 
} 


$cnx = mysql_connect("localhost", "root", "" ) or die("connection error" );
mysql_select_db("emeaasset", $cnx) or die("DB error" );

$query = "INSERT into asset VALUES ('$fullname', '$location', '$machinetype', '$machinemake', '$assetnum','$serialnum')";

if(!empty($error_message));
mysql_query($query) or die("query error" );
else
	echo $error_message;
}


echo "THANKYOU .. The information has been sucessfully entered into the database.";

}
?>
</BODY>
</HTML>

bernouli

if(!empty($error_message))

tegwin15

LOL !!! Sorry I am get an undefined variable errormessage ARGHH!!!!!

I tried to change it to

if(!empty($POST['error_message']))
mysql_query($query) or die("query error" );
else
echo $POST['error_message'];
}..

Then I get all sorts of errors.. Damn this is hard.. !!

Notice: Undefined index: error_message in D:\defaultWeb1\diffasset.php on line 71
THANKYOU .. The information has been sucessfully entered into the database.

bernouli

since your $_POST doesnt have any index error_message, you will surely get the error msg.

if(!empty($error_message))

is correct, and don't forget to change your php.ini

tegwin15

Ok I think I may be onto something here..

I have added the following line

$error_message='';
if(!empty($POST['submit']))
{
$fullname = trim( $POST['fullname'] );
$location = trim( $POST['location'] );
$machinetype = trim( $POST['machinetype'] );
$machinemake = trim( $POST['machinemake'] );
$assetnum = trim( $POST['assetnum'] );
$serialnum = trim( $_POST['serialnum'] );

and now when I enter a blank value, it DOES NOT add it to the DB so at least that part is working, but it also does not give an error message, in fact it still says that the information was successful, insted of saying that the informatioon was not entered. What is wrong now!!?

tegwin15

I have changed the php.ini file to

else
{

if(!empty($_POST['submit']))
{ 
$fullname = trim( $_POST['fullname'] );
$location = trim( $_POST['location'] );
$machinetype = trim( $_POST['machinetype'] );
$machinemake = trim( $_POST['machinemake'] );
$assetnum = trim( $_POST['assetnum'] );
$serialnum = trim( $_POST['serialnum'] );



if(!empty ($_POST['fullname'])) //<----
{ $error_message .= "Full Name' is not filled in. "; 
} 

if(!empty ($_POST['location'])) // <----
{ $error_message .= "Location ' is not filled in. "; 
} 


$cnx = mysql_connect("localhost", "root", "" ) or die("connection error" );
mysql_select_db("emeaasset", $cnx) or die("DB error" );

$query = "INSERT into asset VALUES ('$fullname', '$location', '$machinetype', '$machinemake', '$assetnum','$serialnum')";

if(!empty($error_message))
mysql_query($query) or die("query error" );
else echo $error_message;
}


echo "THANKYOU .. The information has been sucessfully entered into the database.";

}
?>

Ok my code is back now the way that it was like you said. However IT STILL DOES Not give an error message saying the field is blank. if I leave the fields blank now it accepts it saying" thanyou the information is successful.. blah" It does not enter a blank value into the DB
So howcomes it is not seeing the messages

tegwin15

Further to this I have changed my php.ini file to read... error_reporting = E_ALL & ~E_NOTICE

bernouli

if(!empty($error_message)) {
mysql_query($query) or die("query error" );
echo "THANKYOU .. The information has been sucessfully entered into the database.";
}
else echo $error_message;
}

}
?>