problem with a variable

Geypens

Hello,

I have a problem I can't solve. I tried several things but I don't know what the problem is.

The code is my login-page. Everything works great, except my own error-messages. If I put a wrong username or password it has to show :
"User name or password not recognised", but it only shows the first letter : U.

Can someone please tell me what I'm doing wrong ?

Thanks

<?php include("../include/intranet_admin.php"); ?>
<?php
function check_login($formdata)
{ $dbhost = "xxx.xxx.xxx.xxx";
  $dbuser = "xxx";
  $dbpassword = "xxx";
  $db = "xxx";

  $form_data = trim_data($formdata);
  $user = $form_data['username'];
  $password = $form_data['password'];

  $mysql = mysql_connect($dbhost, $dbuser, $dbpassword);
  if(!$mysql)
  { $error = "Cannot connect to Database Host";
    return($error);
  }

  $mysqldb = mysql_select_db($db);
  if(!$mysqldb)
  { $error = "Cannot open Database";
    return($error);
  }

  $myquery = "SELECT * FROM login WHERE username = '" . $user;
  $myquery .= "' AND password = '" . crypt($password,"xxx") . "'";



 $result = mysql_query($myquery);
 if (!$result)
  { $error = "Cannot run query";
    return($error);
  }

  $numRows = mysql_num_rows($result);
  if ($numRows < 1)
  { $error = "User name or password not recognised";
    return($error);
  }

  $userRecord = mysql_fetch_array($result);
  return($userRecord);
}
?>
<?php 
if($HTTP_POST_VARS['Submit']=="Login")
{ session_start();
  $row = check_login($HTTP_POST_VARS);
  $statusCheck = $row["status"];
  if ($statusCheck == "Admin" || $statusCheck == "Staff")
  { session_register("statusCheck");
    header("Location: menu.php");
  }
  $companyCheck = $row["company"];
 if($companyCheck == "Acros" || $companyCheck == "Bioblock" || $companyCheck == "Fisher Europe" || $companyCheck == "Fisher France" || $companyCheck == "Fisher NL" || $companyCheck == "Germany" || $companyCheck == "Fisher Scientific UK" || $companyCheck == "Fisher Poland" || $companyCheck == "Fisher Switzerland" || $companyCheck == "Fisher Czech")
  { session_register("companyCheck");
  }
}
?>
<html>
<head>
<title>Fisher Intranet</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<h1 align="center"><font color="#003366" size="3" face="Arial, Helvetica, sans-serif">Login 
  to the Fisher intranet</font></h1>
<h1 align="center"><font color="#003366" size="5" face="Verdana, Arial, Helvetica, sans-serif"><img src="../../images/imagesform/logo.gif" width="259" height="57"></font></h1>
<h2 align="center"><font color="#003366" size="3" face="Arial, Helvetica, sans-serif">Enter 
  your user name and password:</font></h2>
<p align="center"><?php echo $statusCheck; ?></p>
<p> </p><form name="form1" method="post" action="<?php echo($PHP_SELF) ?>">
  <table width="50%" border="0" align="center" cellpadding="5" cellspacing="0" bgcolor="#999966">
    <tr> 
      <td width="29%"><font color="#FFFFFF" size="2" face="Arial, Helvetica, sans-serif"><strong>user 
        name :</strong></font></td>
      <td width="71%"><input name="username" type="text" id="username" maxlength="20"></td>
    </tr>
    <tr> 
      <td><font color="#FFFFFF" size="2" face="Arial, Helvetica, sans-serif"><strong>password 
        :</strong></font></td>
      <td><input name="password" type="password" id="password" maxlength="20"></td>
    </tr>
    <tr> 
      <td colspan="2"><div align="center"> 
          <p> 
            <input type="submit" name="Submit" value="Login">
            <font color="#003366" size="2" face="Arial, Helvetica, sans-serif"><font color="#003366" size="2" face="Arial, Helvetica, sans-serif"></font></font> 
          </p>
        </div></td>
    </tr>
  </table>

</form>
<p align="center"> <font color="#003366" size="2" face="Arial, Helvetica, sans-serif">
<div align="center">&copy; Copyright Fisher Scientific Europe <br>
  <font color="#003366" size="2" face="Arial, Helvetica, sans-serif"></font></div>
</font>
<p align="center"></p>
<div align="center"><font color="#003366" size="2" face="Arial, Helvetica, sans-serif">
  <script language=Javascript1.2>
// verander hieronder de kleur font en grootte van het klokje 
var tags_before_clock = "<font face='Arial, Helvetica, sans-serif' size='1' color='#003366'> "
var tags_middle_clock = ""
if(navigator.appName == "Netscape") {
document.write('<layer id="clock"></layer><br>');
}
if (navigator.appVersion.indexOf("MSIE") != -1){
document.write('<span id="clock"></span>');
}
function upclock(){
var dte = new Date();
var hrs = dte.getHours();
var min = dte.getMinutes();
var sec = dte.getSeconds();
var col = ":";
var spc = " ";
var com = "";
if (hrs == 0) hrs=12;
if (min<=9) min="0"+min;
if (sec<=9) sec="0"+sec;
if(navigator.appName == "Netscape") {
document.clock.document.  write(tags_before_clock+hrs+col+min+col+sec+tags_m

iddle_clock+day+com+spc);
document.clock.document.close();
}
if (navigator.appVersion.indexOf("MSIE") != -1){
clock.innerHTML =   tags_before_clock+hrs+col+min+col+sec+tags_middle_

clock+com+com+spc;
}
}
setInterval("upclock()",200);
</script>
  </font></p> </div>
</body>
</html>

OhLordy

Sorry if I'm being blind but I can't seem to see where you are displaying the error. It seems to be placed in the variable $row as returned from the function but after the first two checks the $row variable isn't used again.
Good Luck
Rob

bernouli

the check_login() returns a string
you call the function (returns a string), and save to $row: $row = check_login($HTTP_POST_VARS);
you save one character from $row in new variable $statusCheck: $statusCheck = $row["status"];
that's why you get 'U'

Geypens

Thanks for your reply.
But I'm a real newbie to PHP, I don't know what I have to change to make it correct. Can you help me please ?

Thanks !!!

bernouli

try this

.
.
<?php 
if($HTTP_POST_VARS['Submit']=="Login")
{ session_start();
  $row = check_login($HTTP_POST_VARS);
  $statusCheck = strlen($row["status"]) == 1 ? $row : $row["status"];
 .
.
?>

Geypens

That's the solution for my problem !!!
It works great, thank you very much !!!

😃