what is wrong with tis validation?

[Hoangsta]

<?PHP }
if (!isset($fname) or !isset($lname) or !isset($company) or !isset($workphone) or !isset($emailaddress) or !isset($subject) or !isset($comments)) {
show_form();
}
else {
if (empty($fname) || empty($lname) || empty($emailaddress) || empty($comments)) {
echo "<h2>Please fill in the required fields.</h2>";
if (empty($fname)) {
echo "First name is empty.<br />";
}
if (empty($lname)) {
echo "Last name is empty.<br />";
}
if (empty($emailaddress)) {
echo "Email is empty.<br />";
}
if (empty($comments)) {
echo "Did you forget to write your message?<br />";
}
if (!ereg("[a-Z]", $fname)) {
echo "You did not enter in a valid first name.<br />";
}
if (!ereg("[a-Z]", $lname)) {
echo "You did not enter in a valid last name.<br />";
}
if (!ereg('^{[-!#$%&'*+\./0-9=?A-Z_`a-z{|}~]+'.}

'@'.

'[-!#$%&'*+\/0-9=?A-Z^{_`a-z{|}~]+.'.}

'[-!#$%&'*+\./0-9=?A-Z^{_`a-z{|}~]+$',} $emailaddress)) {
echo "You did not enter a valid email address<br /><br>";
}

[suntra]

You can't write "or" in an if statement... must be "||"

NOT
if(condition1 or condition2) {

BUT
if(condition1 || condition 2) {

Also, there is a missing "}"...

if (empty($fname) || empty($lname) || empty($emailaddress) || empty($comments)) {
echo "<h2>Please fill in the required fields.</h2>";
====> }

[Weedpacket]

Apart from that extra } right at the top, which I assume is closing an earlier branch, and the absence of a couple of closing } (which are just as likely to be following this code), the only thing I can see wrong with the syntax is that there is an unescaped ' or three in your ereg pattern.

[Hoangsta]

line 277

if (!ereg("[a-Z]", $fname)) {

echo "You did not enter in a valid first name.<br />";

}

line 280

if (!ereg("[a-Z]", $lname)) {

echo "You did not enter in a valid last name.<br />";

}

echo "You did not enter in a valid last name.<br />";

}
if (!ereg('^{[-!#$%&\'*+\./0-9=?A-Z_`a-z{|}~]+'.}

'@'.

'[-!#$%&\'*+\/0-9=?A-Z^{_`a-z{|}~]+.'.}

'[-!#$%&\'*+\./0-9=?A-Z^{_`a-z{|}~]+$',} $emailaddress)) {
echo "You did not enter a valid email address<br /><br>";
}

my error mesage:

Warning: REG_ERANGE in /virtual/home/web/public_html/generalcomment.php on line 277
You did not enter in a valid first name.

Warning: REG_ERANGE in /virtual/home/web/public_html/generalcomment.php on line 280
You did not enter in a valid last name.
You did not enter a valid email address

[Weedpacket]

[a-Z]
Lowercase 'a' to uppercase 'Z'? 'Z' (ASCII 90) comes before lowercase 'a' (ASCII 97).

I'm sure you mean
[a-zA-Z]

As for the others; you've got ' characters inside '-quoted strings without escaping them. If you used &#91;php] tags around your code when you posted it, that error would have just jumped out at you.

if (!ereg('^[-!#$%&'*+\\./0-9=?A-Z^_`a-z{|}~]+'.

'@'.

'[-!#$%&'*+\\/0-9=?A-Z^_`a-z{|}~]+\.'.

'[-!#$%&'*+\\./0-9=?A-Z^_`a-z{|}~]+$', $emailaddress)) {
echo "You did not enter a valid email address<br /><br>";
}

[Hoangsta]

if (!ereg('^[-!#$%&'*+./0-9=?A-Z^_`a-z{|}~]+'.

'@'.

'[-!#$%&'*+\/0-9=?A-Z^_`a-z{|}~]+.'.

'[-!#$%&'*+\./0-9=?A-Z^_`a-z{|}~]+$', $emailaddress)) {
echo "You did not enter a valid email address<br /><br>";
}

I don't know how to escape the " ' "

The [a-zA-Z] works, thanks.

[Weedpacket]

Originally posted by Hoangsta
I don't know how to escape the " ' "

The same way as ever: with a backslash.

[Hoangsta]

if (!ereg("/(@.*@)|(\.\.)|(@\.)|(\.@)|(^\.)/", $emailaddress) || 
	!ereg("/^.+\@[a-zA-Z0-9\-\.]+\.([a-zA-Z]{2,3}|[0-9]{1,3})$/", $emailaddress)) {
	echo "You did not enter a valid email address<br /><br>";
}

my email validation doesn't check for the @? in addition, i can just put a space and it will accept it, what can i do?

[Weedpacket]

Search the forums for the words email validation, perhaps?