help with creating database

sammyj

I am new to PHP and so far enjoying it, trying to learn a lot.

I am trying to test writing some values into a database I have created a simple form that asks for firstname lastname and email address. However for some reason when I run the form, it seems to automatically run the script and enters blank values into my DB also it displays on the form that the information was successful.

What am I doing wrong. ????? can someone help me to correct my code. !!

thanks SJ...

here is the code

<html>
<head>
<title>Insert Data</title>
</head>

<?php

<body>
<center><form action="{$_SERVER['PHP_SELF']}" method="post">
First Name &nbsp;&nbsp;&nbsp;&nbsp;<INPUT TYPE="text" NAME="firstname" size ="40"><br>
Last  Name &nbsp;&nbsp;&nbsp;&nbsp;<input type="text" name="lastname" size ="40"><br>
email address <input type="text" name="email" size="40"><br>
<br>
<INPUT TYPE="submit" name="submit" value="Submit!">
</FORM></center>



 $firstname= trim ( $_POST['firstname'] );
 $lastname = trim ($_POST['lastname']  );
 $email = trim ($_POST['email'] );


 $conn= mysql_connect("localhost", "root", "") or die("connection error");
	mysql_select_db("address", $conn) or die("Could not find database you specified 
$query ="INSERT into details VALUES('$firstname', '$lastname', '$email')";
mysql_query ($query) or die ("There has been a problem with executing the query.");

echo 'Thankyou. The information you submitted, has been added to the database.';


?>
</body>
</html>

OhLordy

<html>
<head>
<title>Insert Data</title>
</head>

<?php

<body>
<center><form action="{$_SERVER['PHP_SELF']}" method="post">
First Name &nbsp;&nbsp;&nbsp;&nbsp;<INPUT TYPE="text" NAME="firstname" size ="40"><br>
Last  Name &nbsp;&nbsp;&nbsp;&nbsp;<input type="text" name="lastname" size ="40"><br>
email address <input type="text" name="email" size="40"><br>
<br>
<INPUT TYPE="submit" name="submit" value="Submit!">
</FORM></center>


if(isset($_POST['submit']) {

 $firstname= trim ( $_POST['firstname'] );
 $lastname = trim ($_POST['lastname']  );
 $email = trim ($_POST['email'] );

if($firstname!="" && $lastname!="" && $email!="") {

 $conn= mysql_connect("localhost", "root", "") or die("connection error");
    mysql_select_db("address", $conn) or die("Could not find database you specified ");
$query ="INSERT into details VALUES('$firstname', '$lastname', '$email')";
$result=mysql_query ($query) or die ("There has been a problem with executing the query.");

if($result)
echo 'Thankyou. The information you submitted, has been added to the database.';

}
}
?>
</body>
</html>

Hope this helps
Rob

sammyj

thanks ROB, I will try that..

Can you explain to me what this means

if($firstname!="" && $lastname!="" && $email!="") {

I am reading it as meaning even if the values have nothing in them they will still be entered'

sammyj

Rob I have just tried this and I am getting a parse error

Parse error: parse error, unexpected '<' in D:\defaultWeb1\Noname1.php on line 8 .. what does that mean

OhLordy

No, it's the oposite != means not equal to so this line reads
if $firstname is not equal to "" and $lastname is not equal to "" and $email is not equal not "" do this.

So if any one of the fields is left blank the rest of the script will not execute.
Hope this helps
Rob

sammyj

Excellent thanks Rob. The code is giving me a parse error on line 8, which in my code is where the <body> starts. Could this be that this is in the wrong place ?

Sammi

Radon3k

<?php

<body>
<center><form action="{$_SERVER['PHP_SELF']}" method="post">
First Name &nbsp;&nbsp;&nbsp;&nbsp;<INPUT TYPE="text" NAME="firstname" size ="40"><br>
Last  Name &nbsp;&nbsp;&nbsp;&nbsp;<input type="text" name="lastname" size ="40"><br>
email address <input type="text" name="email" size="40"><br>
<br>
<INPUT TYPE="submit" name="submit" value="Submit!">
</FORM></center>

You opened the PHP tag. It should read like this:

<body>
<center><form action"<?php echo("$PHP_SELF")?>" method="post">
First Name &nbsp;&nbsp;&nbsp;&nbsp;<INPUT TYPE="text" NAME="firstname" size ="40"><br>
Last  Name &nbsp;&nbsp;&nbsp;&nbsp;<input type="text" name="lastname" size ="40"><br>
email address <input type="text" name="email" size="40"><br>
<br>
<INPUT TYPE="submit" name="submit" value="Submit!">
</FORM></center><?php

Once you open the PHP tag it will try and read that as if it were PHP code, and since it's not it's throwing errors.

sammyj

Ok thanks, I am still getting an error though, even now that it is changed.

Do I need a php tag in the beginning (before the BODY too ?)

<body>
<center><form action="<?php echo("$PHP_SELF")?>" " method="post">
First Name &nbsp;&nbsp;&nbsp;&nbsp;<INPUT TYPE="text" NAME="firstname" size ="40"><br>
Last  Name &nbsp;&nbsp;&nbsp;&nbsp;<input type="text" name="lastname" size ="40"><br>
email address <input type="text" name="email" size="40"><br>
<br>
<INPUT TYPE="submit" name="submit" value="Submit!">
</FORM></center>


<?php

if(isset($_POST['submit']) {

 $firstname= trim ( $_POST['firstname'] );
 $lastname = trim ($_POST['lastname']  );
 $email = trim ($_POST['email'] );

if($firstname!="" && $lastname!="" && $email!="") {

 $conn= mysql_connect("localhost", "root", "") or die("connection error");
    mysql_select_db("address", $conn) or die("Could not find database you specified ");
$query ="INSERT into details VALUES('$firstname', '$lastname', '$email')";
$result=mysql_query ($query) or die ("There has been a problem with executing the query.");

if($result)
echo 'Thankyou. The information you submitted, has been added to the database.';

}
}

?>
</body>
</html>

sammyj

Ok I saw my error in the code above. I had 2 sets of "" just

="<?php echo("$PHP_SELF")?>" "

I removed one. and now it is giving a different parse error. This is

Parse error: parse error, unexpected '{' in D:\defaultWeb1\Noname1.php on line 18

This is my complete code


<html>
<head>
<title>Insert Data</title>
</head>

<body>
<center><form action"<?php echo("$PHP_SELF")?>" method="post">
First Name &nbsp;&nbsp;&nbsp;&nbsp;<INPUT TYPE="text" NAME="firstname" size ="40"><br>
Last  Name &nbsp;&nbsp;&nbsp;&nbsp;<input type="text" name="lastname" size ="40"><br>
email address <input type="text" name="email" size="40"><br>
<br>
<INPUT TYPE="submit" name="submit" value="Submit!">
</FORM></center>


<?php

if(isset($_POST['submit']) {

 $firstname= trim ( $_POST['firstname'] );
 $lastname = trim ($_POST['lastname']  );
 $email = trim ($_POST['email'] );

if($firstname!="" && $lastname!="" && $email!="") {

 $conn= mysql_connect("localhost", "root", "") or die("connection error");
    mysql_select_db("address", $conn) or die("Could not find database you specified ");
$query ="INSERT into details VALUES('$firstname', '$lastname', '$email')";
$result=mysql_query ($query) or die ("There has been a problem with executing the query.");

if($result)
echo 'Thankyou. The information you submitted, has been added to the database.';

}

}
?>
</body>
</html>

On line 18 is this line

if(isset($_POST['submit']) {

I dont know if the { should be there. I tried to remove it and still does not work ;-=(

OhLordy

You need an extra ) so it reads like this
if(isset($_POST['submit'])) {

Good Luck
Rob

sammyj

Excellent.. Thanks all.. that has helped me a lot!!

Sammi