redirecting pages in an "if " statement

l_evans

i dont know why i cant get this to work but ive tried searching everything on google. there is probably a simple answer:

--snip--

NOTE: both of the refreshes tried are commented out but i have tried both approaches. please help!

if($access_num == 1 && $thepw == $password && $theuser == $username)
{

		//header("Location: [url]http://10.[/url]");
		//<meta http-equiv="refresh" content="3;URL=http://10.61.0.46/Protocol/interface.php">
    	//echo '<p><a href="interface.php">Logged in, click here to continue</a></p>';

	}

thanks,

Lee

l_evans

ALSO

if i can get the redirect to work in the if statement i have to use the internal IP for my webserver. I also want it to redirect for people using the external IP. Thanks again

Lee

Sxooter

I prefer to use 302 style headers, like this:

header("location: http:otherserver/otherurl.html");

Note you can't throw one of these if you've printed any output to the page already.

l_evans

it says

Warning: Cannot modify header information - headers already sent by (www.myserver_im_using/login.php) on line 67 <-which is the line of code in the redirection?????

i dont know what i should change

stolzyboy

put

<?
ob_start();
?>

at the top of the page

saidbakr

Check the palce inwhich the meta tag is printed in the HTML resulted page source.
i.e Is it between the <head> and </head> or not.
meta tags must be only in the head section of the HTML document.
🆒

l_evans

didnt work heres my full page code:

NOTE myserver = the ip address to my webserver.

CODE:

<HTML>
<HEAD>
<TITLE>Protocol Login</TITLE>
<meta http-equiv="Content-Type" content="text/html; charset=">
</HEAD>

<form method="post" action="login.php">
<p>
<input type="text" name="username_form">
<font face="Arial, Helvetica, sans-serif"><b>Enter your username</b></font></p>
<p>
<input type="password" name="pw_form">
<font face="Arial, Helvetica, sans-serif"><b>Enter your password</b></font><b><font face="Verdana, Arial, Helvetica, sans-serif">
</font></b></p>
<p> </p>
<p>
<input type="submit" name="Submit" value="Login">
</p>
</form>

<?
if($_POST['Submit'] == 'Login')
{
//CONNECTION TO PROTOCOL DATABASE:
mysql_connect("localhost", "root")

or die("Could not connect:" . mysql_error());
mysql_select_db("prot") or die("connection failed");

$username = $POST['username_form'];
$password = $POST['pw_form'];

$access_numq = mysql_query("SELECT is_admin FROM identity WHERE identity.username = '$username'");
$thepwq = mysql_query("SELECT password FROM identity WHERE identity.username = '$username'");
$theuserq = mysql_query("SELECT username FROM identity WHERE identity.username = '$username'");

$row = mysql_fetch_array($access_numq);
$access_num = $row['is_admin'];

$row2 = mysql_fetch_array($thepwq);
$thepw = $row2['password'];

$row3 = mysql_fetch_array($theuserq);
$theuser = $row3['username'];

	if($access_num == 1 && $thepw == $password  && $theuser == $username)
	{
		//FULL ACCESS
		//header("Location: [url]http://Intranet/Protocol/interface.php[/url]");
		<A HREF="http://intranet/Protocol/interface.php">Protocol Tracking System</A>
    	</a></p>';

	}

	if($access_num == 0  && $thepw == $password && $theuser == $username && $username != '')
	{
		//LIMITED ACCESS
					</a></p>';
	}
    if($thepw != $password || $theuser != $username)
	{
		echo "incorrect username or password";
	}

//CLOSE DATABASE
mysql_close();
}
?>
<p> </p></BODY>
</HTML>

stolzyboy

did you put

<?
ob_start();
?>

before the

<HTML> tag

l_evans

yep! i tried it above <meta.....> and above <HEAD> and inbetween <HEAD> and </HEAD>

Lee

l_evans

the error is :

Warning: Cannot modify header information - headers already sent by (output started at C:\Inetpub\wwwroot\Intranet\Protocol\login.php:2) in C:\Inetpub\wwwroot\Intranet\Protocol\login.php on line 73

Sxooter

Just make sure that you start your page, first line, with

<?php

and don't print anything befor you throw a header("location: http://server.com/file.html");

and you're set.

Note that even a single blank line or space will mess this up.

superwormy

How many times has this questoin been asked before?

AGAIN, YOU CAN'T USE THE HEADER() FUNTION UNLESS YOU HAVE SENT ABSOLUTELY NO OUTPUT YET! IE YOU CAN'T HAVE HTML, WHITESPACE, TABS, OR ANY PRINT() OR ECHO() STATEMENTS BEFORE THE HEADER() FUNCTION.

The only way around this is to use output buffering:
www.php.net/ob_start

Change your code to have the <?php if () { header() } ?> bit be BEFORE any of the HTML.

l_evans

awesome, it worked!!! but now im wondering if this will work from an external IP address. right now im redirecting it with the internal address? anyone know if this could cause a problem?

superwormy

use $_SERVER['HTTP_HOST'] if you want to send them to same url they are already on, or whatever your final URL will be...

Not sure what you mean by internal or external address... you mean local IP addr and WAN address or...?

stolzyboy

wow i told him to do that twice, but when someone else told him to it worked, lol

l_evans

when i type in the address in IExplorer at work I use the Intranet IP which is 10.61...../Protocol/login.php

when i use this site outside of our intranet like at home I have to use the IP 124.138.../Protocol/login.php

-this causes a problem because my redirect looks for the 10.61 address when i type in the site outside of the intranet.

thanks, im a newb!!!

Lee

superwormy

Use $_SERVER['HTTP_HOST']

It'll be whatever you accessed the page with,ie whatever IP address you typed into Internet Explorer.

saidbakr

You may look at this contribution, inwhich I had asked a question seems to be like your case
http://www.phpbuilder.com/board/showthread.php?s=&threadid=10237456

I hope this add something 🙂

Weedpacket

Originally posted by superwormy

The only way around this is to use output buffering:
www.php.net/ob_start

Coddlings. It can also be avoided if you think about what you're doing and not generate any output before you generate headers. What would be the point of sending <html><head><title>.....etc.etc. if you're going to be redirecting the user to another page anyway? It's a waste of server memory, a waste of clock cycles, a waste of the user's time (due to the extra buffering), and an indictment on the ability of the programmer.

superwormy

I agree Weedpacket, it's a shame sometimes that people don't just be more careful and organized about how they code. ob_start() is a cheap and needless hack most of the time.