What have I missed?

Kwitcherbitchen

I'm writing a very simple script for a guestbook, pretty much just playing and experminenting with mysql/php.

The guestbook displays the info from the db fine, but to update it I have the following:

gbooksign.php

<form action="gbooksignok.php" method="post">
<input type="text" name="name" size="50" value="name"><br>
<input type="text" name="email" size="50" value="email"><br>
<input type="text" name="site" size="50" value="website"><br>
<textarea name="comments" cols="50" rows="4">comments?</textarea><br><br>
<input type="submit" name="submit" value="[ take me away ]">
</form>

gbooksignok.php

<?php
include("dbconnect.php");
?>

<?php


   # check to ensure name and comments have been filled in
   if( $name == name or $comments == comments )
      {
         $msg = "<b>You have not completed all the fields required...</b><br>";
         $msg.= "<a href=\"gbooksign.php\">Go back...</a>";
      }
   else
      {
         $sql = "insert into gbook (name,email,site,comments) values (\"$name\",\"$email\",\"$site\",\"$comments\")";
         $rs  = @mysql_query($sql)
                or die("Could not execute query");
      }

   if($rs)
      {
         $msg = "Thank you for signing the guestbook, your comment was added.<br>";
         $msg.= "<a href=\"gbook.php\">Return to guestbook</a>";
      }

echo ($msg);
?>

As it stands, the script updates the db but with blank info. Equally the check to make sure name and comments have been filled out doesn't do squat. This all tells me that the variables haven't gotten through to the gbooksignok.php script 🙂

Now I know I'm most likely going to be using $_POST, I figured that much out, but how exactly? I've tried defining $name, $email, $site and $comments immediately before running the name/comments check as follows:

<?php

  $name = $_POST["name"]
  $email = $_POST["email"]
  $site = $_POST["site"]
  $comments = $_POST["comments"]

   # check to ensure name and comments have been filled in
   if( $name == name or $comments == comments )
      {
         $msg = "<b>You have not completed all the fields required...</b><br>";
         $msg.= "<a href=\"gbooksign.php\">Go back...</a>";
      }


(etc......)

But that threw up an error... as did going through and replacing every instance of $name, $email, $comments and $site with the $_POST["whatever"] alternative....

I have to admit I'm somewhat stumped, and reading a number of tutorials and Manual pages hasen't really helped.

OhLordy

What error did it throw up?
Your lines $vaviable=$_POST['variable'] have no semicolons at the end
Rob

superwormy

A few things, first off, ust $_POST:
<input type="text" name="comments" />

Will POST it's values to:
$_POST['comments']

Second, this line:
$name == name or $comments == comments

WTH is that supposed to be doing? That's not even valid is it? You should do this:

// Check to see if $name or $comments is a blank string
if ($POST['name'] == '' or $POST['comments'] == '') {

Third, change your query line so you can see errors, ie REMOVE THE @ symbol, and use mysql_error() ( www.php.net/mysql_error ):
$rs = mysql_query($sql) or die (mysql_error());

stolzyboy

will probably help if you make this line

$sql = "insert into gbook (name,email,site,comments) values (\"$name\",\"$email\",\"$site\",\"$comments\")";

to this, forget about all that slash crap and use ticks

$sql = "insert into gbook (name, email, site, comments) values ('$name, '$email', '$site', '$comments')";

Kwitcherbitchen

Originally posted by stolzyboy
will probably help if you make this line

$sql = "insert into gbook (name,email,site,comments) values (\"$name\",\"$email\",\"$site\",\"$comments\")";

to this, forget about all that slash crap and use ticks

$sql = "insert into gbook (name, email, site, comments) values ('$name', '$email', '$site', '$comments')";

Hmm, thats a useful hint, thanks for that!

superwormy, I already got that $_POST part now but thanks anyway 🙂

Also,

$name == name or $comments == comments

IS valid (albeit with the name and comments inside speach marks) because the form submits the data of 'name' and 'comments' by default, it does not submit blank data by default.

I figured it all out in the end though, all that was needed was to move a }.

The fixed code:

<?php

   $name      =  $_POST["name"];
   $email     =  $_POST["email"];
   $site      =  $_POST["site"];
   $comments  =  $_POST["comments"];

   if( $name == "name" or $comments == "comments?" )

  {
     $msg = "You have not completed all the fields...<br>";
     $msg.= "<a href=\"gbooksign.php\">Return to guestbook.</a>";
  }

   else

  {
        $sql = "insert into gbook (name,email,site,comments) values (\"$name\",\"$email\",\"$site\",\"$comments\")";
        $rs  = @mysql_query($sql)
               or die("Could not execute query");

     if($rs)
        {
           $msg = "Thank you for signing the guestbook, your comment was added.<br>";
           $msg.= "<a href=\"gbook.php\">Return to guestbook.</a>";
        }

  }

echo ($msg);
?>

Thanks for the help guys 🙂