querystrings

[zumone]

Hi, im making a website in php, using querystrings. The guestbook is at index.php?id=guestbook, and i want the admin page on index.php?id=guestbook&action=admin. Is that possible? Here is some of my code:

<?

server = " ";
$db = " ";
$user = " ";
$pass = " ";

if ($id == "guestbook") {
	echo "<form action=\"index.php?id=guestbook\" method=post>\n";
	echo "<table width=100% height=190 border=0 cellspacing=0 cellpadding=0>\n";
	echo "<tr>\n<td height=23 align=left valign=middle>Name:</td><td align=left valign=middle><input type=text name=name size=25></td>\n</tr>\n";
	echo "<tr>\n<td height=23 align=left valign=middle>Email:</td><td align=left valign=middle><input type=text name=email size=25></td>\n</tr>\n";
	echo "<tr>\n<td height=23 align=left valign=middle>Homepage:</td><td align=left valign=middle><input type=text name=url  size=25 value=http://></td>\n</tr>\n";
	echo "<tr>\n<td height=23 align=left valign=middle>Message:</td><td align=left valign=middle><textarea name=msg rows=5 cols=60></textarea></td>\n</tr>\n";
	echo "<tr>\n<td height=23></td>\n<td align=left valign=middle><input type=submit value=Submit></td>\n</tr>\n<tr>\n<td></td>\n</tr>\n</table>\n</form>\n";
	if (isset($name)) {
		$link = mysql_connect("$server","$user","$pass");
		mysql_select_db("$db");
		$pdate = date("d.m.Y h:iA");
		$sequel = "insert into gbook(name,email,url,pdate,msg) values ('$name','$email','$url','$pdate','$msg')";
		mysql_db_query("$db","$sequel");
		mysql_close($link);
	}
	$dblink = mysql_connect("$server","$user","$pass");
	mysql_select_db("$db");
	$sql = "select * from gbook ORDER BY MSGID DESC";
	$result = mysql_db_query("$db","$sql");
	while($row = mysql_fetch_array($result)) {
	?><b>Name: </b><a href="mailto:<?=$row['email']?>"><?=$row['name']?></a><br>
	<b>Homepage: </b><a href="<?=$row['url']?>" target=_blank><?=$row['url']?></a><br>
	<b>Posted: </b><?=$row['pdate']?><br>
	<b>Message: </b><?=$row['msg']?><p><?
	}
	mysql_close($dblink);
}
elseif ($id == "guestbook" && $action == "admin") {
	if ($gbpass == " ") {
		$dellink = mysql_connect("$server","$user","$pass");
		mysql_select_db("$db");
		$query = "DELETE FROM gbook WHERE msgid = '$msgid'";
		mysql_db_query("$db","$query");
		mysql_close($dellink);
		$data = mysql_connect("$server","$user","$pass");
		mysql_select_db("$db");
		$sql = "select * from gbook ORDER BY msgid DESC";
		$result = mysql_db_query("$db","$sql");
		while($row = mysql_fetch_array($result)) {
			?><b>ID: </b><a href="index.php?id=guestbook&action=admin&msgid=<?=$row['msgid']?>&gbpass=<?=$gbpass?>"><?=$row['msgid']?></a><br>
			<b>Message: </b><?=$row['msg']?><p><?
		}
		mysql_close($data);
	}
	else {
		echo "<form action=\"index.php?id=guestbook&action=admin\" method=post>\n";
		echo "<table width=200 border=0 cellspacing=0 cellpadding=0>\n";
		echo "<tr>\n<td height=23 align=left valign=middle>Password: </td><td align=left valign=middle><input type=password name=gbpass></td>\n</tr>\n";
		echo "<tr>\n<td height=23></td>\n<td align=left valign=middle><input type=submit value=Enter></td>\n</tr>\n</table>\n</form></td>\n";
	}
}
}

?>

If i use elseif ($id == "guestbook" && $action == "admin") $id gets printed first, then $admin, and i just want $admin to be printed.

[douceur]

Probably the simplest way would be to do something like this:

if ($id == 'guestbook') {
  if ($action == 'admin') {
    //code
  }
  else {
    //code
  }
}
else {
  //code
}

[zumone]

doesnt work..

if ($a == "b") {
	echo "a = b";
	if ($c == "d") {
		echo "a = b, c = d";
	}
}

index.php?a=b : output is "a = b"
index.php?a=b&c=d : output is "a = ba = b, c = d"
on index.php?a=b&c=d i only want "a = b, c = d"

[douceur]

Eh....... Believe it or not, that's not what I said to do. Look at my code, and I had some else statements........ Anyway, this should work:

if ($a == 'b') {
  $print = 'a = b';
  if ($c == 'd') {
    $print .= ', c = d';
  }
  print $print
}

In the first block of code you had, both conditions needed id to equal guestbook. So why not put it all in that if statement? Basically, what it said was:

if ($a == 'b') {
  if ($c == 'd') {
    print 'a = b, c = d';
  }
  else {
    print 'a = b';
  }
}

[zumone]

thanx, works..

[douceur]

No problem, anytime.