SET query

[ceanth]

hi all i have this query:

$query = "UPDATE customer SET ".
"cust_fname = \"" . $formVars["firstname"] . "\", " .
"cust_sname = \"" . $formVars["surname"] . "\", " .
"cust_address = \"" . $formVars["address"] . "\", " .
"cust_postcode = \"" . $formVars["postcode"] . "\", " .
"cust_tel = \"" . $formVars["telephone"] . "\", " .
"cust_email = \"" . $formVars["email"] . "\", " .
"cust_cc = \"" . $formVars["card"] .
" WHERE cust_no = $cust_no";

ok now cust_fname are the fields in the database
and $formVars["firstname"] are the values on the form, im running this to try to update the database but it isnt updating. The script is not showing any error but do i need to use:

mysql_query

If do how do u add it into the above code? I get no errors but it doesnt update 🙁

[laserlight]

err yeah, like

mysql_query($query);

[ceanth]

umm i tryed that and still no luck, what is the best way of setting values in the database?

[laserlight]

One way would be:

$query = "UPDATE customer SET
	cust_fname = '" . $formVars["firstname"] . "',
	cust_sname = '" . $formVars["surname"] . "',
	cust_address = '" . $formVars["address"] . "',
	cust_postcode = '" . $formVars["postcode"] . "',
	cust_tel = '" . $formVars["telephone"] . "',
	cust_email = '" . $formVars["email"] . "',
	cust_cc = '" . $formVars["card"] . "'
	WHERE cust_no = '" . $cust_no . "'";
mysql_query($query) OR die(mysql_error());

[ceanth]

interesting, the code you gave does indeed update the customer table, but instead of adding the values u input it puts everything blank 🙁

[laserlight]

that implies a problem with $formVars[]

cant help you there, not enough info

[ceanth]

ok let me try to explain what im doing:

page1. search for customer
page2. display results

ok no problems there, just simple select * from customer and put into table

page3. display customer details in text box for editing

ive used this:

$row = mysql_fetch_array($result);
$formVars = array();

$formVars["firstname"] = $row["cust_fname"];
$formVars["surname"] = $row["cust_sname"];
$formVars["address"] = $row["cust_address"];
$formVars["postcode"] = $row["cust_postcode"];
$formVars["telephone"] = $row["cust_tel"];
$formVars["email"] = $row["cust_email"];
$formVars["card"] = $row["cust_cc"];

so formVars["firstname"] is equal to the fname (which is in mysql databse)

This page displays the information on the screen from the database so i know that formvars are showing information as they are displayed like:

<input type="text" name="firstname"
value="<? echo $formVars["firstname"]; ?>" size=50></td>

page4. take the edited values and store in database

you have guessed correctly, formVars are not being passed : echo $formVars["firstname"]; does not display anything

its here: http://www.lgu.ac.uk/~cghe11/finalsite/customersearch.html

search for "test"

[mattr]

Use $_POST[] superglobal.

Use single quotes and addslashes:

$query = "UPDATE customer SET
                 cust_fname    = '" . addslashes( $_POST[ "firstname" ] ) . "',
                 cust_sname    = '" . addslashes( $_POST[ "surname"   ] ) . "',
                 cust_address  = '" . addslashes( $_POST[ "address"   ] ) . "',
                 cust_postcode = '" . addslashes( $_POST[ "postcode"  ] ) . "',
                 cust_tel      = '" . addslashes( $_POST[ "telephone" ] ) . "',
                 cust_email    = '" . addslashes( $_POST[ "email"     ] ) . "',
                 cust_cc       = '" . addslashes( $_POST[ "card"      ] ) . "'
           WHERE cust_no = '" . addslashes( $cust_no ) . "'";

[ceanth]

ok the problem i am having is that on the page which contains:

$formVars = array();
$formVars["firstname"] = $row["cust_fname"];

this page shows echo $formVars["firstname"]

but the page after that (which will show the updated value) doesnt show anything if i add

echo $formVars["firstname"];

[ceanth]

im looking in a book, would i need the following code:

$custID = clean($custID, 5);
foreach($HTTP_POST_VARS as $varname => $value)
$formVars[$varname] = trim(clean($value, 50));

what does that code do?