Search condition

[furious5]

I am trying to search a table for a job description and create an error message if there are no entries for a particular job title.

The code I have written is almost there but I think I have put the condition in the wrong place as when I try and execute the code it brings back no results even though I know there is 1 entry.

Here is the code, any help would be greatly appreciated:

<?php
//Get variables from search.php
$title = $HTTP_POST_VARS['title'];
$location = $HTTP_POST_VARS['location'];
$date = $HTTP_POST_VARS['date'];

//Load Database Connection & DB details
include("config.php");

//SQL query
$sql = "SELECT jobid, date, description, location, salary FROM job where description = \"$title\"";

//Execute SQL and exit if failure
if ($sql_result <= 0) {
print "Sorry no results matched your search criteria, please go back and refine your <a href=search.php>search</a>";
} else {

$sql_result = mysql_query($sql, $connection) or die ("Sorry the query could not be executed");
while ($row = mysql_fetch_array($sql_result)){
$jobid = $row["jobid"];
$date= $row["date"];
$desc = $row["description"];
$location = $row["location"];
$skills = $row["skills"];
$salary = $row["salary"];

print "<table><tr><td>Job ID: $jobid</td></tr>";
print "<tr><td>Date: $date</td></tr>";
print "<tr><td>Description: $desc</td></tr>";
print "<tr><td>Location: $location</td></tr>";
print "<tr><td>Salary: £$salary</td></tr></table>";
}
print "For more details, please click <a href=result_details.php?jobid=$jobid>here</a>";
}
?>

[ahundiak]

1. Your $sql_result test is being done before your mysql_query call. So it will always fail.

2. If the query is valid, mysql_query will always return a valid result set even if there are no records. In other words, a set with no records is perfectly ok.

3. So to test if the query actually returned any rows do something like this:

   $sql_result = mysql_query($sql) or die('SQL Error ' . mysql_error());
   $num_rows = mysql_num_rows($sql_result);
   if ($num_rows == 0)
   {
     echo 'No Rows';
   }
   

4. You might also want to use single quotes around $title instead of double quotes.

[furious5]

Thanks for that.

I have amended the code however I am still struggling to get the full code to work once I try and use a while statement.

Here is the code, if anyone can help me that would be a great help. I have slowly let my PHP skills slip and I can't code for toffee at the moment - who said ASP was a superior language (grr).

<?php
//Get variables from search.php
$title = $HTTP_POST_VARS['title'];
$location = $HTTP_POST_VARS['location'];
$date = $HTTP_POST_VARS['date'];

//Load Database Connection & DB details
include("config.php");

//SQL query
$sql = "SELECT jobid, date, description, location, salary FROM job where description = '$title'";

//Execute SQL and exit if failure
$sql_result = mysql_query($sql) or die('Sorry the query could not be executed');
$num_rows = mysql_num_rows($sql_result);
if ($num_rows == 0)
{
echo 'Sorry you search did not return any results';
exit;
}

while ($row = mysql_fetch_array($sql_result)){
$jobid = $row["jobid"];
$date= $row["date"];
$desc = $row["description"];
$location = $row["location"];
$salary = $row["salary"];

echo '<table><tr><td>Job ID: $jobid</td></tr>';
echo '<tr><td>Date: $date</td></tr>';
echo '<tr><td>Description: $desc</td></tr>';
echo '<tr><td>Location: $location</td></tr>';
echo '<tr><td>Salary: £$salary</td></tr></table>';
echo 'For more details, please click <a href=result_details.php?jobid=$jobid>here</a>';
?>

I am getting the following error:

Parse error: parse error, unexpected $end in d:\web\result.php on line 37

[kevinsequeira]

you have not closed the while loop

change the last line
?>

to
}
?>

reg
kevin

[furious5]

Ah of course - thank you very much for taking the time to answer my query.