Some display, some don't. Why?

Radon3k

I have a small script that I wrote in which you can make a post. All the code is below, but the actual message doesn't display and I can't figure out why. Another set of eyes might help out.

<?php

require('db.php');

function displayThreads() {
	$threads = mysql_query("SELECT * FROM topics");
	if(!$threads) {
		echo("Cannot retrieve topics.");
	}

echo("Topics:<br><br>");

while($threadsrow = mysql_fetch_array($threads)) {
	$id = $threadsrow['ID'];
	$threadtitle = $threadsrow['threadtitle'];
	$threadauthor = $threadsrow['threadauthor'];
	$threaddate = $threadsrow['threaddate'];

	echo("<a href=\"$_SERVER[PHP_SELF]?thread=$threadid\">$threadtitle</a><br>");
	echo("<b>Posted by:</b> $threadauthor<br>");
	echo("<b>On:</b> $threaddate<br><br>");
}
}

function displayThread($thread) {
	$disptopics = mysql_query("SELECT * FROM topics WHERE ID = $thread");
	$dispthread = mysql_query("SELECT * FROM posts");
	if($post = mysql_fetch_array($disptopics,$dispthread)) {
		$threadid = $post['ID'];
		$postid = $post['threadid'];
		$threadtitle = $post['threadtitle'];
		$threadauthor = $post['threadauthor'];
		$threadmessage = $post['threadmessage'];
		$threaddate = $post['date'];
		$postid = $post['IDpost'];

	echo("$threadtitle<br>");
	echo("<b>Posted by:</b> $threadauthor<br>");
	echo("<b>On:</b> $threaddate<br><br>");
	echo("--------------------------------------------------------------------------------------------------------<br>");
	echo("$threadmessage");
	echo("--------------------------------------------------------------------------------------------------------<br><br>");
	echo("<a href='index.php'>Home</a><br>");
}
}
?>

<html>
<head>
<title></title>
</head>
<body>
<form method="post" action="<?php echo("$PHP_SELF")?>">
Thread title: <input type="text" name="threadtitle"><br>
Author: <input type="text" name="threadauthor"><br>
Message: <textarea name="threadmessage" rows=6 cols=40></textarea><br>
<input type="submit" name="submit" value="Submit">

<?php

if($_POST['submit'] == "Submit") {
	$topics = mysql_query("INSERT INTO topics SET
				threadtitle = '$threadtitle',
				threadauthor = '$threadauthor',
				threaddate = NOW()");

$posts = mysql_query("INSERT INTO posts SET
			threadtitle = '$threadtitle',
			threadauthor = '$threadauthor',
			threaddate = NOW()");

			if(!$topics OR !$posts) {
				echo("Error.");
			} else {
				echo("Topic added.");
			}
}

if($_GET['thread']) {
	displayThread($_GET['thread']);
} else {
	displayThreads();
}
?>

Thanks. 🙂

Radon3k

Anyone?

cahva

Okay, first of all, you have a little error in function_displayThreads().

You set $id=$threadsrow['ID'] and later in echo you have:
echo("<a_href=\"$_SERVER[PHP_SELF]?thread=$threadid\">$threadtitle</a><br>");
So either rename $id to $threadid or rename $threadid to $id so they are both the same 😉

Your INSERT querys are wrong. Dont use SET, thats for UPDATE.

$topics=mysql_query("INSERT INTO topics (threadtitle,threadauthor,threaddate) VALUES ('$threadtitle','$threadauthor',NOW())");

PS. There might be some more errors in your queries. You might consider to join those tables in your SELECT.