expressions help

Rayn

so I am not to sure how to go about this, I am working on some code that will take something like this

this so funny !getjoke:123 hahahah!

and turn the !getjoke:123 into the joke.. I have the code for that but I am ussure how to get the ID part of it (the 123) since that id itself will be different for each joke.

!getjoke:5
!getjoke:98
ect..

Also it will be put into text messages like what is done with posting in this forum.. so yeah

Thanks for your help
- Rayn

Pig

How are you receiving the information? There is probably a better way to go about this that is more reliable.

Rayn

No this is the best way to do I. And I figured it out.

$exploded = explode("!getjoke:","this so funny !getjoke:123 hahahah! ");
$exploded2 = explode(" ",$exploded[1]);

print($exploded2[0]); // output 123

diego25

But what if there are more than one !getjoke codes? I don't think your code works in that case. I'd suggest you use preg_match_all instead.

Diego

Daggeth

Ya, it wont account for ALL of that.. so you will have to use a loop..

<?php
   $string = explode(" ", $string);
   for ($i = 0; $i < count($string); $i++)
      {
      if (eregi('!getjoke', $string[$i]))
         {
         $id = explode('!getjoke', $string[$i]);
         echo $id[1];   // Output the ID!
         $string[$i] = '<img src=smiley.jpg>';
         }
      }
?>

Shot in the dark, while drunk.

Weedpacket

So say you've got a buncha jokes in an array $jokes, indexed by their numeric id numbers.

$string = preg_replace(
          "/!getjoke:(\d+)/e",
          "isset(\$jokes[$1])?\$jokes[$1]:''",
          $string);

#!#$@+( syntax highlighting bugs
replaces the !getjoke:nnn bits in a string with their corresponding jokes, taking into account the possibility that a joke ID is given that doesn't have a corresponding entry in the array by replacing such with empty strings.

If you really do want the IDs for something else as well (keeping statistics of joke usage?), the regexp would be the same, and use preg_match_all(), as diego25 suggests.

Rayn

I get a very odd error when I try this code,

   $message = "I like the new forums..


This is a test

!joke:1

hmmmm";
   $t1 = explode("!joke:",$message);
   $t2 = explode(" ",$t1[1]);

print($t2[0]); // Out puts 1 hmmmm

Now that is very odd since it seems there is a space between the 1 and the hmmmm

I did a print_r and got this output

T1:Array ( [0] => I like the new forums.. This is a test [1] => 1 hmmmm )
T2:Array ( [0] => 1 hmmmm )

Thanks all for your help, I tryed using the one Daggeth posted but it gave me the same problem.. and returned 1 hmmmmm

Weedpacket : It comes from a file and is stored like this:
"1,So there was a guy and he..@BREAK@2,one day I guy was@BREAK" etc

I have the code to get it from the file, but getting the ID to match it is the only problem right now.

Thanks again.
- Rayn

Rayn

Weedpacket

Originally posted by Rayn
Weedpacket : It comes from a file and is stored like this:
"1,So there was a guy and he..@BREAK@2,one day I guy was@BREAK" etc

Well, that's easily enough turned into an array of the type I described...

$jokes = explode('@BREAK@',$filestring);
$joketemp = array();
foreach($jokes as $joke)
{	if(preg_match('/(\d+),(.*)/',$joke,$matches))
		$joketemp[$matches[1]]=$matches[2];
}
$jokes = $joketemp;
print_r($jokes);

Only trying to help... one of the principles of software engineering is "smart data and dumb code is better than dumb data and smart code". Get your data into the right format and much of the work becomes trivial.