Problem with counter

FoxhoundX

I made a quick counter that increases on a click of a button (with the help of some people 😛) and the problem is that It will go up to 9, then back to 1, over and over. Why is this? Lmao 😛
heres the code:

Counter:

<p>The Button Has been clicked <?php
$counterfile = './counter.txt';
$fcontents = file($counterfile);
$counter = $fcontents[0];
print $counter
?> Times!</p>

<FORM ACTION=http://68.145.29.99/button.php>
      <input type="submit" value="Click The Button!" name="Submit" style="border: 3px groove #FF0000">
      </FORM>

Increasing Script:

<?php
$counterfile = './counter.txt';
$fcontents = file($counterfile);
$counter = $fcontents[0];
$counter++;
$fp = fopen($counterfile,'w');
fwrite($fp,$counter,sizeof($counter));
fclose($fp);
?>
<HTML>
<HEAD>
<script language="javascript"><!-- 
location.href="http://68.145.29.99/main.php" 
//--> 
</script> 
</head></HTML>

Mordecai

I think the problem is that you're using file(). You should probably use fopen() and fread():

if (file_exists("counter.txt")) { // Check if file exists
  $cfile = fopen("counter.txt","r");  // Open the file to read
  $count = fread ($cfile, filesize("counter.txt"));  // Get the number
  fclose($cfile);  // Close the file
} else { // If file doesn't exist
  $count = 0; // Set $count to zero (no one's been here before)
}

Also, you could use header() to redirect in your increasing script, rather than JavaScript:
header("Location: [url]http://[/url]".$SERVER['HTTP_HOST'].dirname($SERVER['PHP_SELF'])."/main.php");

header() is infinately better than JavaScript, but you can't output anything before it.

Hope this helps.

FoxhoundX

so where should I put that? And how does it increase via that?

FoxhoundX

I added that before the first script in main.php, and it still resets to 0 =s

jimson

your problem in your code is the fwrite function.

fwrite($fp,$counter,sizeof($counter));

in your code, the sizeof( $counter ) will always be 1 because there is only one line in your counter.txt

sizeof -- Alias of count()

because there is only one line in your counter.txt file, so only one item will be available when you use the file function to read. file will read the file into array...

so, your fwrite function will only put 1 byte of data into that counter.txt.

so it is okay for the number to loop from 0 to 9, but when it comes to 10, the fwrite will only write 1 to the file, missing the 0 because you only allowed 1 byte of length to be wrote.

so, the solution is,

fwrite( $fp, $counter );

so the fwrite will write all the bytes in the $counter to the file.

read the manual... read it and read it again ....