Not execute the code before fields are complete

Chrysanthus

This is my quest..

A user register

With the following

fistname
lasnname

And so on

when he create this new user i don’t want to execute this cod if his not been inserted in to the new entry in the table only if the has been registerd!

<?php

$get_timestamp = mysql_query("select UNIX_TIMESTAMP(regdate) as regdate from table_members ORDER BY regdate desc limit 1");
while ($row = mysql_fetch_array($get_timestamp)) {
$reg = $row['regdate'];
echo '<font size="1" face="verdana">You registerd at: ' . date('Y-m-d', $reg) .'<br>' . 'Swedish time: ' . date('H:i', $reg) . '</FONT><br>';
}

Is it IF cod i should work with?

scoppc

well, I am not really sure what you wanna do but from your subject, I supposse you wanna check for required fields before your script inserts user data.

You can do the following:

//get the input from user
$firstname=addslashes(strip_tags($_POST['fname']));
$lastname=addslashes(strip_tags($_POST['lname']));
//check for required fields
if (empty($firstname) OR empty($lastname)){
print "sorry, you should complete the form";
}else{
//the rest of the code here

}

of course, you can check as many fields as you want.
Server-side checking to user input is better than client-side, tho.

Chrysanthus

thats correct

i wanna check fiels before the get inserted

Is this in php or html

//get the input from user
$firstname=addslashes(strip_tags($POST['firstname']));
$lastname=addslashes(strip_tags($POST['lastnname']));
//check for required fields
if (empty($firstname) OR empty($lastname)){
print "sorry, you should complete the form";
}else{
//the rest of the code here

}

Here is the form file and how should i retyp the syntax for it to work with youre code?

</head>

<br>

<font size="1" face="verdana, geneva, arial"> Firstname:<br>
<input type="text" name="firstname" size="15" class="f"><br>

<font size="1" face="verdana, geneva, arial"> Lastname:<br>
<input type="text" name="lastname" size="15" class="f"><br>

<font size="1" face="verdana, geneva, arial"> Gender:<br>
<input type="text" name="gender" size="15" class="f"><br>

<font size="1" face="verdana, geneva, arial"> Birth:<br>
<input type="text" name="birthdate" size="15" class="f"><br><br><br>

<font size="1" face="verdana, geneva, arial"> Username:<br>
<input type="text" name="nickname" size="15" class="f"> (A minimum of 4 numbers or letters)<br>

<font size="1" face="verdana, geneva, arial"> Password:<br>
<input type="text" name="password" size="15" class="f"> (A minimum of 4 numbers or letters)<br>

<font size="1" face="verdana, geneva, arial"> Verify:<br>

<input type="text" name="password2" size="15" class="f"> (In case you type wrong)<p><br>

<font size="1" face="verdana, geneva, arial">E-mail:<br>
<input type="text" name="email" size="15" class="f"> (In case you lose your password)<p>

<br>

</td>

</table>

</td>
</tr>

</table>

</body>

</html>

scoppc

You put all of the above code inside newuser.php (as specified in your ACTION attribute of the FORM tag)

So, all your checking should be done there and it will look like the one below:

//get the input from user
 $firstname=addslashes(strip_tags($_POST['fname']));
 $lastname=addslashes(strip_tags($_POST['lname']));
//check for required fields
if (empty($firstname) OR empty($lastname)){
print "sorry, you should complete the form";
}else{
//the rest of the code here
//after finish wif checking, u can insert the data

$sql="INSERT INTO yourtable VALUES($id,'$firstname','$lastname')";
$query=mysql_query($sql);

//check whether the query was successful
if (!$query){
print "Sorry, our server is currently busy";
}else{
print "welcome, your registration date is " . date("d F Y H:i:s",time());
}
}

Chrysanthus

It works but not as i won’t it to work see field $get_timestamp
This code should not execute if the entry’s are empty but the code execute anyway?

$firstname=$POST["firstname"];
$lastname=$POST["lastname"];
$birthdate=$POST["birthdate"];
$gender=$POST["gender"];
$email=$POST["email"];
$nickname=$POST["nickname"];
$password=$_POST["password"];

mysql_connect (localhost, root, ******);

   mysql_select_db (flameline);

        mysql_query ("INSERT INTO table_members (firstname, lastname, birthdate, gender, email, nickname, password) VALUES ('$firstname','$lastname','$birthdate','$gender','$email', '$nickname', '$password')");

<h1><b>User registered!</b></h1>

<?php

$firstname=addslashes(strip_tags($POST['firstname']));
$lastname=addslashes(strip_tags($POST['lastname']));

if (empty($firstname) OR empty($lastname)){
print "sorry, you should complete the form";
}else{

}

Firstname: <?php echo $POST["firstname"]; ?>
<br>
Lastname: <?php echo $POST["lastname"]; ?>
<br>
Gender: <?php echo $POST["gender"]; ?>
<br>
Birth: <?php echo $POST["birthdate"]; ?>
<p>
Nickname: <?php echo $POST["nickname"]; ?>
<br>
E-mail: <?php echo $POST["email"]; ?>

</font>

</td>
</tr>

</table>

</body>

</html>

scoppc

The logic should always goes this way...

Display a form for user to input her details
Link this form to a file to process (you linked it to newuser.php, which is fine)
In newuser.php, do the following:
3.a get all the value from all fields
3.b check for empty required fields to make sure that all required data is given
3.c Insert these data into database
3.d display SUCCESS or CONGRATULATIONS message to user.

<? 
//this is 3.a
$firstname=$_POST["firstname"]; 
$lastname=$_POST["lastname"]; 
$birthdate=$_POST["birthdate"]; 
$gender=$_POST["gender"]; 
$email=$_POST["email"]; 
$nickname=$_POST["nickname"]; 
$password=$_POST["password"]; 

//this is 3.b
if (empty($firstname) OR empty($lastname)){ 
print "sorry, you should complete the form"; 
}else{ 

//this is 3.c
mysql_connect (localhost, root, ******); 

mysql_select_db (flameline); 

$sqlquery=mysql_query ("INSERT INTO table_members (firstname, lastname, birthdate, gender, email, nickname, password) VALUES ('$firstname','$lastname','$birthdate','$gender','
$email', '$nickname', '$password')"); 

if (!$sqlquery){
print "sorry, our server is busy";

}else{

//this is 3.d
$get_timestamp = mysql_query("select UNIX_TIMESTAMP(regdate) as regdate from table_members ORDER BY regdate desc limit 1"); 

while ($row = mysql_fetch_array($get_timestamp)) { 
$reg = $row['regdate']; 
echo '<font size="1" face="verdana">You registered at: ' . date('Y-m-d', $reg) .'<br>' . 'Swedish time: ' . date('H:i', $reg) . '</FONT><br>'; 
} 

}

} 

?>

So, the point here is you have wrongly placed the code. That's all. You should get the application logic correct before writing the code.

Chrysanthus

okey no i see i started with inserting the values first and not with the if syntax...

Tanks 🙂 im lerning now yeah

Chrysanthus

one more thing

When i wont if to match anoter field with the same information

what syntax do i use then insted of OR empty

Is it

exampel

if ($password1) = ($password2))

EricC

Look at the documention on php.net (or its mirrors) for the parts about Operators, particularly comparison and logical

🙂

Chrysanthus

Thanks have read the not on php.net

but it ignors the syntax

Looki whats wrong if ther are anÝ

if (empty($firstname) OR empty($lastname) OR empty($birthdate) OR empty($gender) OR empty($email) OR empty($nickname) OR empty($password1) ==! ($password2)){
echo '<font size="1" face="verdana">Sorry no registration has been made ' . '<br>' . 'you did not complete the form correct.';
}else{

}

do you see any errors?

scoppc

If you are going to check for empty fields, you can obviously do it in one row as I've showed you. But if you wanna check for similarity between 2 string, you should do it in another if structure so that you can get the result you expected.

So, instead of writing:

if (empty($firstname) OR empty($lastname) OR empty($birthdate) OR empty($gender) OR empty($email) OR empty($nickname) OR empty($password1) ==! ($password2)){ 
echo '<font size="1" face="verdana">Sorry no registration has been made ' . '<br>' . 'you did not complete the form correct.'; 
}else{ 

}

you should write it this way:

if (empty($firstname) OR empty($lastname) OR empty($birthdate) OR empty($gender) OR empty($email) OR empty($nickname) OR empty($password1)){ 
echo '<font size="1" face="verdana">Sorry no registration has been made ' . '<br>' . 'you did not complete the form correct.'; 
}elseif ($password1!==$password2){ 
     print "Oopps, you fail to confirm your password.";
}else{
//other codes here
}

You dont have to check whether $password2 is empty, coz you are going to compare it anyway.

Chrysanthus

thanks it works but if i want to make an extra if field

is it just do enter the same code twice and change the if syntax

if (empty($firstname) OR empty($lastname) OR empty($birthdate) OR empty($gender) OR empty($email) OR empty($nickname) OR empty($password1)){
echo '<font size="1" face="verdana">Sorry no registration has been made ' . '<br>' . 'you did not complete the form correct.';
}elseif ($password1!==$password2){
print "Oopps, you fail to confirm your password.";

// exmapel
}elseif ($password3 !== $password4){
}else{
//other codes here
}

scoppc

Of course, but you should always pays attention on the logic of the code itself.

For example, you got telephone number field which is optional, you cant just check whether it contains numerical value before assuring that it is not empty.

You should first check whether user enters her telephone number, if yes, the check whether it contains numerical value. If it is not numeric, then display error message, else do nothing.

$telpno=$_POST['telephone'];
if (!empty($telpno)){
//only perform checking when telephone number is supplied
     if (!is_numeric($telpno)){
             print "Sorry, you must enter a valid telephone number!";
     }
}

Of course, usually you will allow telephone number to contain + or ( or ) sign. This just an example.
You really should start reading the few first chapters of PHP Documentation. It is very useful to start with.

Chrysanthus

thanks i read the documentation but i trying to understan and its hard if you not have done any code at all before but im lerning!!

Thanks!!