[Resolved] one more thing before i go home.

[gat]

ok, sorry to keep posting.
but i have this code.

the code is for a slide show.

that produces this error?

Notice: Undefined variable: thumb in c:\program files\apache group\apache\htdocs\mysql\photoview.php on line 9

---

<?php 

if(!($dbh=mysql_connect ("localhost", "gworsnup", "bracknell"))) 
die("Cannot connect to the database"); 

if (!mysql_select_db("kriminalyouth",$dbh)) 
die("Cannot open the database"); 

if(!isSet($thumb))
{ 
$thumb = 1; 
}
$thumb = substr($thumb, 0, 4); 
$thumb = EscapeShellCmd($thumb); 

$query = "SELECT pic_path, pic_area FROM images WHERE pic_id >= $thumb"; 
print($query);

$result = mysql_query($query); 
if(mysql_error()){ 
print mysql_error(); 
} 
if ($row = @ mysql_fetch_array($result)) 
{ 
$filename = $row["pic_path"]; 
echo "<img src=\"".$row['pic_path']."\" border='0'<br>"; 
} 
echo "$pic_path<br>";  

$anno = $row["pic_area"]; 
echo "</center><p>$anno</p><center><table BORDER=0 WIDTH=\"100%\">"; 

$lastthumb = $thumb - 1; 
$nextthumb = $thumb + 1; 

echo "<tr>"; 

echo "<td WIDTH=\"50%\" valign=\"top\"><h4><a href=\"photoview.php?thumb=$lastthumb\">"; 
echo "View Previous Photograph</a></h4></td>"; 

echo "<td WIDTH=\"50%\" valign=\"top\"><h4><a href=\"photoview.php?thumb=$nextthumb\">"; 
echo "View Next Photograph</a></h4></td>"; 
?> 

------------------------------

[Pig]

$thumb = substr($thumb, 0, 4);

You must have $thumb defined before you can use it in a function. Did you define prior to this, in another file?

[stolzyboy]

where is thumb initially, you can't do a substr on a variable that isn't there, and calling it and using it at the same time doesn't work either

[gat]

i did not define thum anyware,

i got this code from another post, and changed it slightly, to access the right tables and paths etc..

but no, i have not defined it anyware else...

could you tell me how?

[kevinsequeira]

how do you navigate to the page photoview.php ??
do you submit a form to come to this page, or follow a link which leads to this page ??
if its a form post the code for the form page
reg
kevin

[gat]

well thats a good question.

part of my gallery is the option of a slideshow.
so the user can either view the thumbnails on a page.

or go to the slide show page, (which i am trying to create now).

---

im not sure if this code is best to use?
its just one that i got offered.

i basically just want to flic through 'pic_path' which holds an image path with next and previous buttons.

so if there are 10 paths, i can flick through them on one page??

so, no there is no previous page, its just a link off the homepage to 'view slideshow'

---

[kevinsequeira]

in your table is the column pic_id an integer which is the primary key or something like that ??

try this, before line 9 add this code

if(!isSet($thumb)){
$thumb = 1;
}

reg
kevin

[gat]

ok, i added the bit of code....

now the error has gone. (no errors).
but i do get the "Cannot execute query against the database"

and yep.... pic_id is the primary key, its a int(4) autoincrament from 1 to however many paths are stored.

[kevinsequeira]

try this
.
.
.

$query = "SELECT pic_path, pic_date FROM images WHERE pic_id >= $thumb";

print($query);

what does it print ??

reg
kevin

[gat]

for some reason it prints the statement its self.

"SELECT pic_path, pic_date FROM images WHERE pic_id >= 1Cannot execute query against the database"

but it does assign thumb as 1.?

maybe there is error in my code, ?
ill keep messing.

[gat]

ok, silly little error pic_date, was from the new DB, im working with the old one here at work, so its pic_area instead.

i changed this, and magically the an image is displayed allong with the next and previous buttons. but they dont work and i get this error.

---

Notice: Undefined variable: pic_path in c:\program files\apache group\apache\htdocs\mysql\photoview.php on line 27

line 27 = echo "$pic_path<br>";

were getting closer, definatly

ill re post the code in the main one above

[kevinsequeira]

change echo "$pic_path<br>";

to echo "$filename<br>";

reg
kevin

[gat]

the query in mysql returns all 12 image paths and details currently in the images table.

so that works!

---

i reposted the code above, i have been doing a,lot of juggling, so there may be some simple things that i have missed.

after inserting the code to replace the query error, nothing has happened.

best re check the code......

this is great help .....

[kevinsequeira]

change echo "$pic_path<br>";
to echo "$filename<br>";
reg
kevin

[gat]

ok, i saw your edited post. all errors have gone now, but i still get

"SELECT pic_path, pic_area FROM images WHERE pic_id >= 1"

at the top of the page above the image?

[kevinsequeira]

lol, i think there is print($query) in the code ...

delete the line or comment it ...

reg
kevin

[gat]

ok great.....no errors.

let me just tell you what the links are doing. (because their not working)

---

this is in the address bar:

http://localhost/mysql/photoview.php?thumb=2

if i hover over "View Previous Photograph"
it is looking for:

http://localhost/mysql/photoview.php?thumb=0

if i hover over "View Next Photograph"
it is looking for

http://localhost/mysql/photoview.php?thumb=2

---

but neither do anything.

[kevinsequeira]

do these changes.

change all of this

if(!isSet($thumb)){
$thumb = 1;
}
$thumb = substr($thumb, 0, 4);
$thumb = EscapeShellCmd($thumb);
$query = "SELECT pic_path, pic_area FROM images WHERE pic_id >= $thumb";

to

if(!isSet($thumb)){
$thumb = 1;
}else{
if($thumb < 1)
$thumb = 1;
}

$query = "SELECT pic_path, pic_area FROM images WHERE pic_id = $thumb";

reg

kevin

[gat]

hmmm, still the same. No errors, but both links are doing nothing.

prev still tries: http://localhost/mysql/photoview.php?thumb=0
next still tries: http://localhost/mysql/photoview.php?thumb=2

---

<?php 

if(!($dbh=mysql_connect ("localhost", "***", "*****"))) 
die("Cannot connect to the database"); 

if (!mysql_select_db("kriminalyouth",$dbh)) 
die("Cannot open the database"); 

if(!isSet($thumb))
{ 
$thumb = 1; 
}else
{ 
if($thumb < 1) 
$thumb = 1; 
} 
$query = "SELECT pic_path, pic_area FROM images WHERE pic_id = $thumb"; 
$result = mysql_query($query); 
if(mysql_error()){ 
print mysql_error(); 
} 
if ($row = @ mysql_fetch_array($result)) 
{ 
$filename = $row["pic_path"]; 
echo "<img src=\"".$row['pic_path']."\" border='0'<br>"; 
} 
echo "<br>$filename";   

$anno = $row["pic_area"]; 
echo "</center><p>$anno</p><center><table BORDER=0 WIDTH=\"100%\">"; 

$lastthumb = $thumb - 1; 
$nextthumb = $thumb + 1; 

echo "<tr>"; 

echo "<td WIDTH=\"50%\" valign=\"top\"><h4><a href=\"photoview.php?thumb=$lastthumb\">"; 
echo "View Previous Photograph</a></h4></td>"; 

echo "<td WIDTH=\"50%\" valign=\"top\"><h4><a href=\"photoview.php?thumb=$nextthumb\">"; 
echo "View Next Photograph</a></h4></td>"; 
?> 

the code looks good to me for the next and prev links???
cant see why it will not work.

[kevinsequeira]

did quite a few changes to the code, didnt check for syntax errors though

<?php 
if(!($dbh=mysql_connect ("localhost", "gworsnup", "bracknell"))) 
	die("Cannot connect to the database"); 
if (!mysql_select_db("kriminalyouth",$dbh)) 
	die("Cannot open the database"); 

$total_query = "select count(*) from images";
$total_result = mysql_query($total_query);
$total_row = mysql_fetch_array($total_result);
$max_images = $total_row[0];
// printing total images to debug
print("total images = ".$max_images);
if(!isSet($_GET('thumb'))){ 
	$thumb = 1; 
}else{
	$thumb = $_GET('thumb');
	if($thumb < 1)
		$thumb = 1;
	if($thumb > $max_images)
		$thumb = $max_images;		
}
// printing thumb to debug
print ("thumb value is ".$thumb);
$query = "SELECT pic_path, pic_area FROM images WHERE pic_id = $thumb"; 
$result = mysql_query($query); 
if(mysql_error()){ 
	print mysql_error(); 
}
if(mysql_num_rows($result)== 0){
// if images does not exist, show 1st images
     $query = "SELECT pic_path, pic_area FROM images WHERE pic_id = 1"; 
     $result = mysql_query($query); 
} 
// printing query to debug
print($query);

if ($row = @ mysql_fetch_array($result)){ 
	$filename = $row["pic_path"]; 
	echo "<img src=\"".$row['pic_path']."\" border='0'<br>"; 
} 
	echo "$pic_path<br>";  

	$anno = $row["pic_area"]; 
	echo "</center><p>$anno</p><center><table BORDER=0 WIDTH=\"100%\">"; 

$lastthumb = $thumb - 1; 
$nextthumb = $thumb + 1;

if($lastthumb < 1)
	$lastthumb = 1;

if($nextthumb > $max_images)
	$nextthumb = $max_images;

echo "<tr>"; 
echo "<td WIDTH=\"50%\" valign=\"top\"><h4><a href=\"photoview.php?thumb=$lastthumb\">"; 
echo "View Previous Photograph</a></h4></td>"; 
echo "<td WIDTH=\"50%\" valign=\"top\"><h4><a href=\"photoview.php?thumb=$nextthumb\">"; 
echo "View Next Photograph</a></h4></td>"; 
?> 

any luck

reg
kevin