Need Help on File Upload script

FoxhoundX

Okay, I have most of this planned out, but I have few ideas on how to upload the file. What I basically want to have is a form with a space where you click browse and select the file, then there is a space for name, and a space for email.

It will store the info into a text file, and then the listing of the pictures just includes the text file.

My problem is, how would I easily get the file onto the server? Also, would there be an easy way to check if the file was *.jpg?

Thanks a lot
FB

matt_4013

Hi there, first of all, have a read of this: http://www.php.net/manual/en/features.file-upload.php

That does a really good job of explaining how to handle file uploading to a PHP server. The main thing you have to remember is that the user your web server (Apache?) is running as (usually 'nobody') must have write permission to for the directory you're copying to.

To validate if it's a jpg, there are a couple of things you can do. I would do it like this:

if($_FILES['userfile']['type'] != "image/jpeg") {

	unlink($_FILES['userfile']['tmp_name']);
	die("Invalid File Type!");

} elseif(!move_uploaded_file($_FILES['userfile']['tmp_name'], $newfile)) {

	@unlink($_FILES['userfile']['tmp_name']);	
	die("File Upload Failed!");

} else {

	echo "File Upload Successful!";
}

FoxhoundX

Okay.

Another question,

could you give an example of how this would work.. What i want is a form that will have slots of the file, name, and email.

It will redirect to another php file which will do all the checks/formatting, and then save it in a file something like

<table width="500" border="0" cellpadding="2" cellspacing="0">
				<tr>
					<td width="230"><font size="2">$name</font></td>					<td valign="bottom"><a $Email</td>
					<td valign="bottom"></td>
					<td valign="bottom" align="right">$date, $time</td>
				</tr>
				<tr height="2"><td colspan="5" height="2" bgcolor="#003399"></td></tr>
		       		<tr>
					<td colspan="5" bgcolor="white"><font color="black">$file location



</font></td>
				</tr>
		       </table><br>

Where every new entry would add that to a txt file and then I could just do a include the txt

matt_4013

Have a look at this 🙂

http://www.phpbuilder.com/board/showthread.php?s=&threadid=10239518

FoxhoundX

Okay..it doesnt seem to be doing a whole lot 😛

here are my files:
Its probably something really stupid 😛

upload.php

<HTML><HEAD><TITLE>T4CBible Screenshot Upload by Firebird</TITLE></HEAD>
<BODY>
<FORM METHOD="POST" ACTION="upload2.php" ENCTYPE="multipart/form-data">
<input type="text" name="name" />
<input type="text" name="email" />
<input type="text" name="msg1" />
<input type="submit" value="upload" />
</form>
</BODY></HTML>

upload2.php

<HTML><HEAD><TITLE>T4C Bible Screenshot Upload by Firebird</TITLE></HEAD>
<BODY>

<?php
if(!empty($_POST)) {


    $sNewLine = $_POST['name'].",".$_POST['email'].",".$_POST['msg1']."\n";

    $fp = fopen("pics.txt", "a");

    fwrite($fp, $sNewLine);

    fclose($fp);

    echo "Added Successfully!!";

} else {
     echo "Error Uploading! :(";
}
?>
</BODY>
</HTML>

matt_4013

If I understand what you're actually trying to do, you'll want something like this:

upload.php

<HTML><HEAD><TITLE>T4CBible Screenshot Upload by Firebird</TITLE></HEAD>
<BODY>
<FORM METHOD="POST" ACTION="upload2.php" ENCTYPE="multipart/form-data">
<input type="text" name="name" />
<input type="text" name="email" />
<input type="file" name="screenshot" />
<input type="submit" value="upload" />
</form>
</BODY></HTML>

upload2.php

// Check if your form has been posted
if(!empty($_POST)) {

// Check if a file was uploaded
if($_FILES['screenshot']['size'] != 0) {

	// Do the validation and copying of screenshot
	if($_FILES['screenshot']['type'] != "image/jpeg") {

		unlink($_FILES['screenshot']['tmp_name']);
		die("Invalid File Type!");

	}  elseif(!move_uploaded_file($_FILES['screenshot']['tmp_name'], $newfile)) {

		@unlink($_FILES['screenshot']['tmp_name']);    
		die("File Upload Failed!");

	} else {

	        echo "File Upload Successful!";
	}
} else {

	// If they didn't upload a screenshot
	die("No photo selected");
}

// That's the upload taken care of, now we have to write to the file

// Create the html to go into the file
$sFileContents  = '<table width="500" border="0" cellpadding="2" cellspacing="0">';
$sFileContents .= '<tr><td width="230"><font size="2">'.$name'.</font></td>';
$sFileContents .= '<td valign="bottom">'.$Email.'</td>';
$sFileContents .= '<td valign="bottom">&nbsp;</td>';
$sFileContents .= '<td valign="bottom" align="right">'.$date.', '.$time.'</td>';
$sFileContents .= '</tr><tr height="2"><td colspan="5" height="2" bgcolor="#003399">&nbsp;</td></tr>';
$sFileContents .= '<tr><td colspan="5" bgcolor="white"><font color="black">'.basename($newfile).'</font></td>';
$sFileContents .= '</tr></table><br>';

// Open the file
if(($fp = fopen("pics.txt", "a")) !== false) {

	// Write to it
	fwrite($fp, $sFileContents);

	// Close the file
	fclose($fp);

	echo "It worked!";
} else {

	@unlink($newfile);
	@unlink($_FILES['screenshot']['tmp_name']);

	die("File Open failed! Oh god!");
}
} else {

header("Location: upload.php");
}

Hope that helps,
Matt

FoxhoundX

Wow, thanks so much.

One problem though, im testing it and i get a

Parse error: parse error in upload2.php on line 34

any ideas?

matt_4013

I've edited it, it should be alright now. I just forgot a semi-colon 😉

FoxhoundX

Was still parsing wrong, but i found the error:

$sFileContents .= '<tr><td width="230"><font size="2">'.$name'.</font></td>';

You have '.$name'. instead of '.$name.' 😉

But now, it ALWAYS gives me the invalid file type message, even when it is a jpg file.. :S

matt_4013

Probably got the MIME type wrong, change it to image/jpg

Maybe, heh. Been a while since I've done anything with images, not entirely sure. Give image/jpg a go, it should be alright. BTW, do you know if register_globals is turned on, on your server? If it isn't you'll have to change $name, $email, etc, to $POST['name'], $POST['email']

FoxhoundX

still doesnt work.. :mad: