What is the problem with this?!

zingbats

  <table border="1" cellpadding="0" cellspacing="0" style="border-collapse: collapse; border-top-width: 0" width="90%" id="AutoNumber1" bordercolorlight="#FFFF66" bordercolordark="#FFFF66" height="61">
    <tr>
      <td width="100%" bordercolorlight="#FFFF00" bordercolordark="#FFFF66" bordercolor="#FFFF66" style="border-left: 1px solid #FFFF00; border-right-style: solid; border-right-width: 1; border-top: 1px solid #FFFF00; border-bottom-style: solid; border-bottom-width: 1" colspan="3" height="19">
      Clan Details:</td>
    </tr>
    <?php
    $link = mysql_connect("localhost", "username", "password")
        or die("Could not connect");
    mysql_select_db("tycooneden_com") or die("Could not select database");

$query = "SELECT * FROM clans LIMIT 0,30";
$result = mysql_query($query) or die("Query failed");

while($foo=mysql_fetch_array($result)){ 

$clan_url=$foo['clan_url']; 
$clan_logo=$foo['clan_logo']; 
$clan_admin=$foo['clan_admin']; 
$clan_admin_email=$foo['clan_admin_email']; 
$clan_forum=$foo['clan_forum']; 
$clan_name=$foo['clan_name']; 
$clan_logo_height=$foo['clan_logo_height']; 
$clan_logo_width=$foo['clan_logo_width'];
$clan_points=$foo['clan_points']; 

print ("
    <tr>
      <td width='21%' bordercolorlight='#FFFF66' bordercolordark='#FFFF66' bordercolor='#FFFF66' style='border-left-style: solid; border-left-width: 1; border-right-style: solid; border-right-width: 1; border-top-style: none; border-top-width: medium; border-bottom-style: solid; border-bottom-width: 1' height='18'>
      Site name: $clan_name</td>
      <td width='79%' colspan='2' bgcolor='#FFFF66' bordercolorlight='#000000' bordercolordark='#000000' height='19'>&nbsp;</td>
    </tr>
    <tr>
      <td width='21%' rowspan='3' bgcolor='#FFFF66' style='border-left-width: 1' bordercolorlight='#000000' bordercolordark='#000000' height='57'>&nbsp;</td>
      <td width='59%' bordercolorlight='#000000' bordercolordark='#000000' height='19'>Site 
      url: $clan_url</td>
      <td width='20%' height='19' bordercolorlight='#000000' bordercolordark='#000000'>Points: $clan_points</td>
    </tr>
    <tr>
      <td width='79%' colspan='2' bgcolor='#FFFF66' bordercolorlight='#000000' bordercolordark='#000000' height='19'>&nbsp;</td>
    </tr>
    <tr>
      <td width='79%' colspan='2' height='17'>
      if $clan_logo = ''; {
      print '<img border=\'0'\ src=\'$clan_logo'\ width=\'$clan_logo_width'\ height=\'$clan_logo_height'\></td>';
      } else {
      print 'Sorry, no logo has been specified.';
      }
    </tr>
        <tr>
      <td width='100%' bgcolor='#6699FF' style='border-left-width: 1' bordercolorlight='#000000' bordercolordark='#000000' height='20' colspan='3'>&nbsp;</td>
    </tr>");
}
    mysql_close($link);
?>

  </table>

To view the problem, look at http://www.tycooneden.com/tecc.php

cmburns69

There is an if statement in the middle of your print statement.

I prefer to not use multi-line print statements, because it can cause this sort of confusion.

Old Way:
<?php
    print "<table border=1>
        <tr><td>Stuff Here</td></tr>
        </table>";
?>

New way:
<?php
    print "<table border=1>\n";
    print "<tr><td>Stuff Here</td></tr>\n";
    print "</table>\n";
?>

The "\n" at the end of each line is a newline character, to keep it readable when you view the source.

Tom Brown
An online Starcraft RPG? Only at
http://www.netnexus.com

kevinsequeira

the single quotes ' in the print statements where screwing up things. try this instead

<?php
while($foo=mysql_fetch_array($result)){ 
     $clan_url=$foo['clan_url']; 
     $clan_logo=$foo['clan_logo']; 
     $clan_admin=$foo['clan_admin']; 
     $clan_admin_email=$foo['clan_admin_email']; 
     $clan_forum=$foo['clan_forum']; 
     $clan_name=$foo['clan_name']; 
     $clan_logo_height=$foo['clan_logo_height']; 
     $clan_logo_width=$foo['clan_logo_width'];
     $clan_points=$foo['clan_points']; 
?>
   <tr>
      <td width='21%' bordercolorlight='#FFFF66' bordercolordark='#FFFF66' bordercolor='#FFFF66' style='border-left-style: solid; border-left-width: 1; border-right-style: solid; border-right-width: 1; border-top-style: none; border-top-width: medium; border-bottom-style: solid; border-bottom-width: 1' height='18'>
      Site name: <?=$clan_name?></td>
      <td width='79%' colspan='2' bgcolor='#FFFF66' bordercolorlight='#000000' bordercolordark='#000000' height='19'>&nbsp;</td>
    </tr>
    <tr>
      <td width='21%' rowspan='3' bgcolor='#FFFF66' style='border-left-width: 1' bordercolorlight='#000000' bordercolordark='#000000' height='57'>&nbsp;</td>
      <td width='59%' bordercolorlight='#000000' bordercolordark='#000000' height='19'>Site 
      url: <?=$clan_url?></td>
      <td width='20%' height='19' bordercolorlight='#000000' bordercolordark='#000000'>Points: <?=$clan_points?></td>
    </tr>
    <tr>
      <td width='79%' colspan='2' bgcolor='#FFFF66' bordercolorlight='#000000' bordercolordark='#000000' height='19'>&nbsp;</td>
    </tr>
    <tr>
      <td width='79%' colspan='2' height='17'>
<?php
      if ($clan_logo ==""){
?>
			<img border='0' src='<?=$clan_logo?>' width='<?=$clan_logo_width?>' height='<?=$clan_logo_height?>'>
<?php
      } else {
?>
      Sorry, no logo has been specified.
<?php
      }
?>
		</td>
    </tr>

    <tr>

  <td width='100%' bgcolor='#6699FF' style='border-left-width: 1' bordercolorlight='#000000' bordercolordark='#000000' height='20' colspan='3'>&nbsp;</td>

</tr>
<?php
}
?>

also in the if condition you need to have two equal like

  if ($clan_logo =="")

reg
kevin

zingbats

brilliant. Cheers.

But.... can you make the "if" so that if the URL is dead (i.e, if the picture doesn't show), it displays "sorry, no image is available"

kevinsequeira

within the if statement do this

<?php

  if ($clan_logo ==""){
  $logo_location = "http://www.someurl_to_logo.com/".$clan_logo;
		$fp = @fopen($logo_location,"r"); 
		if ($fp){

?>
<img border='0' src='<?=$clan_logo?>' width='<?=$clan_logo_width?>' height='<?=$clan_logo_height?>'>
<?php
}else{
print "sorry, no image is available";
}
fclose($fp);
} else {

  Sorry, no logo has been specified.

<?php

this might work, see if the path to the logo is proper

zingbats

ok, the code is now:

<table border="1" cellpadding="0" cellspacing="0" style="border-collapse: collapse; border-top-width: 0" width="90%" id="AutoNumber1" bordercolorlight="#FFFF66" bordercolordark="#FFFF66" height="61">
    <tr>
      <td width="100%" bordercolorlight="#FFFF00" bordercolordark="#FFFF66" bordercolor="#FFFF66" style="border-left: 1px solid #FFFF00; border-right-style: solid; border-right-width: 1; border-top: 1px solid #FFFF00; border-bottom-style: solid; border-bottom-width: 1" colspan="3" height="19">
      Clan Details:</td>
    </tr>
    <?php
    /* Connecting, selecting database */
    $link = mysql_connect("localhost", "zingbats", "zingbat")
        or die("Could not connect");
    mysql_select_db("tycooneden_com") or die("Could not select database");

$query = "SELECT * FROM clans LIMIT 0,30";
$result = mysql_query($query) or die("Query failed");

 while($foo=mysql_fetch_array($result)){ 
 $clan_url=$foo['clan_url']; 
 $clan_logo=$foo['clan_logo']; 
 $clan_admin=$foo['clan_admin']; 
 $clan_admin_email=$foo['clan_admin_email']; 
 $clan_forum=$foo['clan_forum']; 
 $clan_name=$foo['clan_name']; 
 $clan_logo_height=$foo['clan_logo_height']; 
 $clan_logo_width=$foo['clan_logo_width'];
 $clan_points=$foo['clan_points']; 
?>

   <tr>
      <td width='21%' bordercolorlight='#FFFF66' bordercolordark='#FFFF66' bordercolor='#FFFF66' style='border-left-style: solid; border-left-width: 1; border-right-style: solid; border-right-width: 1; border-top-style: none; border-top-width: medium; border-bottom-style: solid; border-bottom-width: 1' height='18'>
      Site name: <?=$clan_name?></td>
      <td width='79%' colspan='2' bgcolor='#FFFF66' bordercolorlight='#000000' bordercolordark='#000000' height='19'>&nbsp;</td>
    </tr>
    <tr>
      <td width='21%' rowspan='3' bgcolor='#FFFF66' style='border-left-width: 1' bordercolorlight='#000000' bordercolordark='#000000' height='57'>&nbsp;</td>
      <td width='59%' bordercolorlight='#000000' bordercolordark='#000000' height='19'>Site 
      url: <a href="<?=$clan_url?>"><?=$clan_url?></a></td>
      <td width='20%' height='19' bordercolorlight='#000000' bordercolordark='#000000'>Points: <?=$clan_points?></td>
    </tr>
    <tr>
      <td width='79%' colspan='2' bgcolor='#FFFF66' bordercolorlight='#000000' bordercolordark='#000000' height='19'>&nbsp;</td>
    </tr>
    <tr>
      <td width='79%' colspan='2' height='17'>
<?php 

if ($clan_logo ==""){ 
$logo_location = "http://www.someurl_to_logo.com/".$clan_logo; 
$fp = @fopen($logo_location,"r"); 
if ($fp){ 
?> 
<img border='0' src='<?=$clan_logo?>' width='<?=$clan_logo_width?>' height='<?=$clan_logo_height?>'> 
<?php 
}else{ 
print "sorry, no image is available"; 
} 
fclose($fp);
} else { 

?> 

Sorry, no logo has been specified. 

<?php 

} 

?>  

        </td>
    </tr>

    <tr>

  <td width='100%' bgcolor='#6699FF' style='border-left-width: 1' bordercolorlight='#000000' bordercolordark='#000000' height='20' colspan='3'>&nbsp;</td>

</tr>
<?php
}
?>

  </table>

The error is:

Warning: fclose(): supplied argument is not a valid File-Handle resource in /path/file.php on line 80

zingbats

? Could someone answer please 😃

zingbats

right. I sorted out the fclose error.

But.. the dead images STILL show. Here is the important quote:

NOTE: $clan_logo is a FULL URL!

<?php
if ($clan_logo ==""){ 
$logo_location = "$clan_logo"; 
$fp = @fopen($logo_location,"r"); 
if ($fp){ 
?> 
Sorry, no image has been specified
<?php 
}else{ 
print "Sorry, no picture is avaliable for the clan $clan_name";
} 
@fclose($fp);
} else {
print "<img border='0' src='$clan_logo' width='$clan_logo_width' height='$clan_logo_height'>";
}
?>  

        </td>
    </tr>

    <tr>

  <td width='100%' bgcolor='#6699FF' style='border-left-width: 1' bordercolorlight='#000000' bordercolordark='#000000' height='20' colspan='3'>&nbsp;</td>

</tr>
<?php
}
?>

darkfunkel

if ($fp) fp what? maybe

<?php
if ($clan_logo ==""){ 
$logo_location = "$clan_logo"; 
$fp = @fopen($logo_location,"r"); 
if ($fp == ""){ 
?> 
Sorry, no image has been specified
<?php 
}else{ 
print "Sorry, no picture is avaliable for the clan $clan_name";
} 
@fclose($fp);
} else {
print "<img border='0' src='$clan_logo' width='$clan_logo_width' height='$clan_logo_height'>";
}
?>  

        </td>
    </tr>

    <tr>

  <td width='100%' bgcolor='#6699FF' style='border-left-width: 1' bordercolorlight='#000000' bordercolordark='#000000' height='20' colspan='3'>&nbsp;</td>

</tr>
<?php
}
?>

maybe

zingbats

hmmmm there are two elses.. and "if ($fp)" if $fp is what.. it is messed up