[Resolved] Fault ?

[benson]

Hello,
I have a script what must reveal the files in a DIR.
But it gives an error:
Parse error: parse error, unexpected T_VARIABLE in /home/virtual/site185/fst/var/www/html/b/manage.php on line 5

This is the code from manage.php

<?php
include("templates/Header.php")
//begin code

$dir = "/images/";
// Open a known directory, and proceed to read its contents
if (is_dir($dir)) {
    if ($dh = opendir($dir)) {
        while (($file = readdir($dh)) !== false) {
            print "filename: $file : filetype: " . filetype($dir . $file) . "\n";
        }
    closedir($dh);
    }
}
//end code
include("templates/Footer.php")
?>

[ir4z0r]

put a ; behind your second line (include ...)

[kevinsequeira]

u forgot to close lines with a ;

change

include("templates/Header.php")
to
include("templates/Header.php");

and

include("templates/Footer.php")
to
include("templates/Footer.php");

reg
kevin

[benson]

Djees what a dumbass was i.....
But i Changed al of that.
And i still get a error.
I changed the chmod of "images/" to 777
And he gives the error:
Warning: is_dir() [function.is-dir]: SAFE MODE Restriction in effect. The script whose uid is 696 is not allowed to access / owned by uid 0 in /home/virtual/site185/fst/var/www/html/b/manage.php on line 7

Benson

[tsinka]

Hi,

seems like safe mode has been enabled in the php configuration. Make sure that all directories you want to access are owned by the user of the web server.

Alternatively (if you don't have shell access) you might need to change $dir to the absolute path to that directory, e.g.

$dir = "/home/virtual/site185/fst/var/www/html/b/images";

[benson]

i did what you've tolde me to to but it didn't worked now it giving me multiple errors !!!

Error log:
Warning: filetype() [function.filetype]: Lstat failed for (null) (errno=2 - No such file or directory) in /home/virtual/site185/fst/var/www/html/b/manage.php on line 10
filename: . : filetype:
Warning: filetype() [function.filetype]: Lstat failed for (null) (errno=2 - No such file or directory) in /home/virtual/site185/fst/var/www/html/b/manage.php on line 10
filename: .. : filetype:
Warning: filetype() [function.filetype]: Lstat failed for (null) (errno=2 - No such file or directory) in /home/virtual/site185/fst/var/www/html/b/manage.php on line 10
filename: #// on this place where the filenames for every file a error //#: filetype:

[tsinka]

Hi,

did you try to change

filetype($dir . $file)

to

filetype($dir."/".$file)

I think the script tries to get the filetype of e.g.
imagesimage1.jpg instead of
images/image1.jpg

And you might want to filter out . and .. and other directories that might be in the images directory.

[benson]

HOw can i filter other dirs out ??

[tsinka]

With the is_dir function which you already use 🙂

include("templates/Header.php")
//begin code

$dir = "/home/virtual/site185/fst/var/www/html/b/images";

// Open a known directory, and proceed to read its contents
if (is_dir($dir)) {
    if ($dh = opendir($dir)) {
        while ($file = readdir($dh)) {
            $strFile = $dir."/".$file;
            if (!is_dir($strFile)) {
                echo "filename: $file : filetype: " . filetype($strFile) . "<br>\n";
            }
        }
        closedir($dh);
    }
}
//end code
include("templates/Footer.php")

[tsinka]

A little bit shorter:

include("templates/Header.php")
//begin code

$dir = "/home/virtual/site185/fst/var/www/html/b/images";

// Open a known directory, and proceed to read its contents
if (is_dir($dir)) {
    if ($dh = opendir($dir)) {
        while ($file = readdir($dh)) {
            $strFile = $dir."/".$file;
            echo is_dir($strFile) ? "" : "filename: $file : filetype: " . filetype($strFile) . "<br>\n";
        }
        closedir($dh);
    }
}
//end code
include("templates/Footer.php")

btw, the problem with $dir="/images/" might have been the first /.
$dir="images/" might work 🙂

[benson]

Ok i did that but it wont work now.
My destination is that it wil become a script that can delete files.
but first this part must work...
my error:
Parse error: parse error, unexpected '>' in /home/virtual/site185/fst/var/www/html/b/manage.php on line 12

my code:

<?php
include("templates/Header.php");
//begin code
echo "<div align=\"center\">";
echo "<table border=\"0\" cellspacing=\"1\" width=\"756\">";
$dir = "/home/virtual/site185/fst/var/www/html/b/images";
// Open a known directory, and proceed to read its contents
if (is_dir($dir)) {
    if ($dh = opendir($dir)) {
        while ($file = readdir($dh)) {
            $strFile = $dir."/".$file;
            echo is_dir($strFile) ? ""<tr><td width=\"20\"><input type=\"checkbox\" name=\"$file\"></td><td width=\"722\">
filename: $file
</td></tr>";
        }
        closedir($dh);
    }
}
//end code
include("templates/Footer.php");
?>
 

[tsinka]

Hi,

seems like

</td></tr>";

is on an extra line

echo is_dir($strFile) ? "" : "<tr><td width=\"20\"><input type=\"checkbox\" name=\"$file\"></td><td width=\"722\">
filename: $file</td></tr>";

all on one line

[Moonglobe]

what's line 12? your line numbers are messed up in the code you posted.

[benson]

The errors are just copied pasted.
Maybe the includes have something to do about it ??
By the way it worked !!!
Another question.
I want some filenames out of the delete section can that be done or is it immpossible ?

[tsinka]

Hi,

yes you can. Do you want to display directories ? What kind of application do you want to develop ? An image galery ? It might be helpful for you to browse the phpbuilder code library (Graphics section or whatever you want). There are plenty of examples, even complete graphics gallery applications with support for galleries with subdirectories 🙂

T.

[benson]

I want to make a script wich displays al the files in one dir.
And i have to select files and push a button to delete the files selected with a checkbox.
And there are some images that must be undeleteable or not shown
No image gallery, only a "delete images script".
thanx for al your help

[tsinka]

Hi,

do you know the filenames you want to exclude (I think so) ?

You could then crate an array like

$arrExclude = array("file1.jpg","secondfile.txt");

and in the while loop

while ($file = readdir($dh)) {
    if (in_array($file,$arrExclude))
        continue;

$strFile = $dir."/".$file;
echo is_dir($strFile) ? "" : "<tr><td width=\"20\"><input type=\"checkbox\" name=\"$file\"></td><td width=\"722\">filename: $file</td></tr>";
}

[benson]

Thanx,
it worked perfectly..
But now i have to delete some of those files.
I think the form must be something like this
<form method="post" action="<?php $php_self ?>
checkboxes.....
<input type="submit" value=" Submit ">

and the php code like this:

if ($submit)
{
unlink($file);
}
else
{
echo "An error has occured");
} 

But the problem is that it have to delete multiple files (Random(10))

[tsinka]

Ok,

seems like we're coming close to the end 🙂

here's a short example (no relation to your code but it shouldn't be hard to use something similar in your script):

html>
<head>
</head>
<body>
<form method="post" action="delete.php" name="test">
<input type="checkbox" name="deleteFile[]" value="a">a<br>
<input type="checkbox" name="deleteFile[]" value="b">b<br>
<input type="checkbox" name="deleteFile[]" value="c">c<br>
<input type="checkbox" name="deleteFile[]" value="d">d<br>
<input type="checkbox" name="deleteFile[]" value="e">e<br>
<input type="checkbox" name="deleteFile[]" value="f">f<br>
<input type="checkbox" name="deleteFile[]" value="g">g<br>
<input type="checkbox" name="deleteFile[]" value="h">h<br>
<input type="checkbox" name="deleteFile[]" value="i">i<br>
<input type="hidden" name="deleteFiles" value="1">
<input type="submit" value="delete" onClick="return confirm('Do you really want to delete the files ?')">
</form>
<?PHP

for ($i=0;$i<count($_POST['deleteFile']);$i++) {
  echo $_POST['deleteFile'][$i]."<br>\n";
}
?>
</body>
</html>

Use $strFile as values You'll then have the complete path to the files to delete.

The hidden input is a trigger to delete. You can then check if that variable exists with e.g.

if ($_POST['deleteFiles']) {
//delete the file with the for loop above ...
}

Thomas

[benson]

Sorry but i don't get it...
I have multiple checkboxes....
i wil paste some of the code generated at my site....:

<form method="post" action="//must be somthing like $php_self\\">
<div align="center">
<table border="0" cellspacing="1" width="400">
<tr><td width="20" bgcolor="red">ch</td>
<td width="722"bgcolor="black">
<font color="red">filenaam</font></td></tr>
<tr><td width="20"><input type="checkbox" name="try.jpg">
</td><td width="722">
<font color="red">try.jpg</font></td></tr>
<tr><td width="20"><input type="checkbox" name="Avatarr.jpg"></td>
<td width="722">
<font color="red">Avatarr.jpg</font></td></tr>td width="722">
<font color="red">security.gif</font></td></tr></table><input type="submit" value=" Submit "></form></center> 

The form must be submitted to itself so a if ($submit) must be before the unlink code....