[Resolved] username taken, registration script

[Mark]

can anyone tell me why this isnt working, i cant get my usercheck to work. when i try to register a name it says every name is already taken.

<? 
$db = mysql_connect("localhost","******","*****");
mysql_select_db ("Hazardnet"); 
if(empty($username) || empty($passwd) || empty($email))
{
mysql_close($db); 
echo "Please fill out all fields."
}

$result = mysql_query ("INSERT INTO HN_users (username, passwd, email) 
                VALUES ('$username', '$passwd', '$email',)");


//check if username is already taken.
//Here is my problem.. i cant get it to work
$usercheck = "SELECT * from HN_users WHERE username = '$username'";
if(!$usercheck == 0){
mysql_close($db); 
echo "$username is already taken, sorry, please try again.";
}
else if(!$result) 
{ 
   echo "<b>There was a problem!</b> ", mysql_error(); 
}

//End UserCheck

if($result) 
    { 
    mysql_close($db); 
    print "Thank you for registering with HazardNet Computers! you may now login!";
    } 
?>

[kevinsequeira]

try this .......

//check if username is already taken.

//Here is my problem.. i cant get it to work

$usercheck = "SELECT * from HN_users WHERE username = '$username'";
$result = mysql_query($usercheck);
if(mysql_num_rows($result)!=0){
mysql_close($db);
echo "$username is already taken, sorry, please try again.";
}

//End UserCheck

reg
kevin

[kevinsequeira]

here is a better structured code

<? 
$db = mysql_connect("localhost","******","*****");
mysql_select_db ("Hazardnet"); 
if($username=="" || $passwd=="" || $email==""){
     echo "Please fill out all fields."
}else{
     $check_query = "SELECT * from HN_users WHERE username = '$username'";
     $result = mysql_query($check_query);
     if(mysql_num_rows($result)!=0){
    	 echo "$username is already taken, sorry, please try again.";
	 }else{
			$insert_query = "INSERT INTO HN_users (username, passwd, email)VALUES ('$username', '$passwd', '$email',)";
			$result = mysql_query ($insert_query);
			if(mysql_error()){
				echo "there was a problem";
			}else{
		    echo "Thank you for registering with HazardNet Computers! you may now login!";			
			}	 
	 }
}
mysql_close($db);
?>

reg
kevin

[Mark]

thanks kev, and i used your new code and it gives me this error

Parse error: parse error, unexpected '}', expecting ',' or ';' in C:\Documents and Settings\Administrator\Desktop\HazardNet\login\register.php on line 6

i put a semicolon on on the echo line where one was forgetten, now i'm just getting "There was a problem" when trying to register

[kevinsequeira]

i missed the ; after the end of the line

echo "Please fill out all fields."

change it to this

echo "Please fill out all fields.";

reg
kevin

[Mark]

yea i got the semi colon, but now its just saying "there was a problem" when i try to register. 😕

[kevinsequeira]

extra comma at the end of the insert_query

$insert_query = "INSERT INTO HN_users (username, passwd, email) VALUES ('$username', '$passwd', '$email',)";

change to

$insert_query = "INSERT INTO HN_users (username, passwd, email) VALUES ('$username', '$passwd', '$email')";

reg
kevin

[Mark]

thank you so much! 🙂😃

i also have a problem with my login script, can you help me with that?

[Mark]

i think i got it. 🙂

[Mark]

why does it seem to be submitting the password to the database encrypted with md5? or encrypt(), when i dont have that anywhere in the registration code? i dont think...