Incrementing a number by one?

FoxhoundX

Okay, currently I have a script set up, that when you click the button, it will increase the number by one.. This works fine, but if there are too many clicks at once, it will reset back to 0, which is not good. I put a javascript thing so you can only click once per page load, but I want to take this off..

I will include my script, and what i want to know, is if there is a different way to do it.. MySQL perhaps (Need detailed instructions for this 😛)

This is the code for increasing the number by 1:

<?php
$counterfile = './county.txt';
$fcontents = file($counterfile);
$counter = $fcontents[0];
$counter++;
$fp = fopen($counterfile,'w');
fwrite($fp,$counter);
fclose($fp);
?>

Mordecai

What you're looking for, most likely, is flock(). This can stop files from being opened when they're already open. What you're probably doing is opening it with the PHP script, and then executing the PHP script while the file is still open, which can cause errors.
Hope this helps.

FoxhoundX

But if I was to use flock, would it not make it so that if there were say 20 clicks of the button at once, then it would only increase by one?

Mordecai

Well, depending on the speed of the script, it might execute once successfully, or it might execute all 20 times successfully. There really isn't a very fool-proof method, except maybe setting the last time the person submitted it, and then blocking it for a few seconds.

stolzyboy

what kind of crazy script or users are you expecting where peeps are gonna freak out on the submit button and click it 20 times

FoxhoundX

http://clickthebutton.no-ip.com

Check it for yourself :p

stolzyboy

seems to be working fine for me, i was clicking as fast as i could

FoxhoundX

Thats because I made it so only one click can be done per page load...

stolzyboy

so whats the problem

tsinka

The counter seems to be incremented by 2 each time you click on the button. This is because by clicking on the button the form starts to submit and the javascript function also submits the form.

You can remove the javascript code on top of the script and change the submit button to

<input type="button" value="Click The Button!" onClick="this.disabled=true;document.forms.the_form.submit();" style="...">

That should work better (at least it worked when I tested it). I couldn't test if that works with Netscape/Mozilla .. but it should 🙂

FoxhoundX

tsinka - It is still raising by two each click (or most clicks..there a few which raise by one which makes no sense at all) O.o

tsinka

Hi,

I checked the source code. There are two issues:

You merged the javascript into the form tag, put it at the end of your input tag.

Second change the input type from submit to button. That sould solve the problem 🙂