Dead images :(

[zingbats]

I have a code that prints an error if the image URL in the database is blank, or, the link is dead.

This quote is an example of the script.

<table border="1" cellpadding="0" cellspacing="0" style="border-collapse: collapse; border-top-width: 0" width="90%" id="AutoNumber1" bordercolorlight="#FFFF66" bordercolordark="#FFFF66" height="61">
    <tr>
      <td width="100%" bordercolorlight="#FFFF00" bordercolordark="#FFFF66" bordercolor="#FFFF66" style="border-left: 1px solid #FFFF00; border-right-style: solid; border-right-width: 1; border-top: 1px solid #FFFF00; border-bottom-style: solid; border-bottom-width: 1" colspan="3" height="19">
      Clan Details:</td>
    </tr>
    <?php
    /* Connecting, selecting database */
    $link = mysql_connect("localhost", "username", "pwl")
        or die("Could not connect");
    mysql_select_db("tycooneden_com") or die("Could not select database");

$query = "SELECT * FROM clans LIMIT 0,30";
$result = mysql_query($query) or die("Query failed");

 while($foo=mysql_fetch_array($result)){ 
 $clan_url=$foo['clan_url']; 
 $clan_logo=$foo['clan_logo']; 
 $clan_admin=$foo['clan_admin']; 
 $clan_admin_email=$foo['clan_admin_email']; 
 $clan_forum=$foo['clan_forum']; 
 $clan_name=$foo['clan_name']; 
 $clan_logo_height=$foo['clan_logo_height']; 
 $clan_logo_width=$foo['clan_logo_width'];
 $clan_points=$foo['clan_points']; 
?>

   <tr>
      <td width='21%' bordercolorlight='#FFFF66' bordercolordark='#FFFF66' bordercolor='#FFFF66' style='border-left-style: solid; border-left-width: 1; border-right-style: solid; border-right-width: 1; border-top-style: none; border-top-width: medium; border-bottom-style: solid; border-bottom-width: 1' height='18'>
      Site name: <?=$clan_name?></td>
      <td width='79%' colspan='2' bgcolor='#FFFF66' bordercolorlight='#000000' bordercolordark='#000000' height='19'>&nbsp;</td>
    </tr>
    <tr>
      <td width='21%' rowspan='3' bgcolor='#FFFF66' style='border-left-width: 1' bordercolorlight='#000000' bordercolordark='#000000' height='57'>&nbsp;</td>
      <td width='59%' bordercolorlight='#000000' bordercolordark='#000000' height='19'>Site 
      url: <a href="<?=$clan_url?>"><?=$clan_url?></a></td>
      <td width='20%' height='19' bordercolorlight='#000000' bordercolordark='#000000'>Points: <?=$clan_points?></td>
    </tr>
    <tr>
      <td width='79%' colspan='2' bgcolor='#FFFF66' bordercolorlight='#000000' bordercolordark='#000000' height='19'>&nbsp;</td>
    </tr>
    <tr>
      <td width='79%' colspan='2' height='17'>
<?php
if ($clan_logo ==""){ 
$logo_location = "$clan_logo"; 
$fp = @fopen($logo_location,"r"); 
if ($fp == ""){ 
?> 
Sorry, no image has been specified
<?php 
}else{ 
print "Sorry, no picture is avaliable for the clan $clan_name";
} 
@fclose($fp);
} else {
print "<img border='0' src='$clan_logo' width='$clan_logo_width' height='$clan_logo_height'>";
}
?>  

        </td>
    </tr>

    <tr>

  <td width='100%' bgcolor='#6699FF' style='border-left-width: 1' bordercolorlight='#000000' bordercolordark='#000000' height='20' colspan='3'>&nbsp;</td>

</tr>
<?php
}
?>


  </table>

To see the script visit http://www.tycooneden.com/tecc2.php

NB: The "tycooneden" clan doesn't have a logo. Note also, there are dead links, they don't show an error

[Natty_Dreadlock]

I think your code is ok, but i do not understand why u try to open the clan logo if there is none specified in the db:

if ($clan_logo ==""){ 
$logo_location = "$clan_logo"; 
$fp = @fopen($logo_location,"r"); 
if ($fp == ""){ 
?> 
Sorry, no image has been specified
<?php 
}else{ 
print "Sorry, no picture is avaliable for the clan $clan_name";
} 
@fclose($fp);
}

I would do it like this:

if ($clan_logo ==""){ 
?> 
Sorry, no image has been specified
<?php 
}

I do not see the difference between "no image specified" and "no picture avaliable" and moreover, your if-statement checks if $clan_logo is empty but uses it in the following line:

$logo_location = "$clan_logo";

- $logo_location will always be empty

[zingbats]

The point of the script is to eliminate deadlinks as well as checking if a logo URL has been entered into the database.

I follow what you are saying. What would your script actually be though?

Cheers,
Alex

[darkfunkel]

why not just check the headers and do some explode() ing

[zingbats]

What?!