help with code....

toddmarx

greetings once again fellow guru's!

Need some help with a few probs that I am having here. I think I figured out how to make my form post to a database, but there are a few probs that I am having and hopefully someone can take a look at my code and give me a hand. 🙂 I know that it has to be something simple! :rolleyes:

<html>
<head><title>Enter your user information</title><head>
<body>

<form name="user_info" method="post" action="<?php $PHP_SELF ?>">

First Name: <input type="text" name="fname"><BR>
Last Name: <input type="text" name="lname"><BR>
Email address: <input type="text" name="email"><BR>
<input type="submit" name="enter_data" value="Enter Data">
</form>
<?php
// set a variable with the database name
$database_name = "test";

// attempt to connect to database and store result
$dbh = mysql_connect("localhost","root","root");

// check the result of the connection attempt
if (!mysql_select_db($database_name)) {
  echo "Can't Select $database_name";
}

// Conditional test to see if submit button was pressed
if ($enter_data) {

  // build our query string
  $sql = "insert into test (fname, lname, email) 
  values (‘$fname’, ‘$lname’, ‘$email’)";

  // execute a query and store the result
  $res = mysql_query($sql,$dbh);

  // check to make sure the query actually ran
  if (!$res) {
    echo mysql_errno().": ".mysql_error ()."";
    return 0;
  }

  printf("<p>Record successfully added</p>");
}
?>


</body>
</html>

Ok, there are two probs that I am having, the first one is when the page loads for the first time I get this message:

Warning: Undefined variable: enter_data in c:\phpdev\www\computerzonehq\test.php on line 25

When I ignore that one, and proceed, I get this error message:

Forbidden
You don't have permission to access /computerzonehq/ Warning: Undefined variable: PHP_SELF in c:/phpdev/www/computerzonehq/test.php on line 5 on this server.

and it shows up just like I have pasted it here with all the html tags in them.

I have copied and pasted most of this script and customized it to work for me here, atleast I that is my intention.
Any help would be greatly appreciated and I would definately add you to my Christmas Card List!!! 😃

amitrb

add

error_reporting(E_ALL^E_WARNING)
line to top of your script.

Do the same in php.ini for the changes to reflect throughout.

toddmarx

I did and still same thing happens. Here is what I have in my php.ini file:

error_reporting = E_ALL & ~E_NOTICE & ~E_WARNING

amitrb

set

register_globals = On

in your php.ini file

If it doesn't work, let me know your PHP version

dartcol

I don't advise switching globals to on as it can prove to be a security risk. When passing data from a form use $POST['$variablename'];
These act as superglobals and allow you to pass variables between pages without setting globals to on in your php.ini file.
This is the INSERT format I normally use:

$sql = "INSERT INTO tablename (column_name_1, column_name_2)
		VALUES('" . $_POST['variable1'] . "','" . $_POST['variable1'] . "')";
$result = mysql_query($sql) or die(mysql_error());

When you first check for the submit variable $enter_data use:

if(isset($enter_data) {
insert query goes here
} //end if

This should stop the undefined variable message coming up for enter_data. As for the PHP_SELF try using

<?php echo $_SERVER['PHP_SELF'];?>in the action of the form itself.

Finally, leave the error warning set to:
error_reporting = E_ALL; display all errors, warnings and notices
Even with this set like this you shouldn't get any error messages.
Let me know if you need more help.

cahva

Dont turn the register_globals on. You just have to use $SERVER['PHP_SELF'] for the forms action and when retrieving form variables, it depends if you are using POST or GET method to send the form. $POST['variablename'] for post and $_GET['variable'] for get method. Its better to learn to program this way IMHO.

Its better this way and you allways know where some variable came from. Especially in large scripts where there are many variables fetched using POST, GET or SESSION etc.

For example heres a little snippet of your script changed to work with register_globals off...:

....
if ($_POST['enter_data']) {

  // build our query string
 $sql = "insert into test (fname, lname, email)
 values (‘".$_POST['fname']."’, ‘".$_POST['lname']."’, ‘".$_POST['email']."’)";
....

toddmarx

Thank you so much cahava and dartcol!!!!!

I got past all that and now, I have found another problem. The info is NOT posting to the database! I have even fooled around with table names (changed it to a table that does not exsist) and it goes like everything was ok. But when you look at the database (via SQLyog) it still shows the table as empty. 🙁

Seeing how this is getting soooooo frustrating, I can see why you guys/gals that do this for a living make good $ 🙂 Since I have made some changes to the code, here is the updated version:

<html>
<head><title>Enter your user information</title><head>
<body>

<form name="user_info" method="post" action="<?php echo $_SERVER['PHP_SELF'];?>">

First Name: <input type="text" name="fname"><BR>
Last Name: <input type="text" name="lname"><BR>
Email address: <input type="text" name="email"><BR>
<input type="submit" name="enter_data" value="Enter Data">
</form>
<?php
// set a variable with the database name
$database_name = "test";

// attempt to connect to database and store result
$dbh = mysql_connect("localhost","root","root");

// check the result of the connection attempt
if (!mysql_select_db($database_name)) {
  echo "Can't Select $database_name";
}

// Conditional test to see if submit button was pressed

if ($_POST['enter_data']) {

  // build our query string


$sql = "insert into test (fname, lname, email)
 values (‘".$_POST['fname']."’, ‘".$_POST['lname']."’, ‘".$_POST['email']."’)";


  // execute a query and store the result
  $res = mysql_query($sql,$dbh);

  // check to make sure the query actually ran
  if (!$res) {
    echo mysql_errno().": ".mysql_error ()."";
    return 0;
  }

  echo ("<p>Record successfully added</p>");
}
?>


</body>
</html>

Basically what it is, I am WAY over my head here. I have already learned a ton about PHP and mySQL, but I still have about 50 more tons to learn! :eek:

Also, when I tell it to echo the "$_SERVER['PHP_SELF']" There is nothing that gets printed to the screen. Is this normal? And, when you press the submit button, the echo ("Record successfully added"); does not work. I know it has to be something simple, it just HAS to be! lol

noris

ToddMarx

I am not sure what editor you were using. But the single quotes on the following line looks like 'smart quotes' instead of plain single quotes. If you will use a notepad/textpad or some line editor to change them, it should work for you.

$sql = "insert into test (fname, lname, email)
values ('".$POST['fname']."', '".$POST['lname']."', '".$_POST['email']."')";

Let me know how it goes.

noris🆒

toddmarx

Still not working. 🙁

I dont get any error messages, and also I dont get the message that I put in to show that it worked properly. When you hit the submit button, it is just clearing the data, and reloading the page, but NOTHING is going into the database.

dartcol

Hi toddmarx. Humour me here and try this code as is, just substituting your username and password. The rest should work without a problem. 🙂

<?php
// this is your basic connect to database command, for now keep in the same script

$link = @mysql_connect('localhost', 'root', 'root');
if (!$link)
exit();
if (!mysql_select_db('test'))
exit();


// this checks first whether the variable enter_data is present
if (isset($_POST['enter_data'])) {

// then places all the values into an INSERT query called sql
$sql = "INSERT INTO table_name (fname, lname, email)
		VALUES('" . htmlspecialchars(addslashes($_POST['fname'])) . "',
				'" . htmlspecialchars(addslashes($_POST['lname'])) . "',
				'" . htmlspecialchars(addslashes($_POST['email'])) . "')";

// the query sql is then sent to the database or fails
$result = mysql_query($sql) or die(mysql_error());

// we then end the if statement for enter_data
}
?>

<!-- next we send out our form to the browser -->
<form name="linksform" action="<?php echo $_SERVER['PHP_SELF'];?>" method="POST">

<!-- plus the input boxes for the three fields, variables created here -->
URL <input type="text" name="fname" size="32" value="http://">
Description <input type="text" name="lname" size="32">
Email <input type="text" name="email" size="32">

<!-- finally we provide our enter_data variable -->
<input type="submit" name="enter_data" value="Enter Data">
<input type="reset" name="reset" value="reset"></td>
</form>

<?php
// I got this snippet from another person here at phpbuilder
// it checks for values being sent use this code
// if nothing appears then the variables are not being passed
// if they appear but nothing is sent to the database then
// the problem is in your INSERT query - this should have produced
// an error though on the page
reset($_POST);
foreach($_POST as $key => $value){
	print $key . " => " . $value . "<br>\n";
}//end foreach
?>

toddmarx

🙁 nope, got two error messages.

Warning: Variable passed to reset() is not an array or object in c:\phpdev\www\computerzonehq\test2.php on line 47

Warning: Invalid argument supplied for foreach() in c:\phpdev\www\computerzonehq\test2.php on line 48

47 reset($_POST);
48 foreach($_POST as $key => $value){
49     print $key . " => " . $value . "<br>\n";
50 }//end foreach
51 ?>

I just want to take a second here and thank you all for your hard work on this. You guys have no idea how greatly it is appreciated!!😃

toddmarx

My biggest problem is that it is not putting data into the database. I have been all over the net, and other forums and cant seem to spot what is wrong. From what I can see, and from what others have looked at it, the code is right. But it does not submit? But, on another note, on all the ones that say the code is correct, and if you notice there is a command to acknowledge that the data has been entered in successfully, well, that does not show up. It does not say that data was entered into the data base, nor does it say any error messages. I just dont know what else to do. I have just about pulled all my hair out over this one. I am building this site for a friend, and as of now, there are no deadlines, but I would like to finish before any deadlines come up. This is about the only thing keeping me from finishing the site.

It looks like this is an mysql problem maybe? Since the php code is all correct? But then, why dont I get my echo's when everything is complete? Is it a php setting? mysql? Apache? I havent gotta clue.

Frustratingly,
Todd

Ok, I have done some testing. I can go to phpMyAdmin, and sqlYOG, and manually input the info:

The string in php looks like this:

"INSERT INTO employees (first,last,address,position) VALUES ('$first','$last','$address','$position')"

When I input manually (like below) it works just fine.

INSERT INTO employees (first,last,address,position) VALUES ('todd', 'marx', '123 home street', 'dazed and confused');

I dont think any variables are being passed. I have added code to echo all the variables, but nothing comes up. Is this normal when using the "php_self" command?