A Little Help Please...

Radon3k

I'm growing very tired of this project -- that and the fact that it seems like nobody is able to help. Here's the project in a nut shell and I MUST get this done by Wednesday as I've already spent close to 3 weeks on this.

You search for a name and it brings up all the names in the database along with the ID of that name. You can either modify the record or delete the record -- forget deleting it for now. You click modify and it brings up the first part, and it has some information that is in text fields (you can modify that part) and some that is just text that you can't modify. If you don't want to modify anything you just click "Continue" and it brings you to the next part where it does the same thing but for different info. My problem is that my UPDATE query just wiped everything from the table except what you can't modify. Here's the code and please help me get this solved. I'm growing very impatient with this project. Thanks.

<html>
<head>
<title></title>
</head>
<body text="#000000">
To find a record, type a query into the search box:<br>
<form method="post" action="<?php echo("$PHP_SELF")?>">
Family Last Name:<input type="text" name="lname"><br>
<input type="submit" name="subsearch" value="Search"><br><br>
<?php
$db = mysql_connect("localhost", "root", "kaod");
if(!$db) {
	echo("Could not connect to the database server.");
}

mysql_select_db("test", $db);
if(!@mysql_select_db("test")) {
	echo("Could not connect to the database.");
}

if($_POST['subsearch'] == "Search") {
	$search = mysql_query("SELECT * FROM family WHERE PLAST_NM LIKE '%$lname%' GROUP BY PLAST_NM");

$num = mysql_num_rows($search);
if($num > 0) {
	while($row = mysql_fetch_array($search)) {
		$famid = $row['fam_id'];
		$firstname = $row['PFIRST_NM'];
		$lastname = $row['PLAST_NM'];
		$addy = $row['ADDRESS'];
		$city = $row['CITY'];
		$state = $row['STATE'];
		$zip = $row['ZIP'];
		$country = $row['COUNTRY'];

		echo("<table cellpadding='0' cellspacing='0' bgcolor='#CCCCCC' width='400'>");
		echo("<tr><td>");
		echo("<b>ID:</b> $famid<br>");
		echo("<b>Name:</b> $lastname, $firstname<br>");
		echo("<b>Address:</b> $addy<br>");
		echo("<b>City:</b> $city<br>");
		echo("<b>State:</b> $state<br>");
		echo("<b>Zip:</b> $zip<br>");
		echo("<b>Country:</b> $country<br>");
		echo("</td></tr>");
		echo("<tr><td align='center'>");
		echo("<a href='sql.php?action=modify&id=$famid'>Modify</a> &nbsp;");
		echo("<a href='sql.php?action=delete&id=$famid'>Delete</a><br>");
		echo("</td></tr>");
	}
}
}

if($_GET['action'] == "modify") {
	$getidf = "SELECT * FROM family WHERE `fam_id` = '$id'" or die(mysql_error());
	$queryf = mysql_query($getidf);
	while($rowf = mysql_fetch_array($queryf)) {
        $famidf = $rowf['fam_id'];
        $fnamef = $rowf['PFIRST_NM'];
        $lnamef = $rowf['PLAST_NM'];
		$addyf = $rowf['ADDRESS'];
		$cityf = $rowf['CITY'];
		$statef = $rowf['STATE'];
		$zipf = $rowf['ZIP'];
		$phonef = $rowf['P_PHONE'];
		echo("<form method='post' action='sql.php'>");
		echo("<table border=0 cellpadding=0 cellspacing=0 bgcolor='#CCCCCC' width='400'>");
		echo("<tr><td align='center' valign='middle'>");
		echo("<b>Family Table</b>");
		echo("</td></tr>");
		echo("<tr><td>");
		echo("<b>Family ID:</b> $famidf<br>");
		echo("<b>Name:</b> $fnamef $lnamef<br>");
		echo("<b>Address:</b> <input type='text' name='famaddy' value='$addyf'><br>");	
		echo("<b>City:</b> <input type='text' name='famcity' value='$cityf'><br>");
		echo("<b>State:</b> <input type='text' name='famstate' value='$statef'><br>");
		echo("<b>Zip:</b> <input type='text' name='famzip' value='$zipf'><br>");
		echo("<b>Phone:</b> <input type='text' name='famphone' value='$phonef'><br>");
		echo("</td></tr></table>");
		echo("<br><br>");
		echo("<input type='submit' name='subfam' value='Continue'>");
	}
}

if($_POST['subfam'] == "Continue") {
	$updatefam = mysql_query("UPDATE family SET
					ADDRESS = '$addyf',
					CITY = '$cityf',
					STATE = '$statef',
					ZIP = '$zipf',
					P_PHONE = '$phonef' WHERE `fam_id` = '$id'");

if($updatefam) {
	echo("Updated");
} else {
	echo("Error");
}
}
?>

matt_4013

$updatefam = mysql_query("UPDATE family SET

                ADDRESS = '$addyf',

                CITY = '$cityf',

                STATE = '$statef',

                ZIP = '$zipf',

                P_PHONE = '$phonef' WHERE `fam_id` = '$id'");

It doesn't look like these variables are being set anywhere, so I assume they're coming from a form. Try this:

$sql  = "UPDATE family SET ADDRESS = '".$_POST['addyf']."', ";
$sql .= "CITY = '".$_POST['cityf']."', ";
$sql .= "STATE = '".$_POST['statef']."', ";
$sql .= "ZIP = '".$_POST['zipf']."', ";
$sql .= "P_PHONE = '".$_POST['phonef']."' ";
$sql .= "WHERE `fam_id` = '".$_POST['id']."'";

$updatefam = mysql_query($sql) or die(mysql_error());

Radon3k

That did not work. It does echo the word "Updated" like I told it to if the query was OK but the record itself was not updated.

matt_4013

Well, what you need to do is debug your sql, see exactly what's being sent to the database. That's why i put it in a variable like that. If you put that code in, and then somewhere below the $sql = line you put echo "<hr />$sql<hr />"; you should see a query, exactly as it's being sent to the database. That way you can see where the error is in your query.

Radon3k

It echo's this:

UPDATE family SET ADDRESS = '', CITY = '', STATE = '', ZIP = '', P_PHONE = '' WHERE fam_id = ''

Mordecai

It's not recognizing the variables. Where is it getting $addyf, $cityf, etc. ?

pskZero7

Hey radon, there is a BIG mistake in your code. check this:

Here is your original code:


    //Here for example : 
    echo("<b>Address:</b> <input type='text' name='famaddy' value='$addyf'><br>");  // Your input's called "famaddy", NOT "addyf" ....
    echo("<b>City:</b> <input type='text' name='famcity' value='$cityf'><br>");
    echo("<b>State:</b> <input type='text' name='famstate' value='$statef'><br>");
    echo("<b>Zip:</b> <input type='text' name='famzip' value='$zipf'><br>");
    echo("<b>Phone:</b> <input type='text' name='famphone' value='$phonef'><br>");
    echo("</td></tr></table>");
    echo("<br><br>");
    echo("<input type='submit' name='subfam' value='Continue'>");
}
}

if($_POST['subfam'] == "Continue") {


// ... So here, you should use the name of your input,
// that is to say "famaddy" !!!!!!!
// The variable "addyf" is not set in this section of code !!!
$updatefam = mysql_query("UPDATE family SET
                ADDRESS = '$addyf',
                CITY = '$cityf',
                STATE = '$statef',
                ZIP = '$zipf',
                P_PHONE = '$phonef' WHERE `fam_id` = '$id'");

Here is the right snip of code, try it:


    echo("<b>Address:</b> <input type='text' name='famaddy' value='$addyf'><br>");    
    echo("<b>City:</b> <input type='text' name='famcity' value='$cityf'><br>");
    echo("<b>State:</b> <input type='text' name='famstate' value='$statef'><br>");
    echo("<b>Zip:</b> <input type='text' name='famzip' value='$zipf'><br>");
    echo("<b>Phone:</b> <input type='text' name='famphone' value='$phonef'><br>");
    echo("</td></tr></table>");
    echo("<br><br>");
    echo("<input type='submit' name='subfam' value='Continue'>");
}
}

if($_POST['subfam'] == "Continue") {
    $updatefam = mysql_query("UPDATE family SET
                    ADDRESS = '$famaddy,
                    CITY = '$famcity',
                    STATE = '$famstate',
                    ZIP = '$famzip',
                    P_PHONE = '$famphone' WHERE `fam_id` = '$id'");

May the force be with you 😉

Radon3k

It's still not working! I click the Continue button and it doesn't update anything although it does retain the original information even when I changed it. Why?!?!?!

Radon3k

Ok now I'm not annoyed, I'm just flat out pissed. This is NOT working and I've done everything that I know how. It says it was updated so when I go back to check on it everything is STILL the SAME. HOW do I get this to update???

ScubaDvr2

Look bro,

If you echo the sql line and every value returns NULL, then there is 1 simple problem:
Your variables are not being defined anywhere.

If you don't define your variables, then it is doing exactly what it should be doing, replacing all the fields in your db with NULL.

Thanks

Radon3k

The variables are being replaced. I used the code that pskZero7 gave me and it's still not working. What else do I need to change for it to work?

pskZero7

Don't know if it will be helpful but try using the $_GET['xxx'] variables instead of $xxx, maybe your php.ini isn't properly configured.
Please paste here a dunmp of your database (at least it's structure) so that we can help you...

pskZero7

Oh oh oh,
I think I've just found the problem, I did not noticed the first time, but your "$id" variable is not set in your UPDATE query string...
Remember, this variable has been defined in your first section as a GET variable by that line :

echo("<a href='sql.php?action=modify&id=$famid'>Modify</a> &nbsp;");

.
But in the others parts of code, it's NOT defined anymore, so all you have to do is to add a hidden input in your modification form. Here is the (very) right code 😉

     // Here, add a hidden input called "id" an with the value $id ....
     echo "<input type=hidden value='$id' name='id'>";   

            echo("<b>Address:</b> <input type='text' name='famaddy' value='$addyf'><br>");    

        echo("<b>City:</b> <input type='text' name='famcity' value='$cityf'><br>");
        echo("<b>State:</b> <input type='text' name='famstate' value='$statef'><br>");
        echo("<b>Zip:</b> <input type='text' name='famzip' value='$zipf'><br>");
        echo("<b>Phone:</b> <input type='text' name='famphone' value='$phonef'><br>");
        echo("</td></tr></table>");
        echo("<br><br>");
        echo("<input type='submit' name='subfam' value='Continue'>");
    }
}

print_r($_GET);
print_r($_POST);

if($_POST['subfam'] == "Continue") {
    $updatefam = mysql_query("UPDATE family SET
                    ADDRESS = '$famaddy,
                    CITY = '$famcity',
                    STATE = '$famstate',
                    ZIP = '$famzip',
                    P_PHONE = '$famphone' WHERE `fam_id` = '$id'"); // ... So that here we can retrieve its value !

Hope it will work 🙂

Radon3k

Hi,

THANK YOU! I had the WHERE fam_id = '$id' already but I didn't have the hidden input field. Could you please explain to me why that bit was necessary and what it did? Thanks again!

pskZero7

Hi radon!
Sorry for not having answered your question before, unfortunately I also have to work, you know... 🙂

The hidden input field was necessary because:

When you click on the "modify" link, you pass the record id as a $GET variable. So the record id ($id) IS defined in the section of code where you create the input field, but not in the section of code where you update your record (because $POST['subfam'] != "Continue").

Then you click on the submit input, now all the inputs' values are POSTED to the form action url (in your case it's the same page) nothing else is posted, so if you do not add an input field with the record id, it will NOT be sent to the form action url...

I hope it's clear enougn, if you have any question feel absolutely free to ask 😉

PS:same answer emailed to radon3k