pop ups

laserw

Hi,

I have tried to make the following code work but I can't seem to see the error. Can someone help me?

<SCRIPT LANGUAGE="JavaScript">
<!--
function MM_openBrWindow(theURL,winName,features) { //v2.0
window.open(theURL,winName,features);
}

// -->
</SCRIPT>

other html code...............

// this is the problem php code
if ( (ltrim($row["fn18"]) == '') )
print ("<td> </td>\n");
else
printf ("<td><a href='#' onClick=\"MM_openBrWindow(\'pics/",
. $row["fn18"] . ,"\',\'\',\'width=650,
height=650\') ">Pics</a></td>\n");

// I am trying to create a link to a pop up but I keep getting either parse or other errors.

// this html code works outside of php
// <a href="#" onClick="MM_openBrWindow'show/pics.html','','width=650,
height=650')">Pics</a>

Thanks!

kevinsequeira

<?php
if ( (ltrim($row["fn18"]) == '') )
print ("<td> </td>\n");
else
?>
<td><a href='#' onClick="MM_openBrWindow('pics/<?php print($row["fn18"]);?>','','width=650,
height=650')">Pics</a></td>\n");

reg
kevin

laserw

Hi Kevin,

Thank you for replying. The problem is in the code and not the start and stopping of php.
I didn't include all the code because I didn't think it was necessary.
The lines that I included are just snippets.
The actual problem is somewhere in the php code.

Thanks.

Mordecai

Your error is on this line:

printf ("<td><a href='#' onClick=\"MM_openBrWindow('pics/", 
. $row["fn18"] . ,"','','width=650, 
height=650') ">Pics</a></td>\n");

I fail to see why this is in printf, because you don't format it at all. I suggest just using echo. You also have seeral unescaped quotes and periods that don't concatenate anything.
Here is a fixed version, using echo:
echo("<td><a href='#' onClick=\"MM_openBrWindow('pics/".$row["fn18"]."','','width=650, height=650')\">Pics</a></td>\n");

laserw

Hi, thank you for responding. Because I am using the following javascript. I am getting a parse error from the php code.
I am encoding the javascript in the upper area with some regular html code and in the middle of that I am coding my php.

<SCRIPT LANGUAGE="JavaScript">
<!--
function MM_openBrWindow(theURL,winName,features) { //v2.0
window.open(theURL,winName,features);
}

// -->
</SCRIPT>

other html code...............

some php code................

I have just tried the following as well as your variation.

echo ("<td><a href='#' onClick=\'MM_openBrWindow('pics/",
. $row["fn18"] .
," ',' ','width=650,height=650') ">Pics</a></td>\n");

I still can't find which s/d quote is causing the problem.
Whether I use printf or echo it still does not work.

Thanks!