Help with a Login script

af831

I'm having some trouble with some code I'm hopeing someone here can help me with....

what I'm trying to do is create a script that will enable users to my site log in from a single login page to one of three programs depending on what they choose.....

I know I'm missing something... and I think that the problem is that the var $program won't be filled untill after the page is submitted.... but at the same time I'm trying to make it so that users only have to hit the submit button once through this whole process...

a sample of what I've got so far can be found at http://24.68.189.187/~beta/php/login.test.php

the code I'm working with is the following.... (I know I don't have the post address for if $program = 'mb'; yet... but ... I'm working on getting it... if anyone knowes the answer to that to it would be very helpful to me...I'm using phpbb for the forums)

<html>
<head><title>Login Test</title>
</head>


<BODY>
<body text="red" link="#FFFF66" alink="#FF6600" vlink="#0099CC" bgcolor="#000000"
background="/images/www/rh/bg_red-marble1.jpg">
<center>
<table>
<form name="login" method="post" action="<? if ($program = 'catalog') { ?>
../catalog/login.php?action=process<? } elseif ($program = 'chat') {
?>../chat2.cgi<? } ?>">

<tr>
<td align="center" class="infoBoxContents">Email Address:</td>
<td align="center" class="infoBoxContents">
<input type="text" name="$username" maxlength="96" size="19" value="">
</td>
</tr>
<tr>
<td align="center" class="infoBoxContents"> Password:</td>
<td align="center" class="infoBoxContents">
<input type="password" name="password" maxlength="40" size="19" value="">
</td>
</tr>
</table>
<input type=radio name="$program" value="catalog">Catalog
<input type=radio name="$program" value="chat">Chat
<input type=radio name="$program" value="mb">RH Forums
<INPUT TYPE=hidden NAME="action" VALUE="login">
<input type="submit" value="Sign In" title=" Sign In " SSL>
</form>
</center>
</body>
</html>

Thank you all for your time and effort...
and I appreciate all replys

kevinsequeira

this should give you an idea of how to go about writing the code,

<BODY>
<body text="red" link="#FFFF66" alink="#FF6600" vlink="#0099CC" bgcolor="#000000"
background="/images/www/rh/bg_red-marble1.jpg">
<center>
<table>
<form name="login" method="post" action="login_action.php">
<tr>
<td align="center" class="infoBoxContents">Email Address:</td>
<td align="center" class="infoBoxContents">
<input type="text" name="username" maxlength="96" size="19" value="">
</td>
</tr>
<tr>
<td align="center" class="infoBoxContents"> Password:</td>
<td align="center" class="infoBoxContents">
<input type="password" name="password" maxlength="40" size="19" value="">
</td>
</tr>
</table>
<input type=radio name="program" value="catalog">Catalog
<input type=radio name="program" value="chat">Chat
<input type=radio name="program" value="mb">RH Forums
<INPUT TYPE=hidden NAME="action" VALUE="login">
<input type="submit" value="Sign In" title=" Sign In " SSL>
</form>
</center>
</body>
</html>

on login_action.php

<? if ($_POST['program'] == "chat") { 
    header("location:/chat2.cgi");
   }else{
   	echo $_POST['username'];
   	echo $_POST['password'];	
	// do whatever else you need to do
   }	
?>

reg
kevin

DigitalExpl0it

not sure if this is what your looking for but here is some modified code example

<?
function form($username, $password, $program, $action) {
if ($program == "catelog") {
	$selection = "selected";
} elseif($program == "chat") {
	$selection = "selected";
} elseif ($program == "mb") {
	$selection = "selected";
}

?>
<form name="login" method="post" action="<? echo $PHP_SELF; ?>">
<tr>
<td align="center" class="infoBoxContents">Email Address:</td>
<td align="center" class="infoBoxContents">
<input type="text" name="username" maxlength="96" size="19" value="<? echo $username; ?>">
</td>
</tr>
<tr>
<td align="center" class="infoBoxContents"> Password:</td>
<td align="center" class="infoBoxContents">
<input type="password" name="password" maxlength="40" size="19" value="<? echo $password; ?>">
</td>
</tr>
</table>
<input type=radio name="program" value="catalog" <? echo $selection; ?>>Catalog
<input type=radio name="program" value="chat" <? echo $selection; ?>>Chat
<input type=radio name="program" value="mb" <? echo $selection; ?>>RH Forums
<INPUT TYPE=hidden NAME="action" VALUE="login">
<input type="submit" name="Submit" value="Sign In" title=" Sign In " SSL>
</form>
<?
}
?>
<html>
<head><title>Login Test</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"></head>
<BODY bgcolor="#000000" text="#FF0000" link="#FFFF66" vlink="#0099CC" alink="#FF6600">
<center>
<table>
<?
/*if ($program == "catalog") {
	$formvar = "../catalog/login.php?action=process";
} elseif ($program == "chat") {
	$formvar = "../chat2.cgi";
}*/

//check to see if user has pressed the Submit button
if ($_REQUEST["Submit"] == "Sign In") {
	//do some checks
	if ($_REQUEST["username"] == "" || $_REQUEST["password"] == "") {
		echo "<b>Sorry one or more fields left blank!</b><br><br>";
		form($_REQUEST["username"], $_REQUEST["password"], $_REQUEST["program"], $_REQUEST["action"]);
		return;
	}
//Start Main page here (after you hit submit)
echo "You have made it to the main page welcome, ".$_REQUEST["username"];
return;
}

//load form
form($_REQUEST["username"], $_REQUEST["password"], $_REQUEST["program"], $_REQUEST["action"]);
?>
</center>
</body>
</html>

af831

First of all ... I'd like to say thank you for the replys I've gotten so far.... I think the basic idea was gotten accross from the two replys I've recived... however I'm finding that neither works just right in that tho both sets of code start off the code the way I want them to... neither seems to have the ability to be able to accually get me logged into the required program.... nor do they seem to want to post the code properly to the pages and seem to give me an error each time no matter what the configuration I use.... (the errors are always invalid username and password)

the part that I'm baffled by is the fact that when I run the code having it set to only be able to post to the one page.... (as an HTML page only) it seems to work perfectly.... the problem seems to come in when I try to set it so that the user has a choice as to what program they want to log into.... the purpose of this code was to create a simplistic way for users to log into any of the three programs from the main page from a single form... with out having to go to the program first and then log in from there.... another major reason for my doing this is that I'm in the midst of working on merging my database for the three programs in order to create a single login setup site wide rather than forcing visitors to the site to create 3 different login's just to be able to use the site to it's fullest....

any other ideas as to what I might be able to do in order to get the pages that the form is being submitted to to accept the usernames and passwords... as it's seeming to me that the reason they're not doing this has something to do with the way the information is being posted to them.....

Thank you again for you time....

af831

well... after some tinkering... I was able to get a little bit further.... but not much.... by using the following code I was able to get everything done on one page.... but still each page I try to go to it tells me "Error: invalid username/password" .....

any ideas?

<BODY>
<body text="red" link="#FFFF66" alink="#FF6600" vlink="#0099CC" bgcolor="#000000"
background="/images/www/rh/bg_red-marble1.jpg">
<center>

<?
if ($_POST['program'] == "chat") {
    header("location:../chat2.cgi?action=login");
   }
elseif ($_POST['program'] == "catalog") {
    header("location:../catalog/login.php?action=process");
   }
else {

   echo $_POST['username'];
   echo $_POST['password'];
?>


<table>
<form name="login" method="post" action="<? echo $PHP_SELF ?>">
<tr>
<td align="center" class="infoBoxContents">Email Address:</td>
<td align="center" class="infoBoxContents">
<input type="text" name="username" maxlength="96" size="19" value="">
</td>
</tr>
<tr>
<td align="center" class="infoBoxContents"> Password:</td>
<td align="center" class="infoBoxContents">
<input type="password" name="user_password" maxlength="40" size="19" value="">
</td>
</tr>
</table>
<input type=radio name="program" value="catalog">Catalog
<input type=radio name="program" value="chat">Chat
<input type=radio name="program" value="mb">RH Forums
<INPUT TYPE=hidden NAME="action" VALUE="login"><!-- this line
 needed so the chat program doesn't need to be directed to 
?action=login ... but rather does it on it's own -->
<br>
<input type="submit" value="Sign In" title=" Sign In " SSL>
</form>

<? } ?>

</center>
</body>
</html>

*Note:

I tried the other script that was posted.... but it wouldn't get me any further than telling me that I had filled in all the required fields
and would not redirect me or post to any of the optins I had attempted to choose.... and upon removing the commenting of the one section... it wouldn't even load for me the page due to an error in the php code....

Thank you again for your time and effort in helping me with this....

af831

ok.... after some more work on this.... I was able to get this copy of the above post to work.... but again it wouldn't let me accually log in because of an error with the userna/password .... and after having been told that it's a username/password issue by the programs so many times.... I went back over to them and tried loggin in at the programs themselves.... using exactly the same information as what I used on this (and the other) bit of code.... and got in just fine... so once again I'm led to belive that it must be that the login script doesn't want to post the username or password correctly.....

<?
function form($username, $password, $program) {
if ($program == "catelog") {
    $selection = "selected";
} elseif($program == "chat") {
    $selection = "selected";
} elseif ($program == "mb") {
    $selection = "selected";
}

?>
<form name="login" method="post" action="<? echo $PHP_SELF; ?>">
<tr>
<td align="center" class="infoBoxContents">Email Address:</td>
<td align="center" class="infoBoxContents">
<input type="text" name="username" maxlength="96" size="19" value="<? echo
$username; ?>">
</td>
</tr>
<tr>
<td align="center" class="infoBoxContents"> Password:</td>
<td align="center" class="infoBoxContents">
<input type="password" name="password" maxlength="40" size="19" value="<? echo
$password; ?>">
</td>
</tr>
</table>
<input type=radio name="program" value="catalog" <? echo $selection; ?>>Catalog
<input type=radio name="program" value="chat" <? echo $selection; ?>>Chat
<input type=radio name="program" value="mb" <? echo $selection; ?>>RH Forums
<br>
<input type="submit" name="Submit" value="Sign In" title=" Sign In " SSL>
</form>
<?
}
?>
<html>
<head><title>Login Test</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"></head>
<BODY bgcolor="#000000" text="#FF0000" link="#FFFF66" vlink="#0099CC"
alink="#FF6600">
<center>
<table>
<?
/*if ($program == "catalog") {
    $formvar = "../catalog/login.php?action=process";
} elseif ($program == "chat") {
    $formvar = "../chat2.cgi";
}*/

//check to see if user has pressed the Submit button
if ($_REQUEST["Submit"] == "Sign In") {
    //do some checks
    if ($_REQUEST["username"] == "" || $_REQUEST["password"] == "") {
        echo "<b>Sorry one or more fields left blank!</b><br><br>";
        form($_REQUEST["username"], $_REQUEST["password"], $_REQUEST["program"]);
        return;
    }
//Start Main page here (after you hit submit)
echo "You have made it to the main page welcome, ".$_REQUEST["username"];

if ($_POST['program'] == "chat") {
    header("location:../chat2.cgi?action=login");
   }
elseif ($_POST['program'] == "catalog") {
    header("location:../catalog/login.php?action=process");
   }
return;
}

//load form
form($_REQUEST["username"], $_REQUEST["password"], $_REQUEST["program"]);
?>
</center>
</body>
</html>

af831

I don't know what the policy is here on bumping topics.... but it's been over 10 hours or so ... so I figured it'd be ok....

bump....

af831

any body? .... I could really use the help....

Weedpacket

I see one or two problems:
(1) You can't go sending anything to the client if you're planning on sending a header later.

(2) If I understand you right, the programs themselves have logins, in which case you need to be sending the login details to those programs in some way (they don't have access to data posted to PHP). Just how that's achieved depends on the program in question: it may actually be simpler to just have a selection of programs on this page and have redirects to the programs which then do their own logging in.

batman

What you mite want to try is this: make it a three page scenario. You can leave your login page, but as weedpacket had said, you can't have any html above any headers. First page will be your login page. second page will do all the checking and verifying. On the second page have it check to see if both fields were filled out and filled out correctly. If not then send error with an include of the login page. If it approves then send the username and password to a session long enough for the desired program to log them in. The second page will be the most complicated of the three. On the second page you will have to do some sql querys from the table that stores the programs members for the desired program to check the username and password.

If this is confusing let me know.

-Blake

af831

ummmm.... ok.... I guess first of all... I'm rather confused about/by what was being sugguested to me in the last two posts.... what I'm trying to do basically is merge the following two pages that work into one that works....

Working Chat Login Script:

<html>
<head><title>Login Test</title>
</head>

<BODY>
<body text="red" link="#FFFF66" alink="#FF6600" vlink="#0099CC" bgcolor="#000000"
background="/images/www/rh/bg_red-marble1.jpg">
<center>

<table>
<form name="login" method="post" action="../chat2.cgi">

<tr>
<td align="center" class="infoBoxContents">Email Address:</td>
<td align="center" class="infoBoxContents">
<input type="text" name="$username" maxlength="96" size="19" value="<?
echo $username ?>">
</td>
</tr>
<tr>
<td align="center" class="infoBoxContents"> Password:</td>
<td align="center" class="infoBoxContents">
<input type="password" name="password" maxlength="40" size="19" value="">
</td>
</tr>
</table>
<INPUT TYPE=hidden NAME="action" VALUE="login">
<input type="submit" value="Sign In" title=" Sign In " SSL>
</form>
</center>
</body>
</html>

Working Catalog login script:


<html>
<head><title>Login Test</title>
</head>

<BODY>
<body text="red" link="#FFFF66" alink="#FF6600" vlink="#0099CC" bgcolor="#000000"
background="/images/www/rh/bg_red-marble1.jpg">
<center>

<table>
<form name="login" method="post" action="../catalog/login.php?action=process">

<tr>
<td align="center" class="infoBoxContents">Email Address:</td>
<td align="center" class="infoBoxContents">
<input type="text" name="$username" maxlength="96" size="19" value="<?
echo $username ?>">
</td>
</tr>
<tr>
<td align="center" class="infoBoxContents"> Password:</td>
<td align="center" class="infoBoxContents">
<input type="password" name="password" maxlength="40" size="19" value="">
</td>
</tr>
</table>
<input type="submit" value="Sign In" title=" Sign In " SSL>
</form>
</center>
</body>
</html>

What I've done to try to merge the two of these login scripts and set things up so that they'll be ready when I'm ready for the third script to work...

<html>
<head><title>Login Test</title>
</head>

<BODY>
<body text="red" link="#FFFF66" alink="#FF6600" vlink="#0099CC" bgcolor="#000000"
background="/images/www/rh/bg_red-marble1.jpg">
<center>
<form method=post action="<?echo $PHP_SELF ?>">
<input type=radio name="$program" value="catalog">Catalog
<input type=radio name="$program" value="chat">Chat
<input type=radio name="$program" value="mb">RH Forums
<INPUT TYPE="submit" value="Choose Program">
</form>

<table>
<form name="login" method="post" action="<? if ($program = 'catalog') { ?>
../catalog/login.php?action=process<? } elseif ($program = 'chat') {
?>../chat2.cgi<? }  ?>">

<tr>
<td align="center" class="infoBoxContents">Email Address:</td>
<td align="center" class="infoBoxContents">
<input type="text" name="$username" maxlength="96" size="19" value="<?
echo $username ?>">
</td>
</tr>
<tr>
<td align="center" class="infoBoxContents"> Password:</td>
<td align="center" class="infoBoxContents">
<input type="password" name="password" maxlength="40" size="19" value="">
</td>
</tr>
</table>
<INPUT TYPE=hidden NAME="action" VALUE="login">
<input type="submit" value="Sign In" title=" Sign In " SSL>
</form>
</center>
</body>
</html>

everything else as far as seeing if the accounts and passwords match up or if the user is banned or anything else like that the programs take care of themselves .... I'm just trying to get a simple way to get the information to the programs so that people can log in directly from main page and upon doing so go right into what they need to to use the programs... with out having to navigate themselves over to the page and then log in... and then do what they need to do....

batman

There are a couple of problems I found in this part:

<form name="login" method="post" action="<? if ($program = 'catalog') { ?>
../catalog/login.php?action=process<? } elseif ($program = 'chat') {
?>../chat2.cgi<? }  ?>">

First you can't have only one = it has to be two ==. Change the above section to this:

<form name="login" method="post" action="<? if ($program == "catalog") {echo"../catalog/login.php?action=process";} else{echo"../chat2.cgi";} ?>">

Let me know if that works.

-Blake

af831

First of all Blake... I would like to say a BIG thank you.... tho it's not all working perfectly yet.... what you posted is a huge step in the right direction..... it now is atleast letting me log into one of the three programs.... (I know I don't have the path to the forum yet.... and I don't expect it to get me there with out one.... so I'm not worried about that right now... ) however for right now with the following code it's only letting me log into the chat program no matter what I choose.... (I also realize that there where a couple differences between this set of code and what I had posted last... there where a couple errors within the code that I cought that are making it run a little bit better now.... )

this is what the code is looking like right now ....

<html>
<head><title>Login Test</title>
</head>

<BODY>
<body text="red" link="#FFFF66" alink="#FF6600" vlink="#0099CC" bgcolor="#000000"
background="/images/www/rh/bg_red-marble1.jpg">
<center>

<table>
<form name="login" method="post" action="<? if ($program == 'catalog') {echo"../catalog/login.php?action=process";}
else{echo"../chat2.cgi";} ?>">

<tr>
<td align="center" class="infoBoxContents">Email Address:</td>
<td align="center" class="infoBoxContents">
<input type="text" name="username" maxlength="96" size="19" value="">
</td>
</tr>
<tr>
<td align="center" class="infoBoxContents"> Password:</td>
<td align="center" class="infoBoxContents">
<input type="password" name="user_password" maxlength="40" size="19" value="">
</td>
</tr>
</table>
<input type=radio name="program" value="catalog">Catalog
<input type=radio name="program" value="chat">Chat
<input type=radio name="program" value="mb">RH Forums
<INPUT TYPE=hidden NAME="action" VALUE="login"><br>
<input type="submit" value="Sign In" title=" Sign In " SSL>
</form>
</center>
</body>
</html>

Thanks again for your time and effort

batman

Where your talking about the form action and it says if($program == 'catalog'). Try changing the ' to ". So new code will be as follows.

<? if ($program == "catalog") {echo"../catalog/login.php?action=process";}
else{echo"../chat2.cgi";} ?>

Tell me what that does for you.

-Blake

af831

it does the same thing... and I think the reason why could be that it hasn't set the var $program untill the page is posted.... so it sends the information to the chat page regardless of what $program is set to after "Sign In" is hit.... I'm not sure about that.... but I was just thinking that it would possibly make the most sense because of the way everything is acting regardless of the change in code....

batman

Yes, that's what's hapening. It is trying to call an undefined variable. There are multiple ways around this, which do you prefer?

1). make two different forms on the page with each ones action pointing to the corespondent login page. (Easiest way)

2). Make another page that goes inbetween the home page and the login pages of the programs. (Best way)

3). Like the first one but only have one form they type the info then have them click on a button if they want the catalog, or click the button if they want the chat.

Choose which way you want to go. I prefer the second one myself. If you need help setting it up let me know.

-Blake

af831

if I'm understanding you correctly.... the second option would keep the one page the way it is.... and from there have it post to a second page that decided what program it was suposed to log the user into (with no user interaction required on the second page) and then into the program that they want to be in with only having to hit the sign in button once.... is that right?

and on the third option it would be the same form... with the exception that rather than having three radio buttons... it would have three submit buttons (one for each program)

(the first option if I understand it wouldn't be an option as from what I understand of what you where saying is that it would have basically the same form on the site 3 times , one for each program, and then depending on which one they filled out would be the program they where logged into .... right?)

if it would be possible at all.... would I be able to see the code for the second and third options as you sugguested? .... if it's not to much trouble for you that is....

Thank you again
~af831

batman

For option 2 what you want to do is set up the login page like this:

<html>
<head><title>Login Test</title>
</head>

<BODY>
<body text="red" link="#FFFF66" alink="#FF6600" vlink="#0099CC" bgcolor="#000000"
background="/images/www/rh/bg_red-marble1.jpg">
<center>

<table>
<form name="login" method="post" action="check.php">

<tr>
<td align="center" class="infoBoxContents">Email Address:</td>
<td align="center" class="infoBoxContents">
<input type="text" name="username" maxlength="96" size="19" value="">
</td>
</tr>
<tr>
<td align="center" class="infoBoxContents"> Password:</td>
<td align="center" class="infoBoxContents">
<input type="password" name="user_password" maxlength="40" size="19" value="">
</td>
</tr>
</table>
<input type=radio name="program" value="catalog">Catalog
<input type=radio name="program" value="chat">Chat
<input type=radio name="program" value="mb">RH Forums
<INPUT TYPE=hidden NAME="action" VALUE="login"><br>
<input type="submit" value="Sign In" title=" Sign In " SSL>
</form>
</center>
</body>
</html>

For the check.php page do something like this:

<?

$user_password = $_POST["user_password"];
$username = $_POST["username"];
$program = $_POST["program"];

if(!$username)
{
echo"Please provide a username in order to be logged in!";
exit();
}

if(!$user_password)
{
echo"Please provide a password in order to be logged in!";
exit();
}

if((!$user_password) || (!$username))
{
echo"Please provide a username and password in order to be logged in!";
exit();
}

session_register('username');
$_SESSION['username'] = $username;

session_register('user_password');
$_SESSION['user_password'] = $user_password;

if($program == "chat")
{
header("location:/chat2.cgi");
}

if($program == "catalog")
{
header("location:/catalog/login.php?action=process");
}


?>

Try that out and tell me what you get.

-Blake

af831

ok.... I tried the scripts that you posted.... but the check.php script seems to have a problem with it in that even tho it's there.... after I submit the form... it sends me to check.php which gives me a 404 error... which I thought was weird as I'd refreshed the login.test.php page... and found it to be the updated code.... so I hit refresh while at the check.php page... and even tho it started out saying that it was a 404 error... after hitting refresh it told me that I needed to supply a username... (which I had as well as a password and slected the program)

you can test this if you would like at http://24.68.189.187/~beta/php/login.test.php

and if you use (it's a valid account and does work on the page http://24.68.189.187/~beta/php/login.test.chat.php )

username: test2
password: test
program: chat

you'll see what I'm talking about ....

I'm sorry to say but for right now I haven't set up a test account for the catalog in the beta section....

batman

Ok, what it's doing is this: the check.php page works just fine. You will notice on the check.php page that there are some header links. I believe that these are pointing in the wrong directory.

Use this code for the new check.php page:

<?

$user_password = $_POST["user_password"];
$username = $_POST["username"];
$program = $_POST["program"];

if((!$user_password) || (!$username))
{
echo"You did not submit the following required information!";
{
if(!$username)
{
echo"Please provide a username in order to be logged in!";

}

if(!$user_password)
{
echo"Please provide a password in order to be logged in!";

}
include"login.test.php";
exit();
}


if($program == "chat")
{
header("location:[url]http://24.68.189.187/~beta/chat2.cgi[/url]");
}

if($program == "catalog")
{
header("location:/catalog/login.php?action=process");
}

session_register('username');
$_SESSION['username'] = $username;

session_register('user_password');
$_SESSION['user_password'] = $user_password;


?>

-Blake