Stumped on one piece of code

clarkm

Hi All,

I have been trying to solve this puzzle all day and just can not see what to do.

My SQL statement below produces what I want, and I am able to create my HTML table
exactly as I want with one problem. I have option menus, but can not figure out how
to get the </option> to appear only after the last selection.

Here is my SQL statement which is fine, and produces this from the command line:

SELECT license_main.title, license_options.option_code, license_options.option_title,
license_price.price, license_main.license_id, license_main.text_id
FROM license_main, license_options, license_price, track_descriptions
WHERE license_main.license_id = license_options.license_id
AND license_options.option_id = license_price.option_id
AND track_descriptions.record_id = '106'
AND license_price.price_class = track_descriptions.price_class
ORDER BY license_main.sort, license_options.sort

So far so good, now I want to make a table in HTML as such,
will use first 2 results for example (The None value is hard coded):

<tr><td>Corporate & Trade Shows</td><td><option value=>None
<option value= BIZ1>Single Use - $27.50
<option value= BIZ2>Unlimited - $55.00
</option></td></tr>

I am fine up to </option></td></tr>, which is where I am getting into trouble.

To display Corporate & Trade Shows only once in the first column, I put
$last_license_id = $license_id; at the end of my while loop,
then if that is not the same, I echo
the left side of my HTML table.

The problem is, I need to put </option></td></tr> after the last option selection
available, and just can not figure out how to do so as of yet.

Here is what I have for my while loop, all is well but no end of table data and row or </option>

<?
while ($row = mysql_fetch_array($sql_result)) {
$license_title = $row["title"];
$text_id = $row["text_id"];
$option_code = $row["option_code"];
$option_title = $row["option_title"];
$license_id = $row["license_id"];
$price = $row["price"];
$fmt_price = sprintf("%0.2f",$price);

if ($last_license_id != $license_id) {

echo "
<tr>
<td align=right valign=middle><a href=license_options.php?text_id=$text_id target=license_text>
<font face=Arial,Helvetica,Geneva,Swiss,SunSans-Regular size=2>
$license_title</font></a></td>
<td><font face=Arial,Helvetica,Geneva,Swiss,SunSans-Regular size=2>:</font></td>
<td><font face=Arial,Helvetica,Geneva,Swiss,SunSans-Regular size=2> </font></td>
<td><select name=$text_id size=1>
<option value=>None
";
}

echo "<option value=$option_code>$option_title - \$$fmt_price";

//EVERYTHING FINE TO HERE, BUT NEED</option></td></tr> after last

$last_license_id = $license_id;

}
?>

I tried this if statement placed above where you see EVERYTING FINE TO.. but obviously it is wrong:

if ($last_license_id != $license_id) {
echo "</option></td></tr>";
}

That produces this incorrect mess on the screen:

<option value=>None
<option value= BIZ1>Single Use - $27.50
</option></td></tr>
<option value= BIZ2>Unlimited - $55.00
</option></td></tr>

What I need to produce is this:

<option value=>None
<option value= BIZ1>Single Use - $27.50
<option value= BIZ2>Unlimited - $55.00
</option></td></tr>

This example has two choices. Some have only one, while others have many.

Any help would be greatly appreciated. Sorry if this has been answered before,
I also could not figure out what to call it to search for.

Thank you all,
Mark

jerdo

You should have options inside a <select> and each individual option should have <option> and </option>, example:

<select name="stuff>
<option value="1">1</option>
<option value="2">2</option>
</select>

ahundiak

Couple of things.

You basic approach should work though it's a bit confusing.

Look closely at:
if ($last_license_id != $license_id) {
echo "</option></td></tr>";
}
And make sure there is no typo's. You might try pasting the exact code to the board.

And a select element looks like:
<select name="me">
<option value="1">One</option>
<option value="2">Two</option>
</select>

It's possible you actually had the loop working at one point but the list did not show up because of the missing </select>

Wow. Talk about thinking alike. jerdo even used the same example.

clarkm

Sorry about that, I do have </select> correct on my page. I have gotten lazy with the </option>. I use GoLive for my WYSIWYG which stips those off and seem to have adapted the bad habit.

The Problem is still the same though.

while (blah) {
if ($last_license_id != $license_id) {
write HTML code to start new table row, if not don't. This is working as hoped.
}
echo "<option value=$option_code>$option_title - \$$fmt_price</option>";
if ($last_license_id != $license_id) {
echo "</select></td></tr>";
}
$last_license_id = $license_id;
}

The first time through at the if statement, $last_license_id, since it has not yet come to the end of the loop, is blank. This causes the if statement to be true. Now, it will write </select> after the first </option>.

Let's say the first license_id = 1; which is true for the first 2 times through the loop. Then, the next four times through the loop, license_id = 9;

The first time through at the if statement:
$license_id = 1;
$last_license_id = "";
End of loop, $last_license_id becomes 1

2nd time through
$license_id = 1;
$last_license_id =1;

Which causes this to happen using the if statement:

<option value= BIZ1>Single Use - $27.50</option>
</select>
<option value= BIZ2>Unlimited - $55.00</option>
</select>

What I need is this:

<option value= BIZ1>Single Use - $27.50</option>
<option value= BIZ2>Unlimited - $55.00</option>
</select>

Now, third time through this happens:

$license_id = 9;
$last_license_id =1;
End of loop, $last_license_id becomes 9

4th through 6th time through are good
$license_id = 9;
$last_license_id =9;

But you get this:

And should be:

This happens for each new license_id. The if statement is always true the first time through which causes it to write </select> after </option> each time.

The reason for the if statement and $last_license_id = $license_id; is because I am making an HTML table, and I only want the name of the option, in this case the license title, to be displayed once. Otherwise I would get this which I don't want:

<tr><td>Corporate & Trade Shows</td>
<td><option value=SALE1>500</option>
</select></td></tr>
<tr><td>Corporate & Trade Shows</td>
<option value=SALE2>1000</option>
</select></td></tr>

I use the $last_license_id to see if there has been a change compared to the current $license_id. If so, then I need to draw a new table row. If not, I don't.

What I am trying to figure out is what could I do along these same lines to get my </select> to show up in the right place?

Thanks again, and thanks for the quick replies!

Mark

ahundiak

Ok. I see what's happening, when license_id does change, you end writing the first part of the next <select> before finishing up the last one.

$flag = 0;
while(blah)
{
  if ($last_license_id != $license_id)
  {
    if ($flag) echo "</select></td></tr>";

echo <select etc.>
$flag = 1;
  }
  echo option;
  $last_license_id = $license_id;
}
/* Need to finish the very last row */
if ($flag) echo "</select></td></tr>";

clarkm

I don't quite see exactly what to do yet, but this is in the right direction.

Thanks again for the help. I appreciate it.

Mark

clarkm

Solved it! I moved the </select></td></tr> to the top of the loop.

<?
while (blah) {

if ($last_license_id != $license_id) {

// Added this if/blank below so it won't draw first time through,
//and moved it to top of loop.

if ($last_license_id != "") {
echo "</select></td></tr>";
}

echo "
<tr>
<td align=right valign=middle><a href=blah>$license_title</font></a></td>
<td><select name=$text_id size=1>
<option value=>None</option>
";
}

echo "<option value=$option_code>$option_title - \$$fmt_price</option>";

$last_license_id = $license_id;
}
?>

Thanks for all your help. Your example triggered the idea of moving it to the top for me.

Thanks again,
Mark