multi-upload script question

[Mark]

okay, i can easily get this script to work with multi-uploads.. if all the fields are filled. but once a user uploads something in just one of the fields, excluding the first field. it messes up. can someone tell me what i've done wrong?

<?
function do_upload($filename,$newname) {
  $file = basename($filename);
  $tmp_upload_path = "C:\\PHP\\uploadtemp\\";
  $new_file_name = "c:\\Documents and Settings\\Administrator\\Desktop\\HazardNet\\upload\\files\\".$newname;
  if (!copy($tmp_upload_path.$file, $new_file_name)) echo "failed to copy file<br>\n";
  return;
}
function do_upload2($filename2,$newname2) {
  $file2 = basename($filename2);
  $tmp_upload_path2 = "C:\\PHP\\uploadtemp\\";
  $new_file_name2 = "c:\\Documents and Settings\\Administrator\\Desktop\\HazardNet\\upload\\files\\".$newname2;
  if (!copy($tmp_upload_path.$file2, $new_file_name2)) echo "failed to copy file<br>\n";
  return;
}
function do_upload3($filename3,$newname3) {
  $file3 = basename($filename3);
  $tmp_upload_path3 = "C:\\PHP\\uploadtemp\\";
  $new_file_name3 = "c:\\Documents and Settings\\Administrator\\Desktop\\HazardNet\\upload\\files\\".$newname3;
  if (!copy($tmp_upload_path3.$file3, $new_file_name3)) echo "failed to copy file<br>\n";
  return;
}
?>

<?php
//do first upload
if(empty($userfile)){}
else{
do_upload($userfile,$newname);}

//do second upload
if(empty($userfile2)){}
else{
do_upload2($userfile2,$newname2);}

//do third upload
if(empty($userfile3)){}
else{
do_upload3($userfile3,$newname3);}
?>

[Mark]

?

[stolzyboy]

how does it mess up, does it throw errors, or what

[stolzyboy]

this here is one problem i see

$tmp_upload_path = "C:\PHP\uploadtemp\";

that last \ is escaping the ", so it is cancelling the close of that string, thus creating problems for the whole script, change it to

$tmp_upload_path = "C:\PHP\uploadtemp\"";

or

$tmp_upload_path = 'C:\PHP\uploadtemp\';

[Mark]

http://www.hazardnet.net/upload/ here test for yourself. it verys depending on what you do...

thanks for the help, just upload like txt files or images.

[stolzyboy]

try changing this

<?php
//do first upload
if(empty($userfile)){}
else{
do_upload($userfile,$newname);}

//do second upload
if(empty($userfile2)){}
else{
do_upload2($userfile2,$newname2);}

//do third upload
if(empty($userfile3)){}
else{
do_upload3($userfile3,$newname3);}
?>

to this

<?php
//do first upload
if($userfile) do_upload($userfile,$newname);

//do second upload
if($userfile2) do_upload2($userfile2,$newname2);

//do third upload
if($userfile3) do_upload3($userfile3,$newname3);
?>

thats all for now, time for some sleep, will check back tomorrow to see how you are doing

[Weedpacket]

My brain keeps pagefaulting on me right now: why have you got three separate functions doing exactly the same thing?

[Rayn]

Originally posted by Weedpacket
My brain keeps pagefaulting on me right now: why have you got three separate functions doing exactly the same thing?

I was going to say the same thing..

[stolzyboy]

well technically he isn't doing the same thing for each function

each function is taking care of a different variable, dependent on which ones are chosen to upload

i agree there are better ways to do this, but he is using different variable names in each function

$userfile //do_upload
$userfile2 //do_upload2
$userfile3 //do_upload3

[The_Chancer]

Yeah slightly different, but the same thing over and over again....

Urm... can I suggest a word in here as well....

A...R...R...A...Y...

Works wonders with things like multi-file uploads....

Oh - incidentally...

What is the temp directory in the second and third function ? missing any \ ?

[Mark]

okay well i appreciate all of you criticizing the way i have done this, but i would kinda like some help. please.

[stolzyboy]

i gave you a suggestion, did you try it

[Mark]

yes, didnt really help, just a different way of doing the same thing

[Weedpacket]

Originally posted by stolzyboy
well technically he isn't doing the same thing for each function

No, all three functions are doing exactly the same thing. The variables are all local, so nothing outside one of the functions knows or cares about what the variables inside are called; so the corresponding variables in each function call all be named the same thing without problems (e.g., the $filename1 in do_uplaod1(), the $filename2 in do_upload2(), and the $filename3 in do_upload3() could be renamed to $filename in all three functions). None of that changes the function in the slightest (since the names of the variables are merely typographical conveniences for the programmer), and leaves the only difference between them are the functions' names. I.e., three differently-named functions all doing exactly the same thing.

function do_upload3($filename,$newname) {
  $file = basename($filename);
  $tmp_upload_path = "C:\PHP\uploadtemp";
  $new_file_name = "c:\Documents and Settings\Administrator\Desktop\HazardNet\uploadfiles".$newname;
  if (!copy($tmp_upload_path.$file, $new_file_name)) echo "failed to copy file<br>n";
  return;
}

Incidentally, is "Documents and Settings" supposed to contain a double space?

[Mark]

havent you people noticed that the forum messes with spaces and slashes. well at least slashes.

p.s. - the directories arnt the problem, it uploads one file fine. but not multiple files

[stolzyboy]

yes, I'm pretty sure we know about the slashes, but not too sure about the spaces, anyway, you are getting pretty cocky for someone in need of help, chill out

any particular reason you have to do this in the function, I think this may have something to do with your problems, you could use if's to separate which ones were actually used, it may act the same, but if what weed is saying is correct, then ifs seem to be better

if ($userfile && !$userfile2 && !userfile3)
{
//do upload for $userfile only
//by do upload i mean put the actual code here
}
else if (!$userfile && $userfile2 && !userfile3)
{
//do upload $userfile2
//by do upload i mean put the actual code here
}
else if (!$userfile && !$userfile2 && userfile3)
{
//do upload for $userfile3
//by do upload i mean put the actual code here
}
else if ($userfile && $userfile2 && !userfile3)
{
//do upload for $userfile and $userfile2
//by do upload i mean put the actual code here
}
else if (!$userfile && $userfile2 && userfile3)
{
//do upload for $userfile2 and $userfile3
//by do upload i mean put the actual code here
}
else if ($userfile && !$userfile2 && userfile3)
{
//do upload for $userfile and $userfile3
//by do upload i mean put the actual code here
}
else if ($userfile && $userfile2 && userfile3)
{
//do upload for all $userfile's
//by do upload i mean put the actual code here
}
else
{
}

this should get all combos of selection

oh, and btw is there any special reason, you are needing to input the target name, just curious

[stolzyboy]

hmmm.....I also notice now that you have only one file uploader up there, that if you don't input a target name, that it throws the error, but if you input something, it doesn't, which leads me to my question from before about why you need the target name

[Weedpacket]

Do $userfile, $userfile2, and $userfile3 contain what you think they do? Or for that matter $newname, $newname2, $newname3? So far we've all been operating on the assumption you've checked that.

I'd leave the copying code in a function to save duplication; just use the same function for all three ("if it's worth doing twice, it's worth writing a function for).

(Known about the slashes for months; that's why I used [code] instead of [php]).

[Mark]

oh, and btw is there any special reason, you are needing to input the target name, just curious

no reason..

[stolzyboy]

Originally posted by Mark
no reason..

ok, cuz like i said, that is the only time i saw that the error was thrown, was when i tried to upload something and didn't put anything in the target area