coding with notice reporting on

[mmilano]

i want to start coding, or at least know how to be complian with notices. i have all errors reporting including notices.

please advise me how to adjust the code below to not get a notice.

<?php
if($_GET['player_id'])
{
  $player->setPlayer($_GET['player_id']);
}
?>

error

Notice: Undefined index: player_id in /www/player.php on line 2

thanks!

[naomi385]

A couple of ways:

$player_id =& $_GET['player_id'];

if ( $player_id ) {
   $player->setPlayer($player_id);
}

or:

if ( isset($_GET['player_id']) && $_GET['player_id'] ) {
   $player->setPlayer($_GET['player_id']);
}

I personally prefer the first way, since I try to avoid using the superglobals ($GET, $POST, etc.) when possible.