if/else mega-stupid question

[viveleroi0]

This is so mega-stupid! I should see the problem sticking out like a sore thumb... what is wrong with this? All of the variables except for $SearchList have been defined by a form posting to this...

if($Phone=="ON"){$SearchList="SELECT FROM records WHERE CustPhone=$SearchText"};
elseif($Email=="ON"){$SearchList="SELECT FROM records WHERE CustEmail=$SearchText"};
elseif($Zip=="ON"){$SearchList="SELECT * FROM records WHERE CustZip=$SearchText"};
else{$SearchList="0"};

[ahundiak]

This:
else{$SearchList="0"};
Should be
elseif{$SearchList="0"};
It clobbers $Email and $Zip.

IMHO, switch statements are easier to read than multiple elseif's.

Update: Can't really use a switch statement here so disregard the above comment. For some reason, Edit won't le met delete it.

[ahundiak]

Please disregard the above comment on switch statements. Be difficult to use a switch for this routine. Edit Post does not seem to be working.

[viveleroi0]

that doesn't solve it. The error is on this line:

if($Phone=="on"){$SearchList="SELECT * FROM records WHERE CustPhone=$SearchText"};

[viveleroi0]

removing that line solves the error, but obviously the script wont work. Here is the section in its entirety if you think it has something to do with the context:

elseif($URI6=="ProcessSearch"){

if($Phone=="on"){$SearchList="SELECT FROM records WHERE CustPhone=$SearchText"};
elseif($Email=="on"){$SearchList="SELECT FROM records WHERE CustEmail=$SearchText"};
elseif($Zip=="on"){$SearchList="SELECT * FROM records WHERE CustZip=$SearchText"};

$SearchOrders=mysql_query("$SearchList");
$num=mysql_num_rows($SearchOrders);
if($num==0){echo"$header $NoResults $footer";}else{
$i=0;
while ($i < $num) {
$CustName=mysql_result($SearchOrders,$i,"CustName");
$CustEmail=mysql_result($SearchOrders,$i,"CustEmail");
$CustID=mysql_result($SearchOrders,$i,"CustID");
$CustOrders=mysql_result($SearchOrderst,$i,"CustOrders");
$CustPrice=mysql_result($SearchOrders,$i,"CustPrice");
$CustDate=mysql_result($SearchOrders,$i,"CustDate");
$CustComments=mysql_result($SearchOrders,$i,"CustComments");
$CustMisc=mysql_result($SearchOrders,$i,"CustMisc");
$CustAddress=mysql_result($SearchOrders,$i,"CustAddress");
$CustZip=mysql_result($SearchOrders,$i,"CustZip");
$CustPhone=mysql_result($SearchOrders,$i,"CustPhone");

echo("$header $OrderToolBar
<table border=\"1\" class=\"allen\" cellpadding=\"0\" cellspacing=\"0\" bordercolor=\"7B3132\" width=\"100%\" ><tr>
<td valign=\"top\"><a href=\"mailto:$CustEmail\">$CustName</a><br />
$CustAddress $CustZip<br />
$CustPhone</td>
<td valign=\"top\" class=\"allen\" height=\"80\">$CustComments</td></tr><tr>
<td valign=\"top\" colspan=\"2\" class=\"allen\">$CustOrders</td></tr><tr>
<td valign=\"top\" colspan=\"2\" class=\"allen\" align=\"right\">Total: $$CustPrice</td>
</tr></table><p>
$footer");
++$i;}
}
}

[ahundiak]

Ahhh. You should have said you were getting syntax errors. Your semi-colon is on the wrong side of the squigly bracket.
if ($Phone == 'On')
{
$whatever = $thisever;
}
Also, you will probably need single quotes around $SearchText in your queries.