Unexpected output from a simpl form

astoller

The following piece of code doesn’t generate my expected answer.
I am running everything locally on my pc with apache and mysql .
What am I doing wrong?

/Set the variables for the database access

$Host= "localhost";
$User= "root";
$Password = "123";
$DBName = "NewDatabase";
$TableName = "Feedback";

$Link = mysql_connect($Host, $User, $Password);

$Query= "INSERT into $TableName Values ('0',
'$Array[Company]', '$Array[Logo]', '$Array[Strapline]', '$Array[Activity]',
'$Array[Contact]', '$Array[Phone]', '$Array[Mobile]', '$Array[Email]',
'$Array[Add1]', '$Array[Add2]', '$Array[Add3]', '$Array[Add4]',
'$Array[Postcode]', '$Array[Text]')";

print ("The query is : $Query \n");

if (mysql_db_query ($DBName, $Query, $Link))
{
print ("The query was successfully executed \n");
}
else {
print ("The query coud not be executed \n");

Here is the faulty result:
$Query

\n"); if (mysql_db_query ($DBName, $Query, $Link)) { print ("The query was successfully executed
\n"); } else { print ("The query coud not be executed
\n"); } mysql_close ($link);

uniflare

$Query= "INSERT into $TableName Values ('0',
'$Array[Company]', '$Array[Logo]', '$Array[Strapline]', '$Array[Activity]',
'$Array[Contact]', '$Array[Phone]', '$Array[Mobile]', '$Array[Email]',
'$Array[Add1]', '$Array[Add2]', '$Array[Add3]', '$Array[Add4]',
'$Array[Postcode]', '$Array[Text]')";

could be wrong SQL code, this is more stable:

$Query= "INSERT into `$TableName`
(company,logo,strapline,activity,contact,phone,mobile,email,add1,add2,add3,add4,postcode,text) Values ('0',
'$Array[Company]', 
'$Array[Logo]', 
'$Array[Strapline]', 
'$Array[Activity]',
'$Array[Contact]', 
'$Array[Phone]', 
'$Array[Mobile]', 
'$Array[Email]',
'$Array[Add1]', 
'$Array[Add2]', 
'$Array[Add3]', 
'$Array[Add4]',
'$Array[Postcode]', 
'$Array[Text]')";

Note: The function "mysql_db_query" has been deprecated since PHP 4.0.6. Do not use this function. Use mysql_select_db() and mysql_query() instead.

\n"); if (mysql_db_query ($DBName, $Query, $Link)) { print ("The query was successfully executed
\n"); } else { print ("The query coud not be executed
\n"); } mysql_close ($link);

is wrong and would display an error... this is correct:

mysql_select_db($DBName, $Link) and mysql_query($Querym $Link);

if(mysql_error() != null){
    echo("An error has occured--- <b>".mysql_errno().":</b> ".mysql_error();
}

...

if this does not help, please tell me what answer you were expecting, and what answer you actually got, thx

astoller

I have added your suggestions.
I now run the form.html which inputs the fields and passes them to this script.
The result is as before.

I expected to get a message showing my query string (So I know its valid)
and I also expected a message saying:

The query was successfully executed
or
The query could not be executed.

Art

<?php
/this page receives and handles the data frm form.html/
//trim the incoming data

$Array ["Company"] = trim ($Array["Company"]);
$Array ["Logo"] = trim ($Array["Logo"]);
$Array ["Strapline"] = trim ($Array["Strapline"]);
$Array ["Activity"] = trim ($Array["Activity"]);

$Array ["Contact"] = trim ($Array["Contact"]);
$Array ["Phone"] = trim ($Array["Phone"]);
$Array ["Mobile"] = trim ($Array["Mobile"]);
$Array ["Email"] = trim ($Array["Email"]);

$Array ["Add1"] = trim ($Array["Add1"]);
$Array ["Add2"] = trim ($Array["Add2"]);
$Array ["Add3"] = trim ($Array["Add3"]);
$Array ["Add4"] = trim ($Array["Add4"]);

$Array ["Postcode"] = trim ($Array["Postcode"]);
$Array ["Text"] = trim ($Array["Text"]);

//Set the variables for the database access

$Host= "localhost";
$User= "root";
$Password = "123";
$DBName = "NewDatabase";
$TableName = "Feedback";

$Link = mysql_connect($Host, $User, $Password);

$Query= "INSERT into '$TableName'
(company,logo,strapline,activity,contact,phone,mobile,email,add1,add2,add3,add4,postcode,text)
values ('0',
'$Array[company]',
'$Array[Logo]',
'$Array[Strapline]',
'$Array[Activity]',
'$Array[Contact]',
'$Array[Phone]',
'$Array[Mobile]',
'$Array[Email]',
'$Array[Add1]',
'$Array[Add2]',
'$Array[Add3]',
'$Array[Add4]',
'$Array[Postcode]',
'$Array[Text]')";

// Test to let you see if your query was valid

print ("The query is : $Query \n");

if (mysql_query ($DBName, $Query, $Link)) {
print ("The query was successfully executed \n");
} else {
print ("The query coud not be executed \n");
}

mysql_close ($link);
?>
</body>
</html>

matt_4013

The question isn't what you expected to get, but what you actually ARE getting. What is the script actually outputting?

astoller

Apache and php seem not to be talking to each other so I am going back to re isntalling php and apache config files.
Thanks
Art

Norman_Graham

This is certainly not the problem. Why don't you post the output and then we'll see what the problem might be.

Norm

astoller

Here is the resulting ouput of running my script:

$Query
\n"); if (mysql_query ($DBName, $Query, $Link)) { print ("The query was successfully executed
\n"); } else { print ("The query coud not be executed
\n"); } mysql_close ($link); ?>

Incidentally, previous scripts worked and talked to mysql.
Now they dont.
I just dont know what went wrong
Art

Norman_Graham

I'm sure PHP is still talking to MySQL - there's just something wrong with your code. This is just a query - this isn't the output - and what are those newline characters doing in your query?? Are you saying this is what prints to the browser? If so, click on View/Show source code and post the content.

Norm

astoller

Yes, this is what is being printed to browser.
View source givews me:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">

<html>
<head>
<title>HandleForm2</title>
</head>

<body>
<?php
/this page receives and handles the data frm form.html/
//trim the incoming data

$Array ["Company"] = trim ($Array["Company"]);
$Array ["Logo"] = trim ($Array["Logo"]);
$Array ["Strapline"] = trim ($Array["Strapline"]);
$Array ["Activity"] = trim ($Array["Activity"]);

$Array ["Contact"] = trim ($Array["Contact"]);
$Array ["Phone"] = trim ($Array["Phone"]);
$Array ["Mobile"] = trim ($Array["Mobile"]);
$Array ["Email"] = trim ($Array["Email"]);

$Array ["Add1"] = trim ($Array["Add1"]);
$Array ["Add2"] = trim ($Array["Add2"]);
$Array ["Add3"] = trim ($Array["Add3"]);
$Array ["Add4"] = trim ($Array["Add4"]);

$Array ["Postcode"] = trim ($Array["Postcode"]);
$Array ["Text"] = trim ($Array["Text"]);

//Set the variables for the database access

$Host= "localhost";
$User= "root";
$Password = "123";
$DBName = "NewDatabase";
$TableName = "Feedback";

$Link = mysql_connect($Host, $User, $Password);

//The following line is a test for developemnt only. Then remove it.
print ("The query is : $Query \n");

if (mysql_query ($DBName, $Query, $Link)) {
print ("The query was successfully executed \n");
} else {
print ("The query coud not be executed \n");
}

mysql_close ($link);
?>
</body>
</html>

Art

Natty_Dreadlock

ok as u can see the php section is not being parsed - Probably u should first post a question in the installation forum in order to solve your problems with apache/php...

Norman_Graham

OK, let's start from scratch. Do the php_info() thing in your document root:

<?php
php_info();
?>

and save as test.php (make sure the suffix is .php and not .php.txt or similar). Does this produce the table of php settings? If not, then Apache is not configured correctly to parse PHP, in which case you need to go back and check your httpd.conf file under Apache.

If you do get the table of php info, then check your file shown here. Are you sure it has the ending .php, because I suspect it ends with .html, which is why it's being parsed as HTML.

Best o luck

Norm

astoller

Yes, I got the apache info page working.

My problem was I was using explorer to directly access the various pages whereas I should have been browsing to localhost

Sorry about that, but I am relatively new to PHP

Thanks for all your help
Art