Can't update item in mysql table via php form

[inthestars]

I have a form that updates an item pulled from a database, but after the form is posted, it does not update the mysql database with the new info, here's what I am using:

<?
$id=$GET['id'];
$password=$GET['password'];
$email=$GET['email'];
$banner=$GET['banner'];
$sponsor1=$GET['sponsor1'];
$sponsor2=$GET['sponsor2'];
$sponsor3=$GET['sponsor3'];
$sponsor4=$GET['sponsor4'];
$sponsor5=$GET['sponsor5'];
$trade1=$GET['trade1'];
$trade2=$GET['trade2'];
$trade3=$GET['trade3'];
$trade4=$GET['trade4'];
$trade5=$GET['trade5'];
$trade6=$GET['trade6'];
$trade7=$GET['trade7'];
$trade8=$GET['trade8'];
$trade9=$GET['trade9'];
$trade10=$_GET['trade10'];

$db_name="jazz";

$table_name="mine";

$connection = @mysql_connect("localhost", "username", "passwordxxx") or die ("Couldn't connect.");

$db= @mysql_select_db($db_name, $connection) or die("Couldn't select database.");

$query="UPDATE mine set password=$password,email=$email, banner=$banner, sponsor1=$sponsor1,sponsor2=$sponsor2,sponsor3=$sponsor3,sponsor4=$sponsor4,sponsor5=$sponsor5,trade1=$trade1,trade2=$trade2,trade3=$trade3,trade4=$trade4,trade5=$trade5,trade6=$trade6,trade7=$trade7,trade8=$trade8,trade9=$trade9,trade10=$trade10 where id=$id";
mysql_query($query);
echo "Record Updated";
mysql_close();

?>

[Mordecai]

Any errors?

Often, I notice that it doesn't do it, nor gives an error.. I'm not really sure why. I usually just get the old info, erase it, and make a new one.. but you can't keep an id that way, if you have one.

[matt_4013]

Hi there, give this a go:

<?

foreach($_GET as $k=>$v) {

/* This does exactly what your list of variable assignations did,	
but this is 100 times easier ;) */
$$k = $v;
}

$db_name="jazz";

$table_name="mine";

$connection = @mysql_connect("localhost", "username", "passwordxxx") or die ("Couldn't connect.");

$db= @mysql_select_db($db_name, $connection) or die("Couldn't select database.");

// Just formatted this to make it a bit easier to read, and used the table_name variable
// Added quotes around your values (this was your problem)
$query  = "UPDATE $table_name SET password='$password', ";
$query .= "email='$email', banner='$banner', sponsor1='$sponsor1', ";
$query .= "sponsor2='$sponsor2',sponsor3='$sponsor3',sponsor4='$sponsor4', ";
$query .= "sponsor5='$sponsor5',trade1='$trade1',trade2='$trade2', ";
$query .= "trade3='$trade3',trade4='$trade4',trade5='$trade5', ";
$query .= "trade6='$trade6',trade7='$trade7',trade8='$trade8', ";
$query .= "trade9='$trade9',trade10='$trade10' WHERE id='$id'";

// Check if the query worked, if it did, it will say record updated, else Update Failed.
if(($result = mysql_query($query, $db)) === false) {

echo "Update Failed!";
} else {
	echo "Record Updated";
}
mysql_close();

?>

[inthestars]

Thanks but it does not work. I got this:

Warning: mysql_query(): supplied argument is not a valid MySQL-Link resource in /usr/home/tara/domains/hotmoviepost.com/users/update.php on line 29
Record Updated

[matt_4013]

oops, my bad, misread your variables 🙂

Change the line:
if(($result = mysql_query($query, $db)) === false) {
to:
if(($result = mysql_query($query, $connection)) === false) {

[inthestars]

That still doesn't work..

[matt_4013]

What's the error message this time?

[inthestars]

It simply does not update, no error message.