Can't Figure it out

the_myth

I'm working on this very simple user authentication script. I'm getting a parse error on the line I bolded below in the script.

<html>
<head>
<title>Password Checking Script</title>
</head>
<body>
<?
function print_form() {
?>

    <form action="check_password.php" method="POST">
    <h3>Please Login</H3>
    User Name: <input type="text" name="user_name"><br>
    Password: <input type="password" name="password">
    <input type="submit" name="submit" value="Login">
    </form>

}

    if(isset($submit));

    if(!$db = mysql_connect("localhost", "root")):
            print("<h1>Can't connect to the DB!</h1>\n");

    else:
            mysql_select_db("mattdb", $db);
    endif;

    $sql = "select * from users where user_name = '$user_name'";
    $result = mysql_query($sql);
    $row_count = mysql_num_rows($result);
    if ($row_count == 0):
            ?>
            <H3>Wrong User Name! Try Again!</h3>
            <?
            print_form();
    else:
    $row = mysql_fetch_array($result);
            if($password != $row["user_password"]):
            ?>
            <h3>Incorrect Password: Try Again!</h3>
            <?
            print_fom();
    else:
            ?>
            <H3>Password Accepted!</h3>
            <?
    endif;

endif;
else:
print_form();
endif;
?>
</body>
</html>

Any idea?

pablodelapena

I dont have a clkue as i use statrements like this if () { } else { } with those brackets, but for the sak eof others. its easier if you use the php tags.

<html> 
<head> 
<title>Password Checking Script</title> 
</head> 
<body> 
<? 
function print_form() { 
?> 

<form action="check_password.php" method="POST"> 
<h3>Please Login</H3> 
User Name: <input type="text" name="user_name"><br> 
Password: <input type="password" name="password"> 
<input type="submit" name="submit" value="Login"> 
</form> 

<? 

} 

if(isset($submit)); 

if(!$db = mysql_connect("localhost", "root")): 
print("<h1>Can't connect to the DB!</h1>\n"); 

else: 
mysql_select_db("mattdb", $db); 
endif; 

$sql = "select * from users where user_name = '$user_name'"; 
$result = mysql_query($sql); 
$row_count = mysql_num_rows($result); 
if ($row_count == 0): 
?> 
<H3>Wrong User Name! Try Again!</h3> 
<? 
print_form(); 
else: 
$row = mysql_fetch_array($result); 
if($password != $row["user_password"]): 
?> 
<h3>Incorrect Password: Try Again!</h3> 
<? 
print_fom(); 
else: 
?> 
<H3>Password Accepted!</h3> 
<? 
endif; 
endif; 
else: 
print_form(); 
endif; 
?> 
</body> 
</html>

BeastRider

Almost always missing braces somewhere when you gt to the end of the script with an error. Check your if statements.

laserlight

Your problem lies on:
if(isset($submit));

Here's an indented version of a possible solution:

<?php
function print_form() {
?>
<form action="check_password.php" method="POST"> 
<h3>Please Login</H3> 
User Name: <input type="text" name="user_name"><br> 
Password: <input type="password" name="password"> 
<input type="submit" name="submit" value="Login"> 
</form>
<?php
}
?>
<html>
<head>
<title>Password Checking Script</title>
</head>
<body>
<?php
if (isset($submit)):
	//connect to and select the database
	if (!$db = mysql_connect("localhost", "root")):
		echo "<h1>Can't connect to the DB!</h1>\n";
	else:
		mysql_select_db("mattdb", $db);
	endif;

//check the users table for the corresponding user_name
$sql = "select * from users where user_name = '$user_name'";
$result = mysql_query($sql);
$row_count = mysql_num_rows($result);
if ($row_count == 0):
	echo "<h3>Wrong User Name! Try Again!</h3>\n";
	print_form();
else:
	$row = mysql_fetch_array($result);
	if ($password != $row["user_password"]):
		echo "<h3>Incorrect Password: Try Again!</h3>\n";
		print_form();
	else:
		echo "<h3>Password Accepted!</h3>\n";
	endif;
endif;
else:
	print_form();
endif;
?>
</body>
</html>

You may might to use $_POST['submit'] etc instead of assuming register_globals is set to on.
In addition, if you dont plan to use the $row_count variable, it is better to bypass it and compare mysql_num_rows($result) to 0