Query that won't work

Tekron-X

Probably a stupid error that I can't find.

<?php
//createsupuser.php
//Created By: Bill Lewis
include "./common_db.inc";
if(empty($_POST['superusername'])) error_message("Enter a UserName");
if(empty($_POST['superuserpass'])) error_message("Enter a UserPass");
if(empty($_POST['superuseremail'])) error_message("Enter a E-mail");
if(empty($_POST['superuseremp']))  error_messgae("Enter a Empire Name");
if(empty($_POST['superuseralignment'])) error_message("Enter a Alignment");

$link_id = db_connect();

$suquery = "INSERT INTO user VALUES( , \"$_POST['superusername']\",
            \"$_POST['superuserpass']\", \"$_POST['superuseremail']\",
            curdate(), 1, \"$POST_['superuseremp']\", ,
            \"$_POST['superuseralignment']\")";
$insert = mysql_querey($suquery);
if(!$insert)
{
    echo "We made a booboo in the querey!";
}
else
{
    echo "YEY no booboo go check the db!";
}
?>

I am getting an undefined variable on all variables in my query and i can't find out why seems ok to me.

Zack

try using the "elseif" code instead of "error_message"

Tekron-X

sry but the error is not up there it is down in the $suquery variable. 😉

tsinka

Hi,

you use mysql_querey it should be mysql_query. Try to name the fields you want to insert instead of using (,value,,value).

It's easier to read if you don't use $_POST directly in the query but if you want to I'd suggest to do it this way:

$string = "INSERT INTO .... VALUES ('".$_POST['variable']."'");

Example:

//createsupuser.php
//Created By: Bill Lewis
include "./common_db.inc";

$strSuperusername      = "";
$strSuperuserpass      = "";
$strSuperuseremail     = "";
$strSuperuseremp       = "";
$strSuperuseralignment = "";

if(!isset($_POST['superusername']) || (($strSuperusername = $_POST['superusername']) == "")) {
    error_message("Enter a UserName");
}

if(!isset($_POST['superuserpass']) || (($strSuperuserpass = $_POST['superuserpass']) == "")) {
    error_message("Enter a UserPass");
}

if(!isset($_POST['superuseremail']) || (($strSuperuseremail = $_POST['superuseremail']) == "")) {
    error_message("Enter a E-mail");
}

if(!isset($_POST['superuseremp']) || (($strSuperuseremp = $_POST['superuseremp']) == "")) {
    error_messgae("Enter a Empire Name");
}

if(!isset($_POST['superuseralignment']) || (($strSuperuseralignment = $_POST['superuseralignment']) == "")) {
    error_message("Enter a Alignment");
}

$link_id = db_connect();

$suquery = <<< EOSQL
INSERT INTO user (name,pass,email,date,whatever,emp,alignment)
     VALUES ('$strSuperusername','$strSuperuserpass',
             '$strSuperuseremail',curdate(),1,
             '$strSuperuseremp','$strSuperuseralignment')
EOSQL;


$insert = mysql_query($suquery);
if(!$insert)
{
    echo "We made a booboo in the querey! Error: ".mysql_error();
}
else
{
    echo "YEY no booboo go check the db!";
}

opdsimran

Hi,

Try using this..

$suquery = "INSERT INTO user VALUES( , \"".$POST['superusername']."\",
\"".$POST['superuserpass']."\", \"".$POST['superuseremail']."\",
curdate(), 1, \"".$POST['superuseremp']."\", ,
\"".$_POST['superuseralignment']."\")";
$insert = mysql_query($suquery);

let me know..

Regards
OM

sdjensen

You have a extra , in front of $_POST['superusername'].

Use this query:

$suquery = "INSERT INTO user VALUES(\"$_POST['superusername']\",
            \"$_POST['superuserpass']\", \"$_POST['superuseremail']\",
            curdate(), 1, \"$POST_['superuseremp']\", ,
            \"$_POST['superuseralignment']\")";

Tekron-X

well Iwill see what I can do with all your great help.

The ',' is not a extra one lol it is there to tell the insert query to set it to the default value.

Tekron-X

Ok I got an error here

We made a booboo in the querey!You have an error in your SQL syntax near '', 'Good')' at line 4

which is this line and the variable $superuseralign

$suquery = "INSERT INTO user (userid, userpassword, useremail, registerdate,
                              userpriv, userempire, useralignment)
            VALUES('$superusername', '$superuserpass', '$superuseremail',
                   curdate(), '$superpriv', $superuseremp',
                   '$superuseralign')";

Tekron-X

OH shit I thnk I kknwo what it is lol that is a enum in the database oh stupid me lol.