trouble with variables

[Okami]

This is the code I am useing to create a link from my database and send the varialbe $catid.

function display_categories($cat_array)
{
if(!is_array($cat_array))
{
echo "No categories currently available.<br>";
return;
}
echo "<ul>";
foreach($cat_array as $row)
{
$url = "show_cat.php?catid=".($row["catId"]);
$title = $row["catName"];
echo "<li>";
do_html_url($url, $title);
}
echo "</ul>";
echo "<hr>";
}

Everything works fine except that I cant echo $catid varialbe on any page. The URL looks llike this:

http://panhandleguitar.com/show_cat.php?catid=5?

If I substitute the catId from my database table things work correctly, I just cat get it to work using $catid variable.

[scoppc]

I dont really get your problem, actually. But I guess the trouble that you got (fail to get the catid value from the URL) is caused by the extra "?" symbol. Correct me if I am wrong.

Can you post your do_html_url() function?

[tsinka]

Hi,

remove the trailing/second ? from your url call, it will destroy you catid get variable.

[Okami]

Here is my url function:

<?php
function do_html_url($url, $title)
{
?>
<a href = "<?=$url?>"<?=$title?></a><br>
<?php
}
?>

[tsinka]

Hi,

you have an error in that function, the <a href isn't closed, try:

<?php 
function do_html_url($url, $title) 
{ 
?> 
<a href = "<?=$url?>"><?=$title?></a><br> 
<?php 
} 
?>

Besides that the code could be "clarified" by removing unneeded <?=??? ?> tags 🙂

[Okami]

Thanks for the help.

Everything is working now