Am i not seeing something? $_SERVER

[empire]

Hi, I keep getting these errors in the script..any ideas?
Errors:
Notice: Undefined index: 'REMOTE_ADDR' in /www/e/empireind/htdocs/Cart/index.php on line 39
Notice: Undefined index: 'PHP_SELF' in /www/e/empireind/htdocs/Cart/index.php on line 42
Warning: Cannot modify header information - headers already sent by (output started at /www/e/empireind/htdocs/Cart/index.php:25) in /www/e/empireind/htdocs/Cart/index.php on line 42

Code:
if ($UID == "") {
$dt=date("YmdHis");
$UID="$dt$SERVER['REMOTE_ADDR']";
$date=date("z");
mysql_query("INSERT INTO Users VALUES ('$UID','$date')");
Header("Location: $SERVER['PHP_SELF']?UID=$UID");
}

Thanks!

[matt_4013]

Try this:

if ($UID == "") {
$dt=date("YmdHis");
$UID="$dt".$_SERVER['REMOTE_ADDR'];
$date=date("z");
mysql_query("INSERT INTO Users VALUES ('$UID','$date')");
Header("Location: ".$_SERVER['PHP_SELF']."?UID=$UID");
}

[empire]

thanks for the response, that fixed it! now i have another error of course :/

Errors:
Notice: Undefined variable: UID in /www/e/empireind/htdocs/Cart/index.php on line 25
Notice: Undefined variable: UID in /www/e/empireind/htdocs/Cart/index.php on line 37
Warning: Cannot modify header information - headers already sent by (output started at /www/e/empireind/htdocs/Cart/index.php:25) in /www/e/empireind/htdocs/Cart/index.php on line 42

Code:
if ($UID != "") {
$result=mysql_query("SELECT * FROM Users WHERE User='$UID'");
$num=mysql_num_rows($result);
if ($num == "0") {
$dt=date("YmdHis");
$UID="$dt".$SERVER['REMOTE_ADDR'];
$date=date("z");
mysql_query("INSERT INTO Users VALUES ('$UID','$date')");
Header("Location: ".$SERVER['PHP_SELF']."?UID=$UID");
}
}

if ($UID == "") {
$dt=date("YmdHis");
$UID="$dt".$SERVER['REMOTE_ADDR'];
$date=date("z");
mysql_query("INSERT INTO Users VALUES ('$UID','$date')");
Header("Location: ".$SERVER['PHP_SELF']."?UID=$UID");
}

[stolzyboy]

if the UID is from a post use

$UID = $_POST['UID'];

or from get

$UID = $_GET['UID'];

[empire]

im sorry, but im new to php...when would i use the post and when would i use the get? it is supposed to get the users ID when they enter the page...would that be get? also, if it was get, i just put?:
if ($UID = $_GET['UID']) {

thanks

[stolzyboy]

no, where are you getting the $UID from

is it coming from the url, or from a form posting

then before you do your if

do one or the other of the $UID lines i gave you

this is most likely a register_globals = Off problem, which is a
good problem to have

[empire]

hmmm..well i am customizing a shopping cart that i got...it is the index.php . this is the full code. since it is the first page that the user sees, im not exactly sure where the variable is coming from.

<?
require("Cart.php");
DBinfo();
Brand();
Root();
$link = mysql_connect("$DBHost", "$DBUser", "$DBPass")
or die ('Cannot connect to the MySQL server.');
mysql_select_db ("$DBName")
or die ('Cannot connect to the database.');
$old=date("z")-1;
mysql_query("DELETE FROM Users WHERE Date < $old");

$result=mysql_query("SELECT CartItemsID,Date FROM CartItems");
while ($row=mysql_fetch_row($result)) {
$CII=$row[0];
$CDa=$row[1];
$pieces=explode(":",$CDa);
$DCHK=$pieces[1];
if ($DCHK < $old) {
mysql_query("DELETE FROM CartItems WHERE CartItemsID = '$CII'");
}
}

if ($UID != "") {
$result=mysql_query("SELECT * FROM Users WHERE User='$UID'");
$num=mysql_num_rows($result);
if ($num == "0") {
$dt=date("YmdHis");
$UID="$dt".$SERVER['REMOTE_ADDR'];
$date=date("z");
mysql_query("INSERT INTO Users VALUES ('$UID','$date')");
Header("Location: ".$SERVER['PHP_SELF']."?UID=$UID");
}
}

if ($UID == "") {
$dt=date("YmdHis");
$UID="$dt".$SERVER['REMOTE_ADDR'];
$date=date("z");
mysql_query("INSERT INTO Users VALUES ('$UID','$date')");
Header("Location: ".$SERVER['PHP_SELF']."?UID=$UID");
}
commonHeader("$Company","Select a category");

$result=mysql_query("SELECT * FROM Category ORDER BY Category");
fontFace("Arial","Select a category:<br><br>");
echo "<ul>";
while ($row = mysql_fetch_row($result)) {
$Cat=$row[0];
$CatID=$row[1];
fontFace("Arial","<li><a href='$Relative/items.php?CA=$CatID&UID=$UID'>$Cat</a></li>");
}
echo "</ul>";

commonFooter($Relative,$UID);
mysql_close($link);
?>

[matt_4013]

if your $UID is coming from the url, then you want:

$UID = $_GET['UID'];
if($UID != "") {

This will stop the notice of the undefined variable coming up, because you're defining it before using it in a condition. BUT, this will only work if UID is set in the URL, otherwise you'll get an undefined index error. What your main problem here is, is error reporting. It's set to E_ALL, which will spit out an error for every tiny detail, which sucks. I would suggest changing your code to this:

error_reporting(E_ALL ^ E_NOTICE);

$UID = $_GET['UID'];

if ($UID != "") {
$result=mysql_query("SELECT * FROM Users WHERE User='$UID'");
$num=mysql_num_rows($result);
if ($num == "0") {
$dt=date("YmdHis");
$UID="$dt".$_SERVER['REMOTE_ADDR'];
$date=date("z");
mysql_query("INSERT INTO Users VALUES ('$UID','$date')");
Header("Location: ".$_SERVER['PHP_SELF']."?UID=$UID");
}
}

if ($UID == "") {
$dt=date("YmdHis");
$UID="$dt".$_SERVER['REMOTE_ADDR'];
$date=date("z");
mysql_query("INSERT INTO Users VALUES ('$UID','$date')");
Header("Location: ".$_SERVER['PHP_SELF']."?UID=$UID");
}

This says, report all errors, except notice errors 🙂

[stolzyboy]

maybe find your php.ini and look around line 235 or so

and turn register_globals on if it is off, do so by changing

register_globals = Off

to

register_globals = On

make sure to restart apache after making changes and saving file

if the code then works, you definitely have a globals problem, but you can leave it on if you want

other than that i would have to look closer and its time to play a game of sleep

[empire]

matt: you are right...now i got an index error haha...i will add the
error_reporting(E_ALL ^ E_NOTICE);

thanks so much for every1's help! now i can go to sleep :o

[empire]

AHHHHH:mad: i have one more error popping up. it says the error is on the last line of this code:

Warning: Cannot modify header information - headers already sent by (output started at /www/e/empireind/htdocs/Cart/index.php:2) in /www/e/empireind/htdocs/Cart/index.php on line 46

$UID = $_GET['UID'];
if ($UID != "") {
$result=mysql_query("SELECT * FROM Users WHERE User='$UID'");
$num=mysql_num_rows($result);
if ($num == "0") {
$dt=date("YmdHis");
$UID="$dt".$_SERVER['REMOTE_ADDR'];
$date=date("z");
mysql_query("INSERT INTO Users VALUES ('$UID','$date')");
Header("Location: ".$_SERVER['PHP_SELF']."?UID=$UID");
}
}

if ($UID == "") {
$dt=date("YmdHis");
$UID="$dt".$_SERVER['REMOTE_ADDR'];
$date=date("z");
mysql_query("INSERT INTO Users VALUES ('$UID','$date')");
Header("Location: ".$_SERVER['PHP_SELF']."?UID=$UID"); 
}

[matt_4013]

Nope, it's saying that it cannot add header information on line 46, the actual error is on line 2. Make sure you don't have any blank space above your <?php tags. There can be NONE, no spaces, no newlines, nothing. As soon as something is sent to the browser, then header() functions will no longer work 😉

[empire]

i have the <html> and <body> above the <?
is that whats causing the problems? if so, do i just move it down below the ?>
thanks so much matt

[stolzyboy]

you need to move ANY output to after the header(), or put

ob_start();

at the top of your script before you <html> tag

[rklapwijk]

You can also use this code snippet to check if UID is set:
I always you this function, do NEVER EXPECT that some settings are turned on in the php.ini file. Huge mistake if you're doing so

if (isset($POST["UID"])) $UID = $POST["UID"]; // maybe send thru post form?
elseif (isset($GET["UID"])) $UID = $GET["UID"];// maybe in query string?
elseif (isset($SESSION["UID"])) $UID = $SESSION["UID"];// maybe as session?
elseif (isset($COOKIE["UID"])) $UID = $COOKIE["UID"]; // maybe as cookie?
else $UID = ""; // not set as a cookie, get, post or session var, return empty

[matt_4013]

rklapwijk, an easier way to do the same thing would be to use this:

$UID = (isset($_REQUEST['UID'])) ? $_REQUEST['UID'] : "";

empire: My suggestion, don't use output buffering, it's inefficient and not needed. Just move ALL of your output (all echo's, all html, all whitespace, everything) to below your header call. If you can't do this without breaking things, then I would suggest you rethink your script structure, it's a bitch to do, but once you get into the habit of coding clean and efficiently, you'll find you have a lot less troubles 🙂