upload file problem is_uploaded works but move file fails

jpeterse

Hi all,

I have a problem that I haven't been able to solve, and now I have stared my self blind on it.

Here's the code:

<?php

if ($_POST) {

  if ($_FILES['userfile']['error']) {
    print "Error occured<br>";
  } else {
    if (!is_uploaded_file($_FILES['userfile']['tmp_name'])) {
      print "Files not uploaded through HTTP POST are not allowed.<br>";
    } else {
      if (!move_uploaded_file($_FILE['userfile']['tmp_name'], '/tmp/newname.log')) {
        print "DAMN!<br>";
      }
    }
  }
  print_r($_FILES);
} else {

print <<<END
  <form enctype="multipart/form-data" action='?php print SELVF ?>' method="post">
  <input type="hidden" name="MAX_FILE_SIZE" value="30000">
  Send this file: <input name="userfile" type="file">
  <input type="submit" value="Send File">
  </form>
END;

}

?>

And here's the output:

DAMN!
Array ( [userfile] => Array ( [name] => minicom.log [type] => application/octet-stream [tmp_name] => /tmp/phpHCCOJN [error] => 0 [size] => 105 ) )

I checked the tmp directory:

ls -al / | grep tmp

drwxrwxrwt 11 apache nobody 4096 May 27 23:55 tmp

and the httpd process:

ps -ef | grep httpd

root 1799 1 0 May27 ? 00:00:00 /usr/sbin/httpd
apache 1844 1799 0 May27 ? 00:00:00 [httpd]
apache 1845 1799 0 May27 ? 00:00:00 [httpd]
apache 1846 1799 0 May27 ? 00:00:00 [httpd]
apache 1847 1799 0 May27 ? 00:00:00 [httpd]
apache 1848 1799 0 May27 ? 00:00:00 [httpd]
apache 1849 1799 0 May27 ? 00:00:00 [httpd]
apache 1850 1799 0 May27 ? 00:00:00 [httpd]
apache 1851 1799 0 May27 ? 00:00:00 [httpd]

Needless to say that the file is nowhere to be found on the server.
I have gone though the PHP manual and postings here with no luck.

Any of you have clue as to why it's not working?

Best Regards
Jan

jpeterse

I finally got the upload to work.

Here's the code I ended up, should any of you need it in the future.

<?php

if ($_POST) {

  GLOBAL $ERRORS;

  if ($_FILES['userfile']['error']) {
    print "Error occured<br>";
  } 

  if (file_exists("/tmp/".$_FILES['userfile']['name'])) {
    print "File already exstis";
  } else {
    if (is_uploaded_file($_FILES['userfile']['tmp_name'])) {
      if (move_uploaded_file($_FILES['userfile']['tmp_name'], "/tmp/".$_FILES['userfile']['name'])==false) {
        print "Move Failed";
      } else {
        print $_FILES['userfile']['name']." Uploaded successfully!";
      }
    } else {
      print "Files not uploaded through HTTP POST are not allowed.<br>";
    }
  }
} else {

print "
<html>
  <head><title>Upload</title></head>
<body>
  <form enctype=\"multipart/form-data\" action=\"".$_SERVER['PHP_SELF']."\" method=\"POST\">";

print <<<END
    <input type="hidden" name="submitted" value="true">
    Send this file: <input name="userfile" type="file">
    <input type="submit" value="Send File">
  </form>
</body>
</html>
END;
}

?>

david752

Here is a more complete example.

Attached is a file containing two subfiles:

index.html is a form used to upload a file from the user's (client) computer to a "public" directory on the server Web site. index.html is located in the "public" directory.

public-upload.php is a utility page, called by index.html, used to do the upload and report success or failure. It supports immediate testing of (browsing to) the uploaded file. Specific testing is done for the most common error: file not found.

Note that these files make use of a large library called std.phtml. That library is not provided here. The meaning of std.phtml function calls should be understandable from their name and context. The library makes individual variables for each item passed in by the POST mechanism.

Feel free to inform me of any bugs.

Enjoy!

David