[Resolved] deletion problem

[Brazil]

Hi all!

I'm a having a problem with my code.

The structure of my table in mysql database:
table name 😃etails
id int primary key auto increment
first_name varchar
surname varchar
tel_no num
fax_no num

In my php code i'm having an extra field called "delete" and inserted chekboxes in every row.A user must be able to select the checkboxes and click submit to delete.This how i inserted my checkboxes under the delete field:

<input type= checkbox name=\"id[]\" value=\"".$row["id"]."\">

(it worked)

Now my problem is that i want the user to select the checkboxes and click submit to delete.When the form is posted it must delete the selected rows only.

This is the code that is supposed to delete selected rows:
include("connect.php");

if ($submit="Submit")

{

 if(isset($delete) && count($delete) >0)
    {
  if( is_array($delete))    
 {

$delete_ids = "'" . implode("','",$delete) . "'"; 

$query = "delete from details where id IN ($delete_ids) ";  

            mysql_query($query) or 
           die (" echo mysql_error() ");
 }       
}    

$deleted_rows = mysql_affected_rows();

if ($deleted_rows == 0)
 {

   echo "No Records Deleted From The Table ";
 }

 else

  {

   echo " You Have Deleted Record/s From The Table";

  }

}

else

{

echo "Nothing happened";

}
The message that i'm getting after clicking submit is{" You Have Deleted Record/s From The Table";}, But its not deleting any selected items.Whats wrong?
Please help i'm really desparate!

[nnichols]

You refer to an array called "$delete" but the array that would come from your checkboxes is called "$id".

Which is it supposed to be?

[Brazil]

Hi 1
Thanx for responding.the array should be $id.I've tried $id also but nothing happens.

[nnichols]

Try -

if ($submit=="Submit") {

// print the contents of the array just to check you're getting what you expect
echo '$id array - <br>';
print_r($id);
echo '<br>';

$delete_ids = "'" . implode("','",$id) . "'";

$query = "DELETE FROM details WHERE id IN ($delete_ids)";

mysql_query($query) or 
    die ('MySQL error: ' . mysql_error() . '<br>Query: ' . $query);
}

[Brazil]

This line gives me an error:$delete_ids = "'" . implode("','",$id) . "'";

The error i get says:
Bad arguments to implode()

[nnichols]

Does it print the contents of the array?

It sounds like the array is not being passed to the script.

Post the code you are using to build the input form.

[Brazil]

It doesn't print an array.So i quess the array is not passed.

My code which input checkboxes looks like this:
<?php

// connect to database

include ("connect.php");

//define variables

$query =("select * from details");
$result = mysql_query($query) or
die (" echo mysql_error() ");
$num_fields = mysql_num_fields($result);
$add_field =("delete");
// create a table header

echo "<table border = 1>\n";
echo "<tr align = centre>\n";

for ($i=0;$i<$num_fields;$i++)

{

echo "<th>";
echo mysql_field_name ($result,$i);

//end of table header

"</th>";
}

echo "</tr>";

echo "<th align=centre>$add_field</th>";

while ($row = mysql_fetch_array($result, MYSQL_ASSOC))

{

echo "<tr>";

while( list ($key, $value) = each($row) )

{

echo "<td>", $value ,"</td>";

}

// inserting checkboxes
echo " <td align=top align right><input type= checkbox
name=\"id[]\" value=\"".$row["id"]."\"> </td>";

echo "</tr>";

}
echo "</table>";

?>

<form action= delete.php action=post>

<input type="submit" value="Submit" name="submit">
</form>

[nnichols]

Try this instead -

<?php 

// connect to database 

include ("connect.php"); 

//define variables 

$query = 'select * from details';
$result = @mysql_query($query)
	or die ('MySQL error: ' . mysql_error() . '<br>Query: ' . $query); 
$num_fields = mysql_num_fields($result); 

echo '<form action="delete.php" action="post">';

// create a table header 

echo "<table border = 1>\n"; 
echo "<tr align = centre>\n"; 

for ($i=0;$i<$num_fields;$i++) { 

echo "\t<th>";
echo mysql_field_name ($result,$i); 
echo "</th>\n"; 
}

echo "\t<th align=centre>delete</th>\n";

echo "</tr>"; 

while ($row = mysql_fetch_array($result, MYSQL_ASSOC)) { 

echo '<tr>';

while( list ($key, $value) = each($row) ) { 

	echo '<td>' . $value . '</td>';
}

// inserting checkboxes
echo '<td align="right" valign="top"><input type="checkbox" name="id[]" value="' . $row['id'] . '"></td>';

echo '</tr>'; 

} 

echo '</table>'; 

?> 

<input type="submit" value="Submit" name="submit"> 
</form>

You had the form opening and closing after all the form fields. The form fields to be posted as part of the form must be between the form tags.

Hope this helps

[Brazil]

It worked.Thanx very much,ive been struggling for weeks but finaly through ur help we made it.

Thanx

[nnichols]

Assuming it is working as you want now, remember to mark the thread as resolved.